From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD856C43464 for ; Fri, 18 Sep 2020 13:02:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0296821D7B for ; Fri, 18 Sep 2020 13:02:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="zhsSrNxm"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="L7TWsV+U" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0296821D7B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=l3qChAGswse5O1zAQXRoXCbenfd0EolzSNpEFXdYiRc=; b=zhsSrNxmmLfECn9aFPEijbvWE hi38TPGLBHBT8ZNf3F+ImDBqELQCrKyu3/rpl67lISPOYU38FiMeP8GImfB1r2/JxaVsDWiFzc3MJ epQEh095sAer3KTfwosu0PgojF/bbV1KqIityfeFJ/epP5sWUCr31WbkVhfovHUsnRfyWBxZVNygo bMvWHD0Qxn8IpJYZOqpw1/WeeULqtpbAydenc0TF7IZ8RFMQFWbR5whUOzDC/Yz6Ezd1mYfCWj1B3 621FJluL6iaMFKgBvc7mtdUk7AhBPUh6579nnQkdfHXJqOP5ctMFUjZUWtyhCdnC+zIw/TJ4ey/wv 7g2y3F6Lw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJG0O-0004SN-7L; Fri, 18 Sep 2020 13:00:48 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJG0K-0004RM-Nf for linux-arm-kernel@lists.infradead.org; Fri, 18 Sep 2020 13:00:45 +0000 Received: by mail-wm1-x342.google.com with SMTP id z9so5493402wmk.1 for ; Fri, 18 Sep 2020 06:00:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=j891grQjxK5nZuL7fttiNE/WOp/HbOWsFeG5TcMiTo4=; b=L7TWsV+UaIAuQHc8HWAUPeba9SlshbuAgMe0N4Yt1c9FaI30KVHDceU+jTcsZLTvHB Yj/yiotACRxgxBRxC08ptskxyuUDxXEeSnlYEGB0UcvyV8GAvfssA1MVRQHVt9xi8tlw aBuogfpXGxbU6FmkL7OuKyg+2++YtRqxb1KKBrG5YV+cKUrU4KESOV1oa3qRFjldHG8F rebr1ra97zTituSBdACNoQhSsj03qYx9S6w3v79EAaNaG5PIV+N/PTSK0sKKCheKMo7s t8mEqTKKfIS4Ed+Job4F8qPeFloBUr1W78hZVL5cqLBe2lV4+VKlbX2990/b6algGBs5 unvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=j891grQjxK5nZuL7fttiNE/WOp/HbOWsFeG5TcMiTo4=; b=FbeBMy7RrJWyqGvClqhMhNQ4SwPHWQkONYtDRVlu10HZAThGXweqq7H+CujEQF6ukM N//bgvxgGAzsBtMmuSDW8quOjUxhbTaf08KrYf7OyQxVN8uE/qWqFsxOmjMoWW+w3DVM foYmkpB/nMRHpdbX/yCy0MYQbnZnuox9lObhva4Q+hqlf53MrumIdZzEHshkjzk7bGZV QzGMlMQeEchYXhWZHBT/eEo0/EmLlujk+ooOrh4EguB+mD9pzosaasdXudOurSGKYJe6 lq0GpKocy6hFAsynKfja76vHAagA3JenXLtrMRuUo8epc9jPtFOgo5Mb86NnKY1V72iS H9aQ== X-Gm-Message-State: AOAM530qAXeJITQxnUKClQglGroKbI4gEe4NkH4d7YDJFp1vpzRTNC9I 2NN9eCfWyqbaltd0mY1IVG9nLw== X-Google-Smtp-Source: ABdhPJx3SwbH2SQ/9jKXGd0L8V8Y6NSJCHxq0HnJ0nvlRap+64gWCxVrFlRUpTHRjlE32zq2MqcCHg== X-Received: by 2002:a1c:e90b:: with SMTP id q11mr15357828wmc.39.1600434043544; Fri, 18 Sep 2020 06:00:43 -0700 (PDT) Received: from elver.google.com ([100.105.32.75]) by smtp.gmail.com with ESMTPSA id z14sm5226677wrs.76.2020.09.18.06.00.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2020 06:00:42 -0700 (PDT) Date: Fri, 18 Sep 2020 15:00:37 +0200 From: Marco Elver To: Andrey Konovalov Subject: Re: [PATCH v2 23/37] arm64: kasan: Add arch layer for memory tagging helpers Message-ID: <20200918130037.GE2384246@elver.google.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.14.4 (2020-06-18) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200918_090044_820610_AECA13FF X-CRM114-Status: GOOD ( 19.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Branislav Rankov , Elena Petrova , Catalin Marinas , Kevin Brodsky , Will Deacon , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, Alexander Potapenko , Evgenii Stepanov , Andrey Ryabinin , Andrew Morton , Vincenzo Frascino , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 15, 2020 at 11:16PM +0200, 'Andrey Konovalov' via kasan-dev wrote: > This patch add a set of arch_*() memory tagging helpers currently only > defined for arm64 when hardware tag-based KASAN is enabled. These helpers > will be used by KASAN runtime to implement the hardware tag-based mode. > > The arch-level indirection level is introduced to simplify adding hardware > tag-based KASAN support for other architectures in the future by defining > the appropriate arch_*() macros. > > Signed-off-by: Andrey Konovalov > Co-developed-by: Vincenzo Frascino > Signed-off-by: Vincenzo Frascino > --- > Change-Id: I42b0795a28067872f8308e00c6f0195bca435c2a > --- > arch/arm64/include/asm/memory.h | 8 ++++++++ > mm/kasan/kasan.h | 19 +++++++++++++++++++ > 2 files changed, 27 insertions(+) > > diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h > index e424fc3a68cb..268a3b6cebd2 100644 > --- a/arch/arm64/include/asm/memory.h > +++ b/arch/arm64/include/asm/memory.h > @@ -231,6 +231,14 @@ static inline const void *__tag_set(const void *addr, u8 tag) > return (const void *)(__addr | __tag_shifted(tag)); > } > > +#ifdef CONFIG_KASAN_HW_TAGS > +#define arch_init_tags(max_tag) mte_init_tags(max_tag) > +#define arch_get_random_tag() mte_get_random_tag() > +#define arch_get_mem_tag(addr) mte_get_mem_tag(addr) > +#define arch_set_mem_tag_range(addr, size, tag) \ > + mte_set_mem_tag_range((addr), (size), (tag)) Suggested edit below, assuming you're fine with checkpatch.pl's new 100col limit: -#define set_mem_tag_range(addr, size, tag) \ - arch_set_mem_tag_range((addr), (size), (tag)) +#define set_mem_tag_range(addr, size, tag) arch_set_mem_tag_range((addr), (size), (tag)) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.9 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7ACEC43464 for ; Fri, 18 Sep 2020 13:00:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3A11421D7B for ; Fri, 18 Sep 2020 13:00:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="L7TWsV+U" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A11421D7B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 680006B0083; Fri, 18 Sep 2020 09:00:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 655BF6B0085; Fri, 18 Sep 2020 09:00:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5452D6B0087; Fri, 18 Sep 2020 09:00:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0050.hostedemail.com [216.40.44.50]) by kanga.kvack.org (Postfix) with ESMTP id 40CAE6B0083 for ; Fri, 18 Sep 2020 09:00:46 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D1871362C for ; Fri, 18 Sep 2020 13:00:45 +0000 (UTC) X-FDA: 77276191650.04.toad58_28034182712b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id B6F50800FFDA for ; Fri, 18 Sep 2020 13:00:45 +0000 (UTC) X-HE-Tag: toad58_28034182712b X-Filterd-Recvd-Size: 5455 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Fri, 18 Sep 2020 13:00:44 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id b79so5483844wmb.4 for ; Fri, 18 Sep 2020 06:00:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=j891grQjxK5nZuL7fttiNE/WOp/HbOWsFeG5TcMiTo4=; b=L7TWsV+UaIAuQHc8HWAUPeba9SlshbuAgMe0N4Yt1c9FaI30KVHDceU+jTcsZLTvHB Yj/yiotACRxgxBRxC08ptskxyuUDxXEeSnlYEGB0UcvyV8GAvfssA1MVRQHVt9xi8tlw aBuogfpXGxbU6FmkL7OuKyg+2++YtRqxb1KKBrG5YV+cKUrU4KESOV1oa3qRFjldHG8F rebr1ra97zTituSBdACNoQhSsj03qYx9S6w3v79EAaNaG5PIV+N/PTSK0sKKCheKMo7s t8mEqTKKfIS4Ed+Job4F8qPeFloBUr1W78hZVL5cqLBe2lV4+VKlbX2990/b6algGBs5 unvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=j891grQjxK5nZuL7fttiNE/WOp/HbOWsFeG5TcMiTo4=; b=VyCJz7yxWdlmojwnldqHugDRmz/1rL/rxogH6Bmsr6ew6hkdS1h0KTRtB9SjRt6N7E 0+EFfJ4qJqw8W+fO4h4qLE1niLD08TFvR4nSQWgsOYsGpQknyIGmhjuBxku3t8Eu2jMh UArRbovZrarr8oBAg924X8WeuRqGgrLct4dqu+nIzZQjxawhDN5SM4EZt+IGrf1ewL7Y aP9NOY0exRYyPlVaF3Ot4phccDgR5dH0Twx05LXmTwDiwSE15V7cys5zQ1ycD1RhRaPl MPB/v7R9TgMF83KkZnatsuNm5qiiJhh9sgspHxYLlGyIGJe2uggkZQSuQON6nKBLVN+H HcDA== X-Gm-Message-State: AOAM533pC4SbnwEg+86MxIOB7SPWZXpJmXRiCKUz8iO1+msXZa61Fnh1 fZuUqQn8+rL0lYFiXQoAMNso0A== X-Google-Smtp-Source: ABdhPJx3SwbH2SQ/9jKXGd0L8V8Y6NSJCHxq0HnJ0nvlRap+64gWCxVrFlRUpTHRjlE32zq2MqcCHg== X-Received: by 2002:a1c:e90b:: with SMTP id q11mr15357828wmc.39.1600434043544; Fri, 18 Sep 2020 06:00:43 -0700 (PDT) Received: from elver.google.com ([100.105.32.75]) by smtp.gmail.com with ESMTPSA id z14sm5226677wrs.76.2020.09.18.06.00.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2020 06:00:42 -0700 (PDT) Date: Fri, 18 Sep 2020 15:00:37 +0200 From: Marco Elver To: Andrey Konovalov Cc: Dmitry Vyukov , Vincenzo Frascino , Catalin Marinas , kasan-dev@googlegroups.com, Andrey Ryabinin , Alexander Potapenko , Evgenii Stepanov , Elena Petrova , Branislav Rankov , Kevin Brodsky , Will Deacon , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 23/37] arm64: kasan: Add arch layer for memory tagging helpers Message-ID: <20200918130037.GE2384246@elver.google.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.14.4 (2020-06-18) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 15, 2020 at 11:16PM +0200, 'Andrey Konovalov' via kasan-dev wrote: > This patch add a set of arch_*() memory tagging helpers currently only > defined for arm64 when hardware tag-based KASAN is enabled. These helpers > will be used by KASAN runtime to implement the hardware tag-based mode. > > The arch-level indirection level is introduced to simplify adding hardware > tag-based KASAN support for other architectures in the future by defining > the appropriate arch_*() macros. > > Signed-off-by: Andrey Konovalov > Co-developed-by: Vincenzo Frascino > Signed-off-by: Vincenzo Frascino > --- > Change-Id: I42b0795a28067872f8308e00c6f0195bca435c2a > --- > arch/arm64/include/asm/memory.h | 8 ++++++++ > mm/kasan/kasan.h | 19 +++++++++++++++++++ > 2 files changed, 27 insertions(+) > > diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h > index e424fc3a68cb..268a3b6cebd2 100644 > --- a/arch/arm64/include/asm/memory.h > +++ b/arch/arm64/include/asm/memory.h > @@ -231,6 +231,14 @@ static inline const void *__tag_set(const void *addr, u8 tag) > return (const void *)(__addr | __tag_shifted(tag)); > } > > +#ifdef CONFIG_KASAN_HW_TAGS > +#define arch_init_tags(max_tag) mte_init_tags(max_tag) > +#define arch_get_random_tag() mte_get_random_tag() > +#define arch_get_mem_tag(addr) mte_get_mem_tag(addr) > +#define arch_set_mem_tag_range(addr, size, tag) \ > + mte_set_mem_tag_range((addr), (size), (tag)) Suggested edit below, assuming you're fine with checkpatch.pl's new 100col limit: -#define set_mem_tag_range(addr, size, tag) \ - arch_set_mem_tag_range((addr), (size), (tag)) +#define set_mem_tag_range(addr, size, tag) arch_set_mem_tag_range((addr), (size), (tag))