From: Minchan Kim <minchan@kernel.org>
To: Douglas Anderson <dianders@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Nitin Gupta <ngupta@vflare.org>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
sonnyrao@chromium.org, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] zram: Failing to decompress is WARN_ON worthy
Date: Fri, 18 Sep 2020 07:46:23 -0700 [thread overview]
Message-ID: <20200918144623.GA748396@google.com> (raw)
In-Reply-To: <20200917174059.1.If09c882545dbe432268f7a67a4d4cfcb6caace4f@changeid>
On Thu, Sep 17, 2020 at 05:41:20PM -0700, Douglas Anderson wrote:
> If we fail to decompress in zram it's a pretty serious problem. We
> were entrusted to be able to decompress the old data but we failed.
> Either we've got some crazy bug in the compression code or we've got
> memory corruption.
>
> At the moment, when this happens the log looks like this:
>
> ERR kernel: [ 1833.099861] zram: Decompression failed! err=-22, page=336112
> ERR kernel: [ 1833.099881] zram: Decompression failed! err=-22, page=336112
> ALERT kernel: [ 1833.099886] Read-error on swap-device (253:0:2688896)
>
> It is true that we have an "ALERT" level log in there, but (at least
> to me) it feels like even this isn't enough to impart the seriousness
> of this error. Let's convert to a WARN_ON. Note that WARN_ON is
> automatically "unlikely" so we can simply replace the old annotation
> with the new one.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Acked-by: Minchan Kim <minchan@kernel.org>
prev parent reply other threads:[~2020-09-18 14:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 0:41 [PATCH] zram: Failing to decompress is WARN_ON worthy Douglas Anderson
2020-09-18 14:46 ` Minchan Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200918144623.GA748396@google.com \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=dianders@chromium.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ngupta@vflare.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sonnyrao@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.