From: Phil Auld <pauld@redhat.com>
To: peterz@infradead.org
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
mingo@redhat.com, juri.lelli@redhat.com,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de,
linux-kernel@vger.kernel.org, valentin.schneider@arm.com,
Jirka Hladky <jhladky@redhat.com>
Subject: Re: [PATCH 0/4] sched/fair: Improve fairness between cfs tasks
Date: Fri, 18 Sep 2020 13:27:45 -0400 [thread overview]
Message-ID: <20200918172745.GI55398@lorien.usersys.redhat.com> (raw)
In-Reply-To: <20200918163928.GG55398@lorien.usersys.redhat.com>
On Fri, Sep 18, 2020 at 12:39:28PM -0400 Phil Auld wrote:
> Hi Peter,
>
> On Mon, Sep 14, 2020 at 01:42:02PM +0200 peterz@infradead.org wrote:
> > On Mon, Sep 14, 2020 at 12:03:36PM +0200, Vincent Guittot wrote:
> > > Vincent Guittot (4):
> > > sched/fair: relax constraint on task's load during load balance
> > > sched/fair: reduce minimal imbalance threshold
> > > sched/fair: minimize concurrent LBs between domain level
> > > sched/fair: reduce busy load balance interval
> >
> > I see nothing objectionable there, a little more testing can't hurt, but
> > I'm tempted to apply them.
> >
> > Phil, Mel, any chance you can run them through your respective setups?
> >
>
> Sorry for the delay. Things have been backing up...
>
> We tested with tis series and found there was no performance change in
> our test suites. (We don't have a good way to share the actual numbers
> outside right now, but since they aren't really different it probably
> doesn't matter much here.)
>
> The difference we did see was a slight decrease in the number of tasks
> moved around at higher loads. That seems to be a good thing even though
> it didn't directly show time-based performance benefits (and was pretty
> minor).
>
> So if this helps other use cases we've got no problems with it.
>
Feel free to add a
Reviewed-by: Phil Auld <pauld@redhat.com>
Jirka did the actual testing so he can speak up with a Tested-by if he
wants to.
> Thanks,
> Phil
>
> --
>
--
next prev parent reply other threads:[~2020-09-18 17:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 10:03 [PATCH 0/4] sched/fair: Improve fairness between cfs tasks Vincent Guittot
2020-09-14 10:03 ` [PATCH 1/4] sched/fair: relax constraint on task's load during load balance Vincent Guittot
2020-09-14 10:03 ` [PATCH 2/4] sched/fair: reduce minimal imbalance threshold Vincent Guittot
2020-09-15 19:04 ` Valentin Schneider
2020-09-16 6:53 ` Vincent Guittot
2020-09-16 8:33 ` Valentin Schneider
2020-09-14 10:03 ` [PATCH 3/4] sched/fair: minimize concurrent LBs between domain level Vincent Guittot
2020-09-15 19:04 ` Valentin Schneider
2020-09-16 6:54 ` Vincent Guittot
2020-09-14 10:03 ` [PATCH 4/4] sched/fair: reduce busy load balance interval Vincent Guittot
2020-09-15 9:11 ` Jiang Biao
2020-09-15 9:28 ` Vincent Guittot
2020-09-15 11:36 ` Jiang Biao
2020-09-15 12:42 ` Vincent Guittot
2020-09-16 1:14 ` Jiang Biao
2020-09-15 19:04 ` Valentin Schneider
2020-09-16 7:02 ` Vincent Guittot
2020-09-16 8:34 ` Valentin Schneider
2020-09-14 11:42 ` [PATCH 0/4] sched/fair: Improve fairness between cfs tasks peterz
2020-09-14 12:53 ` Phil Auld
2020-09-14 16:03 ` Vincent Guittot
2020-09-14 15:50 ` Mel Gorman
2020-09-14 16:04 ` Vincent Guittot
2020-09-18 16:39 ` Phil Auld
2020-09-18 17:27 ` Phil Auld [this message]
2020-09-15 19:05 ` Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200918172745.GI55398@lorien.usersys.redhat.com \
--to=pauld@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=jhladky@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.