All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, Rik van Riel <riel@surriel.com>
Subject: sched: rq->nr_iowait transiently going negative after the recent p->on_cpu optimization
Date: Fri, 18 Sep 2020 13:27:59 -0400	[thread overview]
Message-ID: <20200918172759.GA4247@mtj.thefacebook.com> (raw)

Hello,

Peter, I noticed /proc/stat::procs_blocked going U64_MAX transiently once in
the blue moon without any other persistent issues. After looking at the code
with Rik for a bit, the culprit seems to be c6e7bd7afaeb ("sched/core:
Optimize ttwu() spinning on p->on_cpu") - it changed where ttwu dec's
nr_iowait and it looks like that can happen before the target task gets to
inc.

Thanks.

-- 
tejun

             reply	other threads:[~2020-09-18 17:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-18 17:27 Tejun Heo [this message]
2020-09-24 11:50 ` sched: rq->nr_iowait transiently going negative after the recent p->on_cpu optimization Peter Zijlstra
2020-09-24 14:27   ` Tejun Heo
2020-09-24 14:50     ` Peter Zijlstra
2020-09-24 14:57       ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200918172759.GA4247@mtj.thefacebook.com \
    --to=tj@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=riel@surriel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.