From: Rob Herring <robh@kernel.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Stephen Boyd <swboyd@chromium.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Peter Chen <peter.chen@nxp.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, Alan Stern <stern@rowland.harvard.edu>,
linux-kernel@vger.kernel.org,
Ravi Chandra Sadineni <ravisadineni@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
devicetree@vger.kernel.org, Bastien Nocera <hadess@hadess.net>
Subject: Re: [PATCH v2 1/2] dt-bindings: usb: Add binding for onboard USB hubs
Date: Fri, 18 Sep 2020 11:30:31 -0600 [thread overview]
Message-ID: <20200918173031.GA3828850@bogus> (raw)
In-Reply-To: <20200917114600.v2.1.I248292623d3d0f6a4f0c5bc58478ca3c0062b49a@changeid>
On Thu, 17 Sep 2020 11:46:21 -0700, Matthias Kaehlcke wrote:
> Onboard USB hubs need to be powered and may require initiaization of
> other resources (like GPIOs or clocks) to work properly. This adds
> a device tree binding for these hubs.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
>
> Changes in v2:
> - removed 'wakeup-source' and 'power-off-in-suspend' properties
> - consistently use spaces for indentation in example
>
> .../bindings/usb/onboard_usb_hub.yaml | 56 +++++++++++++++++++
> 1 file changed, 56 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/onboard_usb_hub.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
Error: Documentation/devicetree/bindings/usb/onboard_usb_hub.example.dts:24.9-20 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:342: Documentation/devicetree/bindings/usb/onboard_usb_hub.example.dt.yaml] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1366: dt_binding_check] Error 2
See https://patchwork.ozlabs.org/patch/1366361
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
Please check and re-submit.
prev parent reply other threads:[~2020-09-18 17:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 18:46 [PATCH v2 1/2] dt-bindings: usb: Add binding for onboard USB hubs Matthias Kaehlcke
2020-09-17 18:46 ` [PATCH v2 2/2] USB: misc: Add onboard_usb_hub driver Matthias Kaehlcke
2020-09-17 19:54 ` Alan Stern
2020-09-22 0:41 ` Matthias Kaehlcke
2020-09-22 1:08 ` Alan Stern
2020-09-22 1:25 ` Matthias Kaehlcke
2020-09-18 1:30 ` Peter Chen
2020-09-22 0:57 ` Matthias Kaehlcke
2020-09-20 14:17 ` Greg Kroah-Hartman
2020-09-22 1:18 ` Matthias Kaehlcke
2020-09-23 22:25 ` Matthias Kaehlcke
2020-09-24 6:36 ` Greg Kroah-Hartman
2020-09-18 17:30 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200918173031.GA3828850@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mka@chromium.org \
--cc=peter.chen@nxp.com \
--cc=ravisadineni@chromium.org \
--cc=robh+dt@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.