Re: [PATCH] iio:accel:bma180: Fix use of true when should be iio_shared_by enum

[Jonathan Cameron <jic23@kernel.org>]

On Fri, 18 Sep 2020 15:36:58 +0200
Lars-Peter Clausen <lars@metafoo.de> wrote:

> On 9/13/20 2:12 PM, Jonathan Cameron wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > Given a value of 1 corresponds to IIO_SHARE_BY_TYPE I have replaced
> > it with that.  Should cause no functional change.
> >
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Oleksandr Kravchenko <o.v.kravchenko@globallogic.com>
> > Cc: Peter Meerwald <pmeerw@pmeerw.net>
> > Cc: Jonathan Bakker <xc-racer2@live.ca>  
> 
> Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks. Applied to the togreg branch of iio.git.
I haven't marked it for stable because it has not material affect.
Not a problem if it gets picked up anyway of course!

Thanks,

Jonathan

> 
> 
> > ---
> >   drivers/iio/accel/bma180.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c
> > index 448faed001fd..6b74c2b04c15 100644
> > --- a/drivers/iio/accel/bma180.c
> > +++ b/drivers/iio/accel/bma180.c
> > @@ -673,7 +673,7 @@ static const struct iio_chan_spec_ext_info bma023_ext_info[] = {
> >   };
> >   
> >   static const struct iio_chan_spec_ext_info bma180_ext_info[] = {
> > -	IIO_ENUM("power_mode", true, &bma180_power_mode_enum),
> > +	IIO_ENUM("power_mode", IIO_SHARED_BY_TYPE, &bma180_power_mode_enum),
> >   	IIO_ENUM_AVAILABLE("power_mode", &bma180_power_mode_enum),
> >   	IIO_MOUNT_MATRIX(IIO_SHARED_BY_DIR, bma180_accel_get_mount_matrix),
> >   	{ }  
> 
>