From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2, 1/1] package/supertux: fix build with RELRO
Date: Sat, 19 Sep 2020 21:15:51 +0200 [thread overview]
Message-ID: <20200919211551.5f044a74@windsurf> (raw)
In-Reply-To: <20200914203329.3432074-1-fontaine.fabrice@gmail.com>
On Mon, 14 Sep 2020 22:33:29 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Disable static building of external/squirrel to fix the following build
> failure with RELRO:
>
> /home/peko/autobuild/instance-0/output-1/host/opt/ext-toolchain/bin/../lib/gcc/x86_64-buildroot-linux-musl/8.3.0/../../../../x86_64-buildroot-linux-musl/bin/ld: CMakeFiles/sq_static.dir/sq.c.o: relocation R_X86_64_32 against `.rodata.str1.8' can not be used when making a PIE object; recompile with -fPIC
> /home/peko/autobuild/instance-0/output-1/host/opt/ext-toolchain/bin/../lib/gcc/x86_64-buildroot-linux-musl/8.3.0/../../../../x86_64-buildroot-linux-musl/bin/ld: final link failed: nonrepresentable section on output
> collect2: error: ld returned 1 exit status
>
> Fixes:
> - http://autobuild.buildroot.org/results/46e8f5e622ce450a89bc6d70f4bfd38182557901
> - http://autobuild.buildroot.org/results/a43720492d817e4555d728546da9114e3ccba952
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2 (after review of Thomas Petazzoni):
> - Disable static building of external/squirrel instead of adding -fPIC
Applied to master, thanks. Could you discuss this with upstream? I'm
not sure they will accept the patch as-is, but perhaps they will
suggest some more elaborate solution ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-09-19 19:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 20:33 [Buildroot] [PATCH v2,1/1] package/supertux: fix build with RELRO Fabrice Fontaine
2020-09-19 19:15 ` Thomas Petazzoni [this message]
2020-09-29 13:45 ` [Buildroot] [PATCH v2, 1/1] " Peter Korsgaard
2020-10-03 19:40 ` Romain Naour
2020-10-03 19:52 ` Fabrice Fontaine
2020-10-03 20:02 ` Romain Naour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200919211551.5f044a74@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.