From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/qt5/qt5location: needs qt5declarative quick package
Date: Sat, 19 Sep 2020 22:08:20 +0200 [thread overview]
Message-ID: <20200919220820.2d5d47ab@windsurf> (raw)
In-Reply-To: <20200919194857.491282-1-b.bilas@grinn-global.com>
On Sat, 19 Sep 2020 21:48:57 +0200
Bartosz Bilas <b.bilas@grinn-global.com> wrote:
> Simply add the dependency of qt5declarative quick module that
> forces Qt OpenGL support which is needed for qt5location component [1].
>
> Fixes:
> http://autobuild.buildroot.net/results/ddd/ddda7cdb9400f6ca7d548e9b5ada18674fbe42e0/
> http://autobuild.buildroot.net/results/ddb/ddb25ebb591ed6029a7bd4934464171358553936/
>
> and many many more...
>
> [1] https://code.woboq.org/qt5/qtdeclarative/src/quick/scenegraph/coreapi/qsgmaterialshader.h.html#105
>
> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
> ---
> package/qt5/qt5location/Config.in | 4 ++++
> package/qt5/qt5location/qt5location.mk | 5 +----
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/package/qt5/qt5location/Config.in b/package/qt5/qt5location/Config.in
> index c68deb1006..207ad5a37a 100644
> --- a/package/qt5/qt5location/Config.in
> +++ b/package/qt5/qt5location/Config.in
> @@ -1,5 +1,6 @@
> config BR2_PACKAGE_QT5LOCATION
> bool "qt5location"
> + depends on BR2_PACKAGE_QT5DECLARATIVE_QUICK
This looks a bit weird, because src/src.pro looks like this:
SUBDIRS += positioning
positioning.depends = clip2tri
qtHaveModule(quick) {
SUBDIRS += positioningquick location
positioningquick.depends += positioning
location.depends += positioningquick clip2tri
plugins.depends += location
SUBDIRS += imports
imports.depends += positioningquick positioning location
}
So, the "location" subdirectory should not be built of the quick module
is not there.
Could you try to see what's going on ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-09-19 20:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-19 19:48 [Buildroot] [PATCH] package/qt5/qt5location: needs qt5declarative quick package Bartosz Bilas
2020-09-19 20:08 ` Thomas Petazzoni [this message]
2020-09-19 20:34 ` Bartosz Bilas
2020-09-19 21:05 ` Bartosz Bilas
2020-09-20 15:41 ` Peter Seiderer
2020-09-20 18:40 ` Bartosz Bilas
2020-09-22 20:19 ` Thomas Petazzoni
2020-09-23 14:39 ` Bartosz Bilas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200919220820.2d5d47ab@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.