From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4A0CC433DB for ; Sun, 20 Sep 2020 00:33:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 580532078D for ; Sun, 20 Sep 2020 00:33:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="U0PbB7jZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 580532078D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=g01mhGQQgEstZrgMmi3qAPfqBHeg2r40w/XvaBQ5dG4=; b=U0PbB7jZpg/MnXJvoKUPG/j3q BwUwi2SNPpAwz3y6LcgO631mGXdpiopLkKh+/ThPUX1rsk8w3BAGra1n9QrdNAacktVXF3Bn+4EVZ 2UsSAptsKswMTAMi+lYruXusYDtosASgY/kfEV6nD98GPOATJl0CcRht72c94yRGZiOcx2nuXl/v9 OBPTjeZUDpvMmirGxbPhQttJ+8OoG0loY8zKg0XeQJMmmfQnhGNudVowB8NIyJrJWhwMue+Unf6lV v4FAMAHlEaOeCPKN3YUcHqfaz+e0Yg3AkXpT5eMcfJlKzUH3ijJLubcU5x4ZGGzB9YYy7MklpaeFf iMemPKLmA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJnGg-0002aa-Q7; Sun, 20 Sep 2020 00:31:50 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJnGe-0002a1-5q for linux-mtd@lists.infradead.org; Sun, 20 Sep 2020 00:31:48 +0000 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kJnGK-00FR5b-RV; Sun, 20 Sep 2020 02:31:28 +0200 Date: Sun, 20 Sep 2020 02:31:28 +0200 From: Andrew Lunn To: Ansuel Smith Subject: Re: [PATCH v2 4/4] dt-bindings: net: Document use of mac-address-increment Message-ID: <20200920003128.GC3673389@lunn.ch> References: <20200919223026.20803-1-ansuelsmth@gmail.com> <20200919223026.20803-5-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200919223026.20803-5-ansuelsmth@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200919_203148_225522_DE2FB13E X-CRM114-Status: GOOD ( 15.21 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Vignesh Raghavendra , Boris Brezillon , Richard Weinberger , Russell King , linux-kernel@vger.kernel.org, Rob Herring , linux-mtd@lists.infradead.org, Miquel Raynal , Jakub Kicinski , netdev@vger.kernel.org, Frank Rowand , "David S. Miller" , Heiner Kallweit Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org > + mac-address-increment: > + description: > + The MAC address can optionally be increased (or decreased using > + negative values) from the original value readed (from a nvmem cell Read is irregular, there is no readed, just read. > + for example). This can be used if the mac is readed from a dedicated > + partition and must be increased based on the number of device > + present in the system. You should probably add there is no underflow/overflow to other bytes of the MAC address. 00:01:02:03:04:ff + 1 == 00:01:02:03:04:00. > + minimum: -255 > + maximum: 255 > + > + mac-address-increment-byte: > + description: > + If 'mac-address-increment' is defined, this will tell what byte of > + the mac-address will be increased. If 'mac-address-increment' is > + not defined, this option will do nothing. > + default: 5 > + minimum: 0 > + maximum: 5 Is there a real need for this? A value of 0 seems like a bad idea, since a unicast address could easily become a multicast address, which is not valid for an interface address. It also does not seem like a good idea to allow the OUI to be changed. So i think only bytes 3-5 should be allowed, but even then, i don't think this is needed, unless you do have a clear use case. Andrew ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A3BAC43463 for ; Sun, 20 Sep 2020 01:13:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 50A74208B8 for ; Sun, 20 Sep 2020 01:13:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726772AbgITBNB (ORCPT ); Sat, 19 Sep 2020 21:13:01 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:45668 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726707AbgITBNB (ORCPT ); Sat, 19 Sep 2020 21:13:01 -0400 X-Greylist: delayed 2474 seconds by postgrey-1.27 at vger.kernel.org; Sat, 19 Sep 2020 21:13:00 EDT Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kJnGK-00FR5b-RV; Sun, 20 Sep 2020 02:31:28 +0200 Date: Sun, 20 Sep 2020 02:31:28 +0200 From: Andrew Lunn To: Ansuel Smith Cc: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Rob Herring , "David S. Miller" , Jakub Kicinski , Heiner Kallweit , Russell King , Frank Rowand , Boris Brezillon , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2 4/4] dt-bindings: net: Document use of mac-address-increment Message-ID: <20200920003128.GC3673389@lunn.ch> References: <20200919223026.20803-1-ansuelsmth@gmail.com> <20200919223026.20803-5-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200919223026.20803-5-ansuelsmth@gmail.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org > + mac-address-increment: > + description: > + The MAC address can optionally be increased (or decreased using > + negative values) from the original value readed (from a nvmem cell Read is irregular, there is no readed, just read. > + for example). This can be used if the mac is readed from a dedicated > + partition and must be increased based on the number of device > + present in the system. You should probably add there is no underflow/overflow to other bytes of the MAC address. 00:01:02:03:04:ff + 1 == 00:01:02:03:04:00. > + minimum: -255 > + maximum: 255 > + > + mac-address-increment-byte: > + description: > + If 'mac-address-increment' is defined, this will tell what byte of > + the mac-address will be increased. If 'mac-address-increment' is > + not defined, this option will do nothing. > + default: 5 > + minimum: 0 > + maximum: 5 Is there a real need for this? A value of 0 seems like a bad idea, since a unicast address could easily become a multicast address, which is not valid for an interface address. It also does not seem like a good idea to allow the OUI to be changed. So i think only bytes 3-5 should be allowed, but even then, i don't think this is needed, unless you do have a clear use case. Andrew