All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
	Yishai Hadas <yishaih@nvidia.com>, <linux-rdma@vger.kernel.org>,
	Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH rdma-next v1 1/4] IB/core: Improve ODP to use hmm_range_fault()
Date: Mon, 21 Sep 2020 11:23:39 -0300	[thread overview]
Message-ID: <20200921142339.GT3699@nvidia.com> (raw)
In-Reply-To: <20200917112152.1075974-2-leon@kernel.org>

On Thu, Sep 17, 2020 at 02:21:49PM +0300, Leon Romanovsky wrote:

> -out:
> -	put_page(page);
> -	return ret;
> +	*dma_addr &= ODP_DMA_ADDR_MASK;

I thought we agreed to get rid of this because it must be zero?

Jason

  reply	other threads:[~2020-09-21 14:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-17 11:21 [PATCH rdma-next v1 0/4] Improve ODP by using HMM API Leon Romanovsky
2020-09-17 11:21 ` [PATCH rdma-next v1 1/4] IB/core: Improve ODP to use hmm_range_fault() Leon Romanovsky
2020-09-21 14:23   ` Jason Gunthorpe [this message]
2020-09-21 15:17     ` Yishai Hadas
2020-09-21 15:26       ` Jason Gunthorpe
2020-09-21 17:23         ` Yishai Hadas
2020-09-17 11:21 ` [PATCH rdma-next v1 2/4] IB/core: Enable ODP sync without faulting Leon Romanovsky
2020-09-17 11:21 ` [PATCH rdma-next v1 3/4] RDMA/mlx5: Extend advice MR to support non faulting mode Leon Romanovsky
2020-09-17 11:21 ` [PATCH rdma-next v1 4/4] RDMA/mlx5: Sync device with CPU pages upon ODP MR registration Leon Romanovsky
2020-09-21 14:25   ` Jason Gunthorpe
2020-09-21 17:04     ` Yishai Hadas
2020-09-21 17:08       ` Jason Gunthorpe
2020-09-21 17:26         ` Yishai Hadas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200921142339.GT3699@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=dledford@redhat.com \
    --cc=hch@infradead.org \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=yishaih@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.