All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Aswath Govindraju <a-govindraju@ti.com>
Cc: Sekhar Nori <nsekhar@ti.com>, Vignesh R <vigneshr@ti.com>,
	linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "spi: omap2-mcspi: Switch to readl_poll_timeout()"
Date: Mon, 21 Sep 2020 20:00:25 +0100	[thread overview]
Message-ID: <20200921190025.GI4792@sirena.org.uk> (raw)
In-Reply-To: <20200921185638.GH4792@sirena.org.uk>

[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]

On Mon, Sep 21, 2020 at 07:56:38PM +0100, Mark Brown wrote:
> On Thu, Sep 10, 2020 at 05:56:24PM +0530, Aswath Govindraju wrote:
> > This reverts commit 13d515c796adc49a49b0cd2212ccd7f43a37fc5a.
> > 
> > The amount of time spent polling for the MCSPI_CHSTAT bits to be set on
> > AM335x-icev2 platform is less than 1us (about 0.6us) in most cases, with
> 
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.

Oh, and also:

Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2020-09-21 19:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10 12:26 [PATCH] Revert "spi: omap2-mcspi: Switch to readl_poll_timeout()" Aswath Govindraju
2020-09-21 18:56 ` Mark Brown
2020-09-21 19:00   ` Mark Brown [this message]
2020-09-22  0:06 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200921190025.GI4792@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=a-govindraju@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=nsekhar@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.