From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 120D3C4346E for ; Tue, 22 Sep 2020 03:03:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C230123A1B for ; Tue, 22 Sep 2020 03:03:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726593AbgIVDDC (ORCPT ); Mon, 21 Sep 2020 23:03:02 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:36552 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726395AbgIVDDC (ORCPT ); Mon, 21 Sep 2020 23:03:02 -0400 Received: by mail-lf1-f68.google.com with SMTP id x69so16363822lff.3 for ; Mon, 21 Sep 2020 20:03:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Sv86L4tTF46gtQtrszbDEkK4c/C/syy/IBF1mCGf558=; b=U6rb7/FJwYaVYJxwoclYr+mMXkKFSGUuD8ggtBqLZb/SytFZ3kTyov4nNcPi0IGr42 ASmWo/rnlUq1awvx9ae6HzWtaV8zwie9nRnZhIDBzyX5fbBVRPSzm1UmJbxslPWCAFxq aKsvNBtGUtsU9sE4r3eqmFZNirT2eM9DZZIQBtU4n8ERzg2QjvoSaAN8ZxBQWJtRJ9Za 3ZGTjPAM5oXUEv8ppbNnvgBicsJ4LkbkGr+dfHLUaEX+UO3REfzybJNljQ/5eQE+h5Bs zFKtab4QYA0NpGBScY8C48mms7OjQzGugXJYrD60O/GhaHhpAtJfIVn3UfSMHXgNDlmu xy6A== X-Gm-Message-State: AOAM532uw5jSUTiC92+J9BHVgNNgp+hfm5d3Rh0Kmq/zk+Fe+VD1p5ES PeB0dP6oW22fv85AuJPEN/3wGW2cWvSUqZBp X-Google-Smtp-Source: ABdhPJwGDbRO+HsTtwpB0nXT2IF+OzNsAkcIv2Irj6ntf+GN/JSlMlShMDRaXFbIJomByo4sL8ekrQ== X-Received: by 2002:ac2:4250:: with SMTP id m16mr843681lfl.565.1600743779766; Mon, 21 Sep 2020 20:02:59 -0700 (PDT) Received: from workstation.lan ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id u17sm3020878lfl.283.2020.09.21.20.02.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2020 20:02:59 -0700 (PDT) From: =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= To: Toan Le Cc: Duc Dang , Bjorn Helgaas , Lorenzo Pieralisi , Rob Herring , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] PCI: xgene: Remove unused assignment to variable msi_val Date: Tue, 22 Sep 2020 03:02:57 +0000 Message-Id: <20200922030257.459898-1-kw@linux.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org The value assigned to msi_val after the inner loop finishes its run is never used for anything, and it is also immediately overridden in the line that follows with the return value from the xgene_msi_int_read() function. Since the value of msi_val following the inner loop completion is never used in any meaningful way the assignment can be removed. Addresses-Coverity-ID: 1437183 ("Unused value") Signed-off-by: Krzysztof Wilczyński --- drivers/pci/controller/pci-xgene-msi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/pci-xgene-msi.c b/drivers/pci/controller/pci-xgene-msi.c index 02271c6d17a1..2470782cb01a 100644 --- a/drivers/pci/controller/pci-xgene-msi.c +++ b/drivers/pci/controller/pci-xgene-msi.c @@ -493,8 +493,8 @@ static int xgene_msi_probe(struct platform_device *pdev) */ for (irq_index = 0; irq_index < NR_HW_IRQS; irq_index++) { for (msi_idx = 0; msi_idx < IDX_PER_GROUP; msi_idx++) - msi_val = xgene_msi_ir_read(xgene_msi, irq_index, - msi_idx); + xgene_msi_ir_read(xgene_msi, irq_index, msi_idx); + /* Read MSIINTn to confirm */ msi_val = xgene_msi_int_read(xgene_msi, irq_index); if (msi_val) { -- 2.28.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C5B5C4346E for ; Tue, 22 Sep 2020 03:04:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C1D8239D4 for ; Tue, 22 Sep 2020 03:04:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Hpt9i/uR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C1D8239D4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=1KBYIVksWAs7fJA1xhvOWHCjWE2Xc5QsLxiqxJk4MZw=; b=Hpt9i/uR9zy7i3rp/kAR3mkUSQ mXJoAZzxOxLctIvtMLmUH23t8EZGhJdNJAGBinpU6c2ENucw4+iSOm8rttcmLgKjE9mcD2Dppd57w gfu5NLO9+/YzJ7STqTKpb9niWHoEhH5Kxo2hom91a4ih0qCsjHjbqRWJml0/wl8H0wDSKPkx4Wt/C yL1cN1hjX4C/ytE6co3A8OdQEq8nahBnn1GaXDHH2AYV4MJwkYhHB7PyTISzt5e/JmdMprjkuickI MfML553P/QDcsCQH+YUy2xZomFtFDsG9g1DiOi1zWO9844LeELJ7tSsL9IpbPe7ZUEIVAeaw+7p3y PjQMJc7Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKYa8-0005d6-Qj; Tue, 22 Sep 2020 03:03:04 +0000 Received: from mail-lf1-f65.google.com ([209.85.167.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKYa6-0005cW-SM for linux-arm-kernel@lists.infradead.org; Tue, 22 Sep 2020 03:03:03 +0000 Received: by mail-lf1-f65.google.com with SMTP id q8so16352308lfb.6 for ; Mon, 21 Sep 2020 20:03:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Sv86L4tTF46gtQtrszbDEkK4c/C/syy/IBF1mCGf558=; b=c5FuzWYbL/qg9DvkXn2yPidb5daIBrB9xT4z5qcTMfnPtWttEBmBWbttAt3FEwlHrO B0d6C+8dD6JJlywS3plYJow24511KKw0N3zG7fJhrcvLa3SGkIBTJC+WgKjgvinJnTPr Ni9m8e58vv/IAH3MTVXUeuQ7QKvps6Sppvo30FqO5OqoNrb42Lg5qxuAHjMaUvC5v+89 XisvKZtf05wBY/IiD3qliFer5ZSrcNo7bE/JTuMjmojGDxbr/xhOmur3eufsKOLh6vka JkOsJBwThmpEkPRA19S/0M8/3BIdu2Nucr13SlJEzRlN7i8j6MMXHgokwqn8HDMH276a 36nw== X-Gm-Message-State: AOAM532xyE6EzeLxzg2GA9kt8jT7M0qrHkhjzOSJrnmfmbERqUu4O+z2 rZG1IqeOiSXX4c4eP2hBzSI= X-Google-Smtp-Source: ABdhPJwGDbRO+HsTtwpB0nXT2IF+OzNsAkcIv2Irj6ntf+GN/JSlMlShMDRaXFbIJomByo4sL8ekrQ== X-Received: by 2002:ac2:4250:: with SMTP id m16mr843681lfl.565.1600743779766; Mon, 21 Sep 2020 20:02:59 -0700 (PDT) Received: from workstation.lan ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id u17sm3020878lfl.283.2020.09.21.20.02.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2020 20:02:59 -0700 (PDT) From: =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= To: Toan Le Subject: [PATCH] PCI: xgene: Remove unused assignment to variable msi_val Date: Tue, 22 Sep 2020 03:02:57 +0000 Message-Id: <20200922030257.459898-1-kw@linux.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200921_230302_927945_FC889987 X-CRM114-Status: GOOD ( 15.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Lorenzo Pieralisi , linux-pci@vger.kernel.org, Duc Dang , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org VGhlIHZhbHVlIGFzc2lnbmVkIHRvIG1zaV92YWwgYWZ0ZXIgdGhlIGlubmVyIGxvb3AgZmluaXNo ZXMgaXRzIHJ1biBpcwpuZXZlciB1c2VkIGZvciBhbnl0aGluZywgYW5kIGl0IGlzIGFsc28gaW1t ZWRpYXRlbHkgb3ZlcnJpZGRlbiBpbiB0aGUKbGluZSB0aGF0IGZvbGxvd3Mgd2l0aCB0aGUgcmV0 dXJuIHZhbHVlIGZyb20gdGhlIHhnZW5lX21zaV9pbnRfcmVhZCgpCmZ1bmN0aW9uLgoKU2luY2Ug dGhlIHZhbHVlIG9mIG1zaV92YWwgZm9sbG93aW5nIHRoZSBpbm5lciBsb29wIGNvbXBsZXRpb24g aXMgbmV2ZXIKdXNlZCBpbiBhbnkgbWVhbmluZ2Z1bCB3YXkgdGhlIGFzc2lnbm1lbnQgY2FuIGJl IHJlbW92ZWQuCgpBZGRyZXNzZXMtQ292ZXJpdHktSUQ6IDE0MzcxODMgKCJVbnVzZWQgdmFsdWUi KQpTaWduZWQtb2ZmLWJ5OiBLcnp5c3p0b2YgV2lsY3p5xYRza2kgPGt3QGxpbnV4LmNvbT4KLS0t CiBkcml2ZXJzL3BjaS9jb250cm9sbGVyL3BjaS14Z2VuZS1tc2kuYyB8IDQgKystLQogMSBmaWxl IGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9k cml2ZXJzL3BjaS9jb250cm9sbGVyL3BjaS14Z2VuZS1tc2kuYyBiL2RyaXZlcnMvcGNpL2NvbnRy b2xsZXIvcGNpLXhnZW5lLW1zaS5jCmluZGV4IDAyMjcxYzZkMTdhMS4uMjQ3MDc4MmNiMDFhIDEw MDY0NAotLS0gYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL3BjaS14Z2VuZS1tc2kuYworKysgYi9k cml2ZXJzL3BjaS9jb250cm9sbGVyL3BjaS14Z2VuZS1tc2kuYwpAQCAtNDkzLDggKzQ5Myw4IEBA IHN0YXRpYyBpbnQgeGdlbmVfbXNpX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYp CiAJICovCiAJZm9yIChpcnFfaW5kZXggPSAwOyBpcnFfaW5kZXggPCBOUl9IV19JUlFTOyBpcnFf aW5kZXgrKykgewogCQlmb3IgKG1zaV9pZHggPSAwOyBtc2lfaWR4IDwgSURYX1BFUl9HUk9VUDsg bXNpX2lkeCsrKQotCQkJbXNpX3ZhbCA9IHhnZW5lX21zaV9pcl9yZWFkKHhnZW5lX21zaSwgaXJx X2luZGV4LAotCQkJCQkJICAgIG1zaV9pZHgpOworCQkJeGdlbmVfbXNpX2lyX3JlYWQoeGdlbmVf bXNpLCBpcnFfaW5kZXgsIG1zaV9pZHgpOworCiAJCS8qIFJlYWQgTVNJSU5UbiB0byBjb25maXJt ICovCiAJCW1zaV92YWwgPSB4Z2VuZV9tc2lfaW50X3JlYWQoeGdlbmVfbXNpLCBpcnFfaW5kZXgp OwogCQlpZiAobXNpX3ZhbCkgewotLSAKMi4yOC4wCgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=