From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ABC9C4363D for ; Tue, 22 Sep 2020 05:32:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C090823A9B for ; Tue, 22 Sep 2020 05:31:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728880AbgIVFb6 (ORCPT ); Tue, 22 Sep 2020 01:31:58 -0400 Received: from wtarreau.pck.nerim.net ([62.212.114.60]:42062 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728422AbgIVFb6 (ORCPT ); Tue, 22 Sep 2020 01:31:58 -0400 X-Greylist: delayed 566 seconds by postgrey-1.27 at vger.kernel.org; Tue, 22 Sep 2020 01:31:57 EDT Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 08M5Vsvu016420; Tue, 22 Sep 2020 07:31:54 +0200 Date: Tue, 22 Sep 2020 07:31:54 +0200 From: Willy Tarreau To: poeschel@lemonage.de Cc: Miguel Ojeda Sandonis , Ksenija Stanojevic , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 00/33] Make charlcd device independent Message-ID: <20200922053154.GC16386@1wt.eu> References: <20191016082430.5955-1-poeschel@lemonage.de> <20200921144645.2061313-1-poeschel@lemonage.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200921144645.2061313-1-poeschel@lemonage.de> User-Agent: Mutt/1.6.1 (2016-04-27) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lars, On Mon, Sep 21, 2020 at 04:46:12PM +0200, poeschel@lemonage.de wrote: > This tries to make charlcd device independent. At the moment hd44780 > device specific code is contained deep in charlcd. This moves this out > into a hd44780_common module, where the two hd44780 drivers we have at > the moment (hd44780 and panel) can use this from. The goal is that at > the end other drivers can use the charlcd interface. > I add one such driver at the end with the last patch. > I submitted this already some time ago [1], where the wish was so split > this into smaller chunks what I try to do with this new patchset. > Most of the patches pick one specific function in charlcd and move the > device specific code into hd44780_common. Regardless of my two comments, this series looks very clean to me, nice job! For 1..32, feel free to add: Reviewed-by: Willy Tarreau Just be careful in your commit messages, I spotted a few "it's own" instead of "its own", but that's a very minor detail :-) Willy