From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0236C2D0E2 for ; Tue, 22 Sep 2020 07:41:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8DCE12396D for ; Tue, 22 Sep 2020 07:41:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="X/YeUFTG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729956AbgIVHlD (ORCPT ); Tue, 22 Sep 2020 03:41:03 -0400 Received: from z5.mailgun.us ([104.130.96.5]:61569 "EHLO z5.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729751AbgIVHlD (ORCPT ); Tue, 22 Sep 2020 03:41:03 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1600760463; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=PCb/LQTImmNI5pGV+nkyJ4op8kFr0L88xJZHuK1JUE0=; b=X/YeUFTGQf4hwAJDR0Ehp3qJ8IVPjvLw6avDGHSMTrdAoM173/n6j6mHvWwYq2iJdWiXNGai Oh0ytBKQGwvUHBvV6Rz/KlmmDXIHI60yaDy3wxmv3gh8Xx2GHS0IW6OX3oPXqRjYL6wEFvAF Y04a2k5JKHC4Mhs097yk+h8FJZQ= X-Mailgun-Sending-Ip: 104.130.96.5 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-west-2.postgun.com with SMTP id 5f69aa68aac060135420b0bc (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 22 Sep 2020 07:40:24 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 2650DC433CB; Tue, 22 Sep 2020 07:40:24 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1D6C9C433CA; Tue, 22 Sep 2020 07:40:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1D6C9C433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v5 1/2] wcn36xx: Mark internal smd functions static From: Kalle Valo In-Reply-To: <20200910150845.2179320-2-bryan.odonoghue@linaro.org> References: <20200910150845.2179320-2-bryan.odonoghue@linaro.org> To: Bryan O'Donoghue Cc: wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, bryan.odonoghue@linaro.org, shawn.guo@linaro.org, loic.poulain@linaro.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200922074024.2650DC433CB@smtp.codeaurora.org> Date: Tue, 22 Sep 2020 07:40:24 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Bryan O'Donoghue wrote: > This commit marks all smd.c functions that are only used inside of smd.c as > static. Previous commits added some VHT specific setup functions non-static > which is the right thing to do in terms of having granular git commits that > compile warning free. What we really want is for local not global scope on > those functions. > > This patch makes the conversion from global to local scope. > > Signed-off-by: Bryan O'Donoghue > Signed-off-by: Kalle Valo 2 patches applied to ath-next branch of ath.git, thanks. 7f885b0bdf6f wcn36xx: Mark internal smd functions static 214091517f0c wcn36xx: Ensure spaces between functions -- https://patchwork.kernel.org/patch/11768913/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches