From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA55EC4363D for ; Tue, 22 Sep 2020 14:52:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A19DC239A1 for ; Tue, 22 Sep 2020 14:52:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600786368; bh=oqJeLFsA6VsNxyqMrg6nNJlpMSU2AWfAIp9i6bNafpA=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=EGE6t4Q0P4aah2Fajn4NEd/C4dhNFWpURE6rTW6SOf3zpPFWY9lSKHc74DZ7MwZ2a HcVxslLmM4byRxxUcSL5cyNydVePlHxOVYBOgdXYlBbnrNO/5WHNE+MPaUO9fhHhV9 W0V/5DKGMXNKR6/2ibpuRAI2FZ0cvKoGKiAGumJc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726657AbgIVOws (ORCPT ); Tue, 22 Sep 2020 10:52:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:41334 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726640AbgIVOwr (ORCPT ); Tue, 22 Sep 2020 10:52:47 -0400 Received: from localhost (52.sub-72-107-123.myvzw.com [72.107.123.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 18B002395C; Tue, 22 Sep 2020 14:52:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600786367; bh=oqJeLFsA6VsNxyqMrg6nNJlpMSU2AWfAIp9i6bNafpA=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=N4JKeq8sTKtFA4NfW8agyf+pbMR85ieGitbD8s7LDVCEVOynsA1OME5d0aRMinOcK 1fZBZlnngIr0Tot3lID84mPI1YmL4Wzn9UV8jIVE4mVHkZXDWGwfaWcB2jAZdI4ciJ 7ChtGwGRwRNfJKTMXlnwmPRYS2dgfZDD2vBdCpXA= Date: Tue, 22 Sep 2020 09:52:45 -0500 From: Bjorn Helgaas To: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= Cc: Toan Le , Rob Herring , Lorenzo Pieralisi , linux-pci@vger.kernel.org, Duc Dang , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] PCI: xgene: Remove unused assignment to variable msi_val Message-ID: <20200922145245.GA2201556@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200922030257.459898-1-kw@linux.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, Sep 22, 2020 at 03:02:57AM +0000, Krzysztof Wilczyński wrote: > The value assigned to msi_val after the inner loop finishes its run is > never used for anything, and it is also immediately overridden in the > line that follows with the return value from the xgene_msi_int_read() > function. > > Since the value of msi_val following the inner loop completion is never > used in any meaningful way the assignment can be removed. > > Addresses-Coverity-ID: 1437183 ("Unused value") > Signed-off-by: Krzysztof Wilczyński > --- > drivers/pci/controller/pci-xgene-msi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/controller/pci-xgene-msi.c b/drivers/pci/controller/pci-xgene-msi.c > index 02271c6d17a1..2470782cb01a 100644 > --- a/drivers/pci/controller/pci-xgene-msi.c > +++ b/drivers/pci/controller/pci-xgene-msi.c > @@ -493,8 +493,8 @@ static int xgene_msi_probe(struct platform_device *pdev) > */ > for (irq_index = 0; irq_index < NR_HW_IRQS; irq_index++) { > for (msi_idx = 0; msi_idx < IDX_PER_GROUP; msi_idx++) > - msi_val = xgene_msi_ir_read(xgene_msi, irq_index, > - msi_idx); > + xgene_msi_ir_read(xgene_msi, irq_index, msi_idx); > + Interesting. One might expect that throwing away the result of a read means the read itself is pointless, but fortunately there's a comment just above explaining that these registers are read-to-clear. Acked-by: Bjorn Helgaas Assuming Toan acks this, Lorenzo will likely pick it up when he returns next week. > /* Read MSIINTn to confirm */ > msi_val = xgene_msi_int_read(xgene_msi, irq_index); > if (msi_val) { > -- > 2.28.0 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8A4AC4363D for ; Tue, 22 Sep 2020 14:54:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75B4A2395C for ; Tue, 22 Sep 2020 14:54:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ra5RpoG2"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="N4JKeq8s" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75B4A2395C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID:Subject:To:From: Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References:List-Owner; bh=qZvN0Vqxvf8Q8vlgbJLvVN5cSvQ47LLaiAr/xhY+Lrk=; b=ra5RpoG2xA9ajtwD3BdPFiDsv V/pv865k9+ICjy27AgabfTq2dpghn/9jU/d49Rzn8hmwPemJCZY+vp6UWeVr4AtuSch5Ef+8OVxin AGH00yXsBl50Wo887XF3wYgl54ZCItoHmOiQaJsAS7Xp7V64sPVlJ7GlmxIN51T64DCw1JiUIB1Gz kvwWNB6BtakO2WV2Tjspaz/HQyRrZNsHRDTvSqDAxkl4Q/XeZ8nRXLHzzumBG7xFanE8Ynhh/fczz psUR4Hwk36clPj4GdxiKQn/6IoA8DG960h9xsHL5xAabEDXDYXADD5ndgDGeT59laC/vZEwoFRx7y gqV187g/A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKjf5-0000SB-3i; Tue, 22 Sep 2020 14:52:55 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKjey-0000Qs-8q for linux-arm-kernel@lists.infradead.org; Tue, 22 Sep 2020 14:52:50 +0000 Received: from localhost (52.sub-72-107-123.myvzw.com [72.107.123.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 18B002395C; Tue, 22 Sep 2020 14:52:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600786367; bh=oqJeLFsA6VsNxyqMrg6nNJlpMSU2AWfAIp9i6bNafpA=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=N4JKeq8sTKtFA4NfW8agyf+pbMR85ieGitbD8s7LDVCEVOynsA1OME5d0aRMinOcK 1fZBZlnngIr0Tot3lID84mPI1YmL4Wzn9UV8jIVE4mVHkZXDWGwfaWcB2jAZdI4ciJ 7ChtGwGRwRNfJKTMXlnwmPRYS2dgfZDD2vBdCpXA= Date: Tue, 22 Sep 2020 09:52:45 -0500 From: Bjorn Helgaas To: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= Subject: Re: [PATCH] PCI: xgene: Remove unused assignment to variable msi_val Message-ID: <20200922145245.GA2201556@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200922030257.459898-1-kw@linux.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200922_105248_521193_7DA51346 X-CRM114-Status: GOOD ( 21.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Lorenzo Pieralisi , linux-pci@vger.kernel.org, Duc Dang , Bjorn Helgaas , Toan Le , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBTZXAgMjIsIDIwMjAgYXQgMDM6MDI6NTdBTSArMDAwMCwgS3J6eXN6dG9mIFdpbGN6 ecWEc2tpIHdyb3RlOgo+IFRoZSB2YWx1ZSBhc3NpZ25lZCB0byBtc2lfdmFsIGFmdGVyIHRoZSBp bm5lciBsb29wIGZpbmlzaGVzIGl0cyBydW4gaXMKPiBuZXZlciB1c2VkIGZvciBhbnl0aGluZywg YW5kIGl0IGlzIGFsc28gaW1tZWRpYXRlbHkgb3ZlcnJpZGRlbiBpbiB0aGUKPiBsaW5lIHRoYXQg Zm9sbG93cyB3aXRoIHRoZSByZXR1cm4gdmFsdWUgZnJvbSB0aGUgeGdlbmVfbXNpX2ludF9yZWFk KCkKPiBmdW5jdGlvbi4KPiAKPiBTaW5jZSB0aGUgdmFsdWUgb2YgbXNpX3ZhbCBmb2xsb3dpbmcg dGhlIGlubmVyIGxvb3AgY29tcGxldGlvbiBpcyBuZXZlcgo+IHVzZWQgaW4gYW55IG1lYW5pbmdm dWwgd2F5IHRoZSBhc3NpZ25tZW50IGNhbiBiZSByZW1vdmVkLgo+IAo+IEFkZHJlc3Nlcy1Db3Zl cml0eS1JRDogMTQzNzE4MyAoIlVudXNlZCB2YWx1ZSIpCj4gU2lnbmVkLW9mZi1ieTogS3J6eXN6 dG9mIFdpbGN6ecWEc2tpIDxrd0BsaW51eC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvcGNpL2NvbnRy b2xsZXIvcGNpLXhnZW5lLW1zaS5jIHwgNCArKy0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2Vy dGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGNpL2Nv bnRyb2xsZXIvcGNpLXhnZW5lLW1zaS5jIGIvZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2kteGdl bmUtbXNpLmMKPiBpbmRleCAwMjI3MWM2ZDE3YTEuLjI0NzA3ODJjYjAxYSAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL3BjaS14Z2VuZS1tc2kuYwo+ICsrKyBiL2RyaXZlcnMv cGNpL2NvbnRyb2xsZXIvcGNpLXhnZW5lLW1zaS5jCj4gQEAgLTQ5Myw4ICs0OTMsOCBAQCBzdGF0 aWMgaW50IHhnZW5lX21zaV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ICAJ ICovCj4gIAlmb3IgKGlycV9pbmRleCA9IDA7IGlycV9pbmRleCA8IE5SX0hXX0lSUVM7IGlycV9p bmRleCsrKSB7Cj4gIAkJZm9yIChtc2lfaWR4ID0gMDsgbXNpX2lkeCA8IElEWF9QRVJfR1JPVVA7 IG1zaV9pZHgrKykKPiAtCQkJbXNpX3ZhbCA9IHhnZW5lX21zaV9pcl9yZWFkKHhnZW5lX21zaSwg aXJxX2luZGV4LAo+IC0JCQkJCQkgICAgbXNpX2lkeCk7Cj4gKwkJCXhnZW5lX21zaV9pcl9yZWFk KHhnZW5lX21zaSwgaXJxX2luZGV4LCBtc2lfaWR4KTsKPiArCgpJbnRlcmVzdGluZy4gIE9uZSBt aWdodCBleHBlY3QgdGhhdCB0aHJvd2luZyBhd2F5IHRoZSByZXN1bHQgb2YgYSByZWFkCm1lYW5z IHRoZSByZWFkIGl0c2VsZiBpcyBwb2ludGxlc3MsIGJ1dCBmb3J0dW5hdGVseSB0aGVyZSdzIGEg Y29tbWVudApqdXN0IGFib3ZlIGV4cGxhaW5pbmcgdGhhdCB0aGVzZSByZWdpc3RlcnMgYXJlIHJl YWQtdG8tY2xlYXIuCgpBY2tlZC1ieTogQmpvcm4gSGVsZ2FhcyA8YmhlbGdhYXNAZ29vZ2xlLmNv bT4KCkFzc3VtaW5nIFRvYW4gYWNrcyB0aGlzLCBMb3JlbnpvIHdpbGwgbGlrZWx5IHBpY2sgaXQg dXAgd2hlbiBoZQpyZXR1cm5zIG5leHQgd2Vlay4KCj4gIAkJLyogUmVhZCBNU0lJTlRuIHRvIGNv bmZpcm0gKi8KPiAgCQltc2lfdmFsID0geGdlbmVfbXNpX2ludF9yZWFkKHhnZW5lX21zaSwgaXJx X2luZGV4KTsKPiAgCQlpZiAobXNpX3ZhbCkgewo+IC0tIAo+IDIuMjguMAo+IAo+IAo+IF9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKPiBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcK PiBodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1r ZXJuZWwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LWFybS1rZXJuZWwK