From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2C60C4727C for ; Tue, 22 Sep 2020 15:41:27 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 641852395B for ; Tue, 22 Sep 2020 15:41:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Wamvkeqx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 641852395B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8A94A171E; Tue, 22 Sep 2020 17:40:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8A94A171E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1600789284; bh=KFrvDEq/8TqB+9RYqLZtje/rGaAWyDrwgCKimpJ4yQU=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=WamvkeqxTjMDfIXeKcMVc+ecanthb/Poyz7FyaeBmqePIVYa56EBwfBFWVsoOQh9g qLDxENpRhe6S1U8SHlUbwINOVGKlM8rgn4h4D/TXB/pjrP3IGxZR+S28Egv5kXYVOY i9CNDKJm6PBny5+nm1LbjR6MkLgZPRbhIF5INYz0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 19616F80229; Tue, 22 Sep 2020 17:40:34 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B1360F8010A; Tue, 22 Sep 2020 17:40:32 +0200 (CEST) Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 65DC2F8010A for ; Tue, 22 Sep 2020 17:40:22 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 65DC2F8010A Received: by mail-il1-f196.google.com with SMTP id t12so17730090ilh.3 for ; Tue, 22 Sep 2020 08:40:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8GdJRN6siN1K/3VUt/RzQ7dwFh0PUHODAfHPAkJXVec=; b=eP1YKsbdakSHPKDrOEKcLl9PbvBIOlZYau4ruiHc+2kZAXKxhLR7JYWj5omGX5X87L 0Sz6rcRD+Mwb7NR2iYl8eBjtEIygANt+M6y11OK0PBLJIwVoK8TM+S+X7STOPc1yBE43 o+jQC2ePhXCBHrM7MAuwK0aTLsjwsw6Jo8qQe9sS/6XOD+2B6bDye1i9VyY4h9kkZixH b1GmxbNQbUrjxlAJWaeWzAkYlv2G3GzqovP5qRMW3TU/vM1ZsU3/pkHxSbL0CKoPN0iQ 9tgPKEDz+vr1LjYjN3hyq11jsSbA3GIdC//FpDdGIi9sxA6NEVnDOHqkO273nBfGcSR1 c8Hg== X-Gm-Message-State: AOAM530gGao1+sT2uyum4HSt6UwrqiiCidrNby1wVEHpdCZXt1bkj6Gj 8u0D0k35rf0FkOSFI8A0iQ== X-Google-Smtp-Source: ABdhPJyREJxSIdBKii6r07HwAtgscFY+xZM0Hzr/ADdWxpwvmnoH8SQzW6oBqLEpp2gzISGF/n+Kjw== X-Received: by 2002:a92:b503:: with SMTP id f3mr4935318ile.23.1600789220548; Tue, 22 Sep 2020 08:40:20 -0700 (PDT) Received: from xps15 ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id e4sm7533543iom.14.2020.09.22.08.40.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Sep 2020 08:40:19 -0700 (PDT) Received: (nullmailer pid 2730094 invoked by uid 1000); Tue, 22 Sep 2020 15:40:18 -0000 Date: Tue, 22 Sep 2020 09:40:18 -0600 From: Rob Herring To: Krzysztof Kozlowski Subject: Re: [PATCH v2 01/13] dt-bindings: gpio: add common schema for GPIO controllers Message-ID: <20200922154018.GA2657058@bogus> References: <20200917165301.23100-1-krzk@kernel.org> <20200917165301.23100-2-krzk@kernel.org> <20200920193915.GA31074@kozik-lap> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200920193915.GA31074@kozik-lap> Cc: Linux-ALSA , Linus Walleij , linux-riscv , Fabio Estevam , "moderated list:ARM/STM32 ARCHITECTURE" , Bartosz Golaszewski , "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" , NXP Linux Team , linux-arm-msm , Linux Media Mailing List , devicetree@vger.kernel.org, Ray Jui , Sascha Hauer , linux-unisoc@lists.infradead.org, "moderated list:ARM/Mediatek SoC support" , linux-arm-kernel , Scott Branden , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , "open list:MEDIA DRIVERS FOR RENESAS - FCP" , Pengutronix Kernel Team , Shawn Guo X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sun, Sep 20, 2020 at 09:39:15PM +0200, Krzysztof Kozlowski wrote: > On Fri, Sep 18, 2020 at 08:30:02AM -0600, Rob Herring wrote: > > On Thu, Sep 17, 2020 at 10:53 AM Krzysztof Kozlowski wrote: > > > > > > Convert parts of gpio.txt bindings into common dtschema file for GPIO > > > controllers. The schema enforces proper naming of GPIO controller nodes > > > and GPIO hogs. > > > > Did you not see my previous reply about a common schema? We already > > have a common GPIO and hog schema in dtschema. Please add to it > > whatever is missing. > > Indeed, I'll enhance the dt-schema. > > The trouble is that each in-kernel YAML file still has to mention > possible gpio-hogs nodes. Is the proper solution to put them in common > YAML inside kernel sources? Currently, the gpio.yaml schema is applied to all nodes. That has the advantage that GPIO related properties are always checked whether we have a device specific schema or not. It has the disadvantage that you can't do some constraints like required properties or what's in child nodes. We could (and probably should) change it to be referenced by specific gpio controller schemas like we do for i2c, spi, etc. Then you can define required properties there and do something like: "-hogs$": type: object $ref: gpio-hogs.yaml# > > My goal is all common schema end up in dtschema, but I haven't pushed > > folks to do that yet. Ones I've done are there though. One issue is > > what's in dtschema should be GPL/BSD and the existing text bindings > > are default GPL, so there's a relicensing exercise. In some cases, the > > schema is there but I haven't copied over the descriptions. > > Right, I'll skip the descriptions when posting to dt-schema. I was hoping someone would add the descriptions. :) Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 723FEC4363D for ; Tue, 22 Sep 2020 15:40:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 300742399A for ; Tue, 22 Sep 2020 15:40:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600789226; bh=KFrvDEq/8TqB+9RYqLZtje/rGaAWyDrwgCKimpJ4yQU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=QmKFhWhZABS3XLaV4mVwkt3oKp6/KLqIugjdn5IL+Q5/l1aGbcHkzPY987QKgtoyA vO7moK+jKf6sdZlZzdxYmrlYAr+haHMZUleL6GAMWINxFm1jTh6ZcJ8fpF3Nn1bPS5 3lSbWiRGIYwKOtZUPc5oaVn7dYZcnA3EyUl2UQdM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726739AbgIVPkW (ORCPT ); Tue, 22 Sep 2020 11:40:22 -0400 Received: from mail-il1-f196.google.com ([209.85.166.196]:33292 "EHLO mail-il1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726566AbgIVPkW (ORCPT ); Tue, 22 Sep 2020 11:40:22 -0400 Received: by mail-il1-f196.google.com with SMTP id y2so7038542ila.0; Tue, 22 Sep 2020 08:40:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8GdJRN6siN1K/3VUt/RzQ7dwFh0PUHODAfHPAkJXVec=; b=WGB1VOEU6jpfTlda4fWmes7xisIZXnU6Tzzeqph8/n3wBAOw1Zzd+FJ+curOT93GwE EkaZEedS9NkDk7+PI4hrva4N7KYDxzhmTY22Ix8InMEmNPOfO+FawxWqqw8Xr9jDNkp6 nxWcILJ21C3JkJzg2pXXNe3R1uz8QvhYY7x0G38GQJSYDFOFQdq0CfM7DO68biSUS/3v sbs+Nxmr843R79GP+k1CPv5IhNeldoP2gLXB8+amaKE+JnXZCj8/6V4C/ACr+c49zPWC q+aP+op6vxuTRbnsxS17429wALAIsiQ1Y6y1x6Hy6d3TFnzZ4r9z0b+6jGcBD6dw7bDB EuvQ== X-Gm-Message-State: AOAM531hp0fJc1iilTU2KuDJ2eBO3I+rtTA+fYomPskh8DUMCUJVR+yx o7yqgA4/0Y9liM4Z9nOKOA== X-Google-Smtp-Source: ABdhPJyREJxSIdBKii6r07HwAtgscFY+xZM0Hzr/ADdWxpwvmnoH8SQzW6oBqLEpp2gzISGF/n+Kjw== X-Received: by 2002:a92:b503:: with SMTP id f3mr4935318ile.23.1600789220548; Tue, 22 Sep 2020 08:40:20 -0700 (PDT) Received: from xps15 ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id e4sm7533543iom.14.2020.09.22.08.40.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Sep 2020 08:40:19 -0700 (PDT) Received: (nullmailer pid 2730094 invoked by uid 1000); Tue, 22 Sep 2020 15:40:18 -0000 Date: Tue, 22 Sep 2020 09:40:18 -0600 From: Rob Herring To: Krzysztof Kozlowski Cc: Linus Walleij , Bartosz Golaszewski , Ray Jui , Scott Branden , "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , "open list:GPIO SUBSYSTEM" , devicetree@vger.kernel.org, linux-arm-kernel , "linux-kernel@vger.kernel.org" , linux-unisoc@lists.infradead.org, linux-arm-msm , linux-riscv , Linux Media Mailing List , Linux-ALSA , "moderated list:ARM/STM32 ARCHITECTURE" , "moderated list:ARM/Mediatek SoC support" , "open list:MEDIA DRIVERS FOR RENESAS - FCP" Subject: Re: [PATCH v2 01/13] dt-bindings: gpio: add common schema for GPIO controllers Message-ID: <20200922154018.GA2657058@bogus> References: <20200917165301.23100-1-krzk@kernel.org> <20200917165301.23100-2-krzk@kernel.org> <20200920193915.GA31074@kozik-lap> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200920193915.GA31074@kozik-lap> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Sun, Sep 20, 2020 at 09:39:15PM +0200, Krzysztof Kozlowski wrote: > On Fri, Sep 18, 2020 at 08:30:02AM -0600, Rob Herring wrote: > > On Thu, Sep 17, 2020 at 10:53 AM Krzysztof Kozlowski wrote: > > > > > > Convert parts of gpio.txt bindings into common dtschema file for GPIO > > > controllers. The schema enforces proper naming of GPIO controller nodes > > > and GPIO hogs. > > > > Did you not see my previous reply about a common schema? We already > > have a common GPIO and hog schema in dtschema. Please add to it > > whatever is missing. > > Indeed, I'll enhance the dt-schema. > > The trouble is that each in-kernel YAML file still has to mention > possible gpio-hogs nodes. Is the proper solution to put them in common > YAML inside kernel sources? Currently, the gpio.yaml schema is applied to all nodes. That has the advantage that GPIO related properties are always checked whether we have a device specific schema or not. It has the disadvantage that you can't do some constraints like required properties or what's in child nodes. We could (and probably should) change it to be referenced by specific gpio controller schemas like we do for i2c, spi, etc. Then you can define required properties there and do something like: "-hogs$": type: object $ref: gpio-hogs.yaml# > > My goal is all common schema end up in dtschema, but I haven't pushed > > folks to do that yet. Ones I've done are there though. One issue is > > what's in dtschema should be GPL/BSD and the existing text bindings > > are default GPL, so there's a relicensing exercise. In some cases, the > > schema is there but I haven't copied over the descriptions. > > Right, I'll skip the descriptions when posting to dt-schema. I was hoping someone would add the descriptions. :) Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7412DC4363D for ; Tue, 22 Sep 2020 15:40:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1BB83212CC for ; Tue, 22 Sep 2020 15:40:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="D6I4tkya" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1BB83212CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1Sp4ZRfOpSX/Xk8H5sDLftVF6hKF+MfAF7zYWqHIfng=; b=D6I4tkyaRGprmPWZmzbxPOqXr 49DPxBT3I03/647078FujhT1PysLlOoMZCVdOr/vKvzC0dm57BjY7LQ83VknooSNoCn+pmoyYd4/U r7Bt4G5YZrdMyw6dn2N4rndGcc2Q0N+9YTO0OZ+/jZBfXJWAzrwJWsB5gAPfT13zvOHvkV2/4jK5W 44j2xYb9PbZYlxEKjGGqrDT14qT8M+sYjHfnWciY6UJoSY7DcGZu2mGWR67rHf8bS+NwO0dCWMW/d tRXoqB7WO6p3TRNgYUK/q78XwAXupITpuBN9gFbKCRAVDYEkbYQQ4r4UYR+Mxhh+6KtbLYOOVUEIz v8DZb/i7A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKkP7-000507-9U; Tue, 22 Sep 2020 15:40:29 +0000 Received: from mail-il1-f194.google.com ([209.85.166.194]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKkP1-0004yO-7Q; Tue, 22 Sep 2020 15:40:24 +0000 Received: by mail-il1-f194.google.com with SMTP id t13so17705078ile.9; Tue, 22 Sep 2020 08:40:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8GdJRN6siN1K/3VUt/RzQ7dwFh0PUHODAfHPAkJXVec=; b=DACpAJtOY1SiSTOueG57TOyuLpqtUYsR56bwyJDUwBo/Jrllc1mQeQB4oufe/0lOtg En0iqsZobJiAhiviNhCUz3yzu1boaj3VP/SCSfqc4VpdDa3j+DX7zBk3s7WISu8pPuBo oWuPtflSKI9IWhBWPtuEWR9bn94l5bzn8RAD3JREQhTL1UbwUehg7m8bZcBRTgQr+aqm oaqHQe8RDYc9cJfkgZEPU+5ZolL+J2m1XPo6VkIsmkU5mppaarWuHGggSS80XOvHNRdM 0oG1SCOFP8l0pSmmzopnh8vE6232jmfCVbKei1abfT3Cd599G/i3lRhFg1ev7G+yUJHp 1WYA== X-Gm-Message-State: AOAM533j6tifVhQUkDoiAok5DfccBj9J7tSmyvEpolEouqhGnBReamIK IjXEJyAk2f8hO/vCPwakgg== X-Google-Smtp-Source: ABdhPJyREJxSIdBKii6r07HwAtgscFY+xZM0Hzr/ADdWxpwvmnoH8SQzW6oBqLEpp2gzISGF/n+Kjw== X-Received: by 2002:a92:b503:: with SMTP id f3mr4935318ile.23.1600789220548; Tue, 22 Sep 2020 08:40:20 -0700 (PDT) Received: from xps15 ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id e4sm7533543iom.14.2020.09.22.08.40.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Sep 2020 08:40:19 -0700 (PDT) Received: (nullmailer pid 2730094 invoked by uid 1000); Tue, 22 Sep 2020 15:40:18 -0000 Date: Tue, 22 Sep 2020 09:40:18 -0600 From: Rob Herring To: Krzysztof Kozlowski Subject: Re: [PATCH v2 01/13] dt-bindings: gpio: add common schema for GPIO controllers Message-ID: <20200922154018.GA2657058@bogus> References: <20200917165301.23100-1-krzk@kernel.org> <20200917165301.23100-2-krzk@kernel.org> <20200920193915.GA31074@kozik-lap> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200920193915.GA31074@kozik-lap> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200922_114023_284571_5B1977F2 X-CRM114-Status: GOOD ( 21.46 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux-ALSA , Linus Walleij , linux-riscv , Fabio Estevam , "moderated list:ARM/STM32 ARCHITECTURE" , Bartosz Golaszewski , "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" , NXP Linux Team , linux-arm-msm , Linux Media Mailing List , devicetree@vger.kernel.org, Ray Jui , Sascha Hauer , linux-unisoc@lists.infradead.org, "moderated list:ARM/Mediatek SoC support" , linux-arm-kernel , Scott Branden , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , "open list:MEDIA DRIVERS FOR RENESAS - FCP" , Pengutronix Kernel Team , Shawn Guo Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Sun, Sep 20, 2020 at 09:39:15PM +0200, Krzysztof Kozlowski wrote: > On Fri, Sep 18, 2020 at 08:30:02AM -0600, Rob Herring wrote: > > On Thu, Sep 17, 2020 at 10:53 AM Krzysztof Kozlowski wrote: > > > > > > Convert parts of gpio.txt bindings into common dtschema file for GPIO > > > controllers. The schema enforces proper naming of GPIO controller nodes > > > and GPIO hogs. > > > > Did you not see my previous reply about a common schema? We already > > have a common GPIO and hog schema in dtschema. Please add to it > > whatever is missing. > > Indeed, I'll enhance the dt-schema. > > The trouble is that each in-kernel YAML file still has to mention > possible gpio-hogs nodes. Is the proper solution to put them in common > YAML inside kernel sources? Currently, the gpio.yaml schema is applied to all nodes. That has the advantage that GPIO related properties are always checked whether we have a device specific schema or not. It has the disadvantage that you can't do some constraints like required properties or what's in child nodes. We could (and probably should) change it to be referenced by specific gpio controller schemas like we do for i2c, spi, etc. Then you can define required properties there and do something like: "-hogs$": type: object $ref: gpio-hogs.yaml# > > My goal is all common schema end up in dtschema, but I haven't pushed > > folks to do that yet. Ones I've done are there though. One issue is > > what's in dtschema should be GPL/BSD and the existing text bindings > > are default GPL, so there's a relicensing exercise. In some cases, the > > schema is there but I haven't copied over the descriptions. > > Right, I'll skip the descriptions when posting to dt-schema. I was hoping someone would add the descriptions. :) Rob _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87AC8C2D0E2 for ; Tue, 22 Sep 2020 15:40:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F49E20C09 for ; Tue, 22 Sep 2020 15:40:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qck2LtBj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F49E20C09 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tgT/Bg26ccssdso3i0D4lnVH1/JfvpdDnP9/r+ze1TI=; b=qck2LtBjl2YCUlTubd5JIuXYT F5MygRkbtLejzwnJqx0U6pajLEt9hgHj81VN5Lmv6J5/Hb/3KOwpXpYLjmJtijhdBO24rdFUjPGwv /zD17dnMEW7NI19MU6EB/x21UqX5aMYhjZlxTFYAv1GjgwLY+8mxr4/pzgFYhpHX6Y++0Vejr5IJF LJBo+vL2TFKLPoONh9WU5GzUHrVu8Y52HkywAgM3GG7f/vBimDnDf7CEUMRXBBfW3ulr2k0yCLizv u1Q2Fva75tf9dyYglUyn/I6XAnKAb9p9EWzbQEmFhD9dIf4qBMQYCOlMa7n7OosqXx2DDgTc5T9MU zqjolzd9w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKkP6-0004zu-EK; Tue, 22 Sep 2020 15:40:28 +0000 Received: from mail-il1-f194.google.com ([209.85.166.194]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKkP1-0004yO-7Q; Tue, 22 Sep 2020 15:40:24 +0000 Received: by mail-il1-f194.google.com with SMTP id t13so17705078ile.9; Tue, 22 Sep 2020 08:40:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8GdJRN6siN1K/3VUt/RzQ7dwFh0PUHODAfHPAkJXVec=; b=DACpAJtOY1SiSTOueG57TOyuLpqtUYsR56bwyJDUwBo/Jrllc1mQeQB4oufe/0lOtg En0iqsZobJiAhiviNhCUz3yzu1boaj3VP/SCSfqc4VpdDa3j+DX7zBk3s7WISu8pPuBo oWuPtflSKI9IWhBWPtuEWR9bn94l5bzn8RAD3JREQhTL1UbwUehg7m8bZcBRTgQr+aqm oaqHQe8RDYc9cJfkgZEPU+5ZolL+J2m1XPo6VkIsmkU5mppaarWuHGggSS80XOvHNRdM 0oG1SCOFP8l0pSmmzopnh8vE6232jmfCVbKei1abfT3Cd599G/i3lRhFg1ev7G+yUJHp 1WYA== X-Gm-Message-State: AOAM533j6tifVhQUkDoiAok5DfccBj9J7tSmyvEpolEouqhGnBReamIK IjXEJyAk2f8hO/vCPwakgg== X-Google-Smtp-Source: ABdhPJyREJxSIdBKii6r07HwAtgscFY+xZM0Hzr/ADdWxpwvmnoH8SQzW6oBqLEpp2gzISGF/n+Kjw== X-Received: by 2002:a92:b503:: with SMTP id f3mr4935318ile.23.1600789220548; Tue, 22 Sep 2020 08:40:20 -0700 (PDT) Received: from xps15 ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id e4sm7533543iom.14.2020.09.22.08.40.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Sep 2020 08:40:19 -0700 (PDT) Received: (nullmailer pid 2730094 invoked by uid 1000); Tue, 22 Sep 2020 15:40:18 -0000 Date: Tue, 22 Sep 2020 09:40:18 -0600 From: Rob Herring To: Krzysztof Kozlowski Subject: Re: [PATCH v2 01/13] dt-bindings: gpio: add common schema for GPIO controllers Message-ID: <20200922154018.GA2657058@bogus> References: <20200917165301.23100-1-krzk@kernel.org> <20200917165301.23100-2-krzk@kernel.org> <20200920193915.GA31074@kozik-lap> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200920193915.GA31074@kozik-lap> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200922_114023_284571_5B1977F2 X-CRM114-Status: GOOD ( 21.46 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux-ALSA , Linus Walleij , linux-riscv , Fabio Estevam , "moderated list:ARM/STM32 ARCHITECTURE" , Bartosz Golaszewski , "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" , NXP Linux Team , linux-arm-msm , Linux Media Mailing List , devicetree@vger.kernel.org, Ray Jui , Sascha Hauer , linux-unisoc@lists.infradead.org, "moderated list:ARM/Mediatek SoC support" , linux-arm-kernel , Scott Branden , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , "open list:MEDIA DRIVERS FOR RENESAS - FCP" , Pengutronix Kernel Team , Shawn Guo Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Sun, Sep 20, 2020 at 09:39:15PM +0200, Krzysztof Kozlowski wrote: > On Fri, Sep 18, 2020 at 08:30:02AM -0600, Rob Herring wrote: > > On Thu, Sep 17, 2020 at 10:53 AM Krzysztof Kozlowski wrote: > > > > > > Convert parts of gpio.txt bindings into common dtschema file for GPIO > > > controllers. The schema enforces proper naming of GPIO controller nodes > > > and GPIO hogs. > > > > Did you not see my previous reply about a common schema? We already > > have a common GPIO and hog schema in dtschema. Please add to it > > whatever is missing. > > Indeed, I'll enhance the dt-schema. > > The trouble is that each in-kernel YAML file still has to mention > possible gpio-hogs nodes. Is the proper solution to put them in common > YAML inside kernel sources? Currently, the gpio.yaml schema is applied to all nodes. That has the advantage that GPIO related properties are always checked whether we have a device specific schema or not. It has the disadvantage that you can't do some constraints like required properties or what's in child nodes. We could (and probably should) change it to be referenced by specific gpio controller schemas like we do for i2c, spi, etc. Then you can define required properties there and do something like: "-hogs$": type: object $ref: gpio-hogs.yaml# > > My goal is all common schema end up in dtschema, but I haven't pushed > > folks to do that yet. Ones I've done are there though. One issue is > > what's in dtschema should be GPL/BSD and the existing text bindings > > are default GPL, so there's a relicensing exercise. In some cases, the > > schema is there but I haven't copied over the descriptions. > > Right, I'll skip the descriptions when posting to dt-schema. I was hoping someone would add the descriptions. :) Rob _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5398C4363D for ; Tue, 22 Sep 2020 15:42:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70AAB2388B for ; Tue, 22 Sep 2020 15:42:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="1KgNZe4t" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70AAB2388B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9K+GjISUq7NrIk7XgMsoS30i6WGVyPdQNKntR+7A3+4=; b=1KgNZe4tXTr9GQ9NRi0s+XmYO nKNB0UClvQy/Pw7EM5bMZ7m6ycDVWlKXPT0cahn8SQajcMolEZ8/nygxUSqxD6IfcPiSx/bEEouYs Fz7Ea3z2qS5wUuzAThFCtjFRya4WO/w4H97ZewtTbAVRCnspnt32W0JtJsZvHM2kMyY2AqoeFZNwp +n2WozpG+KTeYp7FVtLbOXsdlJlr2a9+6+kFbpGozPBewLNmE1B2xK1Z2O38Jxfn7O8ImAFM2Gx+w nzynbto/BvkBVdDPfiRakIivgxODCiMBDOSrfQMcUrS2aozNy9b0zU+3pAwae8hGMVCgfYJxN9oLW H4GjyxMeg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKkP4-0004zJ-A4; Tue, 22 Sep 2020 15:40:26 +0000 Received: from mail-il1-f194.google.com ([209.85.166.194]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKkP1-0004yO-7Q; Tue, 22 Sep 2020 15:40:24 +0000 Received: by mail-il1-f194.google.com with SMTP id t13so17705078ile.9; Tue, 22 Sep 2020 08:40:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8GdJRN6siN1K/3VUt/RzQ7dwFh0PUHODAfHPAkJXVec=; b=DACpAJtOY1SiSTOueG57TOyuLpqtUYsR56bwyJDUwBo/Jrllc1mQeQB4oufe/0lOtg En0iqsZobJiAhiviNhCUz3yzu1boaj3VP/SCSfqc4VpdDa3j+DX7zBk3s7WISu8pPuBo oWuPtflSKI9IWhBWPtuEWR9bn94l5bzn8RAD3JREQhTL1UbwUehg7m8bZcBRTgQr+aqm oaqHQe8RDYc9cJfkgZEPU+5ZolL+J2m1XPo6VkIsmkU5mppaarWuHGggSS80XOvHNRdM 0oG1SCOFP8l0pSmmzopnh8vE6232jmfCVbKei1abfT3Cd599G/i3lRhFg1ev7G+yUJHp 1WYA== X-Gm-Message-State: AOAM533j6tifVhQUkDoiAok5DfccBj9J7tSmyvEpolEouqhGnBReamIK IjXEJyAk2f8hO/vCPwakgg== X-Google-Smtp-Source: ABdhPJyREJxSIdBKii6r07HwAtgscFY+xZM0Hzr/ADdWxpwvmnoH8SQzW6oBqLEpp2gzISGF/n+Kjw== X-Received: by 2002:a92:b503:: with SMTP id f3mr4935318ile.23.1600789220548; Tue, 22 Sep 2020 08:40:20 -0700 (PDT) Received: from xps15 ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id e4sm7533543iom.14.2020.09.22.08.40.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Sep 2020 08:40:19 -0700 (PDT) Received: (nullmailer pid 2730094 invoked by uid 1000); Tue, 22 Sep 2020 15:40:18 -0000 Date: Tue, 22 Sep 2020 09:40:18 -0600 From: Rob Herring To: Krzysztof Kozlowski Subject: Re: [PATCH v2 01/13] dt-bindings: gpio: add common schema for GPIO controllers Message-ID: <20200922154018.GA2657058@bogus> References: <20200917165301.23100-1-krzk@kernel.org> <20200917165301.23100-2-krzk@kernel.org> <20200920193915.GA31074@kozik-lap> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200920193915.GA31074@kozik-lap> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200922_114023_284571_5B1977F2 X-CRM114-Status: GOOD ( 21.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux-ALSA , Linus Walleij , linux-riscv , Fabio Estevam , "moderated list:ARM/STM32 ARCHITECTURE" , Bartosz Golaszewski , "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" , NXP Linux Team , linux-arm-msm , Linux Media Mailing List , devicetree@vger.kernel.org, Ray Jui , Sascha Hauer , linux-unisoc@lists.infradead.org, "moderated list:ARM/Mediatek SoC support" , linux-arm-kernel , Scott Branden , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , "open list:MEDIA DRIVERS FOR RENESAS - FCP" , Pengutronix Kernel Team , Shawn Guo Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Sep 20, 2020 at 09:39:15PM +0200, Krzysztof Kozlowski wrote: > On Fri, Sep 18, 2020 at 08:30:02AM -0600, Rob Herring wrote: > > On Thu, Sep 17, 2020 at 10:53 AM Krzysztof Kozlowski wrote: > > > > > > Convert parts of gpio.txt bindings into common dtschema file for GPIO > > > controllers. The schema enforces proper naming of GPIO controller nodes > > > and GPIO hogs. > > > > Did you not see my previous reply about a common schema? We already > > have a common GPIO and hog schema in dtschema. Please add to it > > whatever is missing. > > Indeed, I'll enhance the dt-schema. > > The trouble is that each in-kernel YAML file still has to mention > possible gpio-hogs nodes. Is the proper solution to put them in common > YAML inside kernel sources? Currently, the gpio.yaml schema is applied to all nodes. That has the advantage that GPIO related properties are always checked whether we have a device specific schema or not. It has the disadvantage that you can't do some constraints like required properties or what's in child nodes. We could (and probably should) change it to be referenced by specific gpio controller schemas like we do for i2c, spi, etc. Then you can define required properties there and do something like: "-hogs$": type: object $ref: gpio-hogs.yaml# > > My goal is all common schema end up in dtschema, but I haven't pushed > > folks to do that yet. Ones I've done are there though. One issue is > > what's in dtschema should be GPL/BSD and the existing text bindings > > are default GPL, so there's a relicensing exercise. In some cases, the > > schema is there but I haven't copied over the descriptions. > > Right, I'll skip the descriptions when posting to dt-schema. I was hoping someone would add the descriptions. :) Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel