From: Lina Iyer <ilina@codeaurora.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Linux PM <linux-pm@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH] cpuidle: governor: export cpuidle governor functions
Date: Tue, 22 Sep 2020 10:12:15 -0600 [thread overview]
Message-ID: <20200922161215.GD30658@codeaurora.org> (raw)
In-Reply-To: <CAJZ5v0hJJxxb+J5UtyZe2S_Tn7ARoGvjwDjw4dq601VJrriH9g@mail.gmail.com>
Hi Rafael,
On Tue, Sep 22 2020 at 10:00 -0600, Rafael J. Wysocki wrote:
>Sorry for the delay.
>
>On Wed, Sep 9, 2020 at 12:15 AM Lina Iyer <ilina@codeaurora.org> wrote:
>>
>> Commit 83788c0caed3 ("cpuidle: remove unused exports") removed
>> capability of registering cpuidle governors, which was unused at that
>> time. By exporting the symbol, let's allow platform specific modules to
>> register cpuidle governors and use cpuidle_governor_latency_req() to get
>> the QoS for the CPU.
>
>Which platform-specific modules may want to do that and why?
>
We are planning a custom cpuidle governor for QCOM SoCs. With Android,
the idea is to make them loadable modules so they can be in a separate
partition.
Thanks,
Lina
>> Signed-off-by: Lina Iyer <ilina@codeaurora.org>
>> ---
>> drivers/cpuidle/governor.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/cpuidle/governor.c b/drivers/cpuidle/governor.c
>> index 29acaf48e575..0e51ed25665e 100644
>> --- a/drivers/cpuidle/governor.c
>> +++ b/drivers/cpuidle/governor.c
>> @@ -102,6 +102,7 @@ int cpuidle_register_governor(struct cpuidle_governor *gov)
>>
>> return ret;
>> }
>> +EXPORT_SYMBOL_GPL(cpuidle_register_governor);
>>
>> /**
>> * cpuidle_governor_latency_req - Compute a latency constraint for CPU
>> @@ -118,3 +119,4 @@ s64 cpuidle_governor_latency_req(unsigned int cpu)
>>
>> return (s64)device_req * NSEC_PER_USEC;
>> }
>> +EXPORT_SYMBOL_GPL(cpuidle_governor_latency_req);
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
>> a Linux Foundation Collaborative Project
>>
next prev parent reply other threads:[~2020-09-22 16:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 22:15 [PATCH] cpuidle: governor: export cpuidle governor functions Lina Iyer
2020-09-22 16:00 ` Rafael J. Wysocki
2020-09-22 16:12 ` Lina Iyer [this message]
2020-09-22 17:27 ` Rafael J. Wysocki
2020-10-09 20:26 ` Daniel Lezcano
2021-08-17 9:31 ` Maulik Shah
2021-08-19 15:02 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922161215.GD30658@codeaurora.org \
--to=ilina@codeaurora.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.