From: Rob Herring <robh@kernel.org>
To: Ricardo Rivera-Matos <r-rivera-matos@ti.com>
Cc: sre@kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dmurphy@ti.com
Subject: Re: [PATCH v3 1/2] dt-bindings: power: Add the bq256xx dt bindings
Date: Tue, 22 Sep 2020 16:22:03 -0600 [thread overview]
Message-ID: <20200922222203.GA3360459@bogus> (raw)
In-Reply-To: <20200910164534.16987-2-r-rivera-matos@ti.com>
On Thu, Sep 10, 2020 at 11:45:33AM -0500, Ricardo Rivera-Matos wrote:
> Add the bindings for the bq256xx series of battery charging ICs.
>
> Datasheets:
> - https://www.ti.com/lit/ds/symlink/bq25600.pdf
> - https://www.ti.com/lit/ds/symlink/bq25601.pdf
> - https://www.ti.com/lit/ds/symlink/bq25600d.pdf
> - https://www.ti.com/lit/ds/symlink/bq25601d.pdf
> - https://www.ti.com/lit/ds/symlink/bq25611d.pdf
> - https://www.ti.com/lit/ds/symlink/bq25618.pdf
> - https://www.ti.com/lit/ds/symlink/bq25619.pdf
>
> Signed-off-by: Ricardo Rivera-Matos <r-rivera-matos@ti.com>
> ---
> .../bindings/power/supply/bq256xx.yaml | 97 +++++++++++++++++++
> 1 file changed, 97 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/supply/bq256xx.yaml
>
> diff --git a/Documentation/devicetree/bindings/power/supply/bq256xx.yaml b/Documentation/devicetree/bindings/power/supply/bq256xx.yaml
> new file mode 100644
> index 000000000000..8cc2242f7df0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/bq256xx.yaml
> @@ -0,0 +1,97 @@
> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
> +# Copyright (C) 2020 Texas Instruments Incorporated
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/power/supply/bq256xx.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: TI bq256xx Switch Mode Buck Charger
> +
> +maintainers:
> + - Ricardo Rivera-Matos <r-rivera-matos@ti.com>
> +
> +description: |
> + The bq256xx devices are a family of highly-integrated battery charge
> + management and system power management ICs for single cell Li-ion and Li-
> + polymer batteries.
> +
> + Datasheets:
> + - https://www.ti.com/lit/ds/symlink/bq25600.pdf
> + - https://www.ti.com/lit/ds/symlink/bq25601.pdf
> + - https://www.ti.com/lit/ds/symlink/bq25600d.pdf
> + - https://www.ti.com/lit/ds/symlink/bq25601d.pdf
> + - https://www.ti.com/lit/ds/symlink/bq25611d.pdf
> + - https://www.ti.com/lit/ds/symlink/bq25618.pdf
> + - https://www.ti.com/lit/ds/symlink/bq25619.pdf
> +
> +properties:
> + compatible:
> + enum:
> + - ti,bq25600
> + - ti,bq25601
> + - ti,bq25600d
> + - ti,bq25601d
> + - ti,bq25611d
> + - ti,bq25618
> + - ti,bq25619
> +
> + reg:
> + maxItems: 1
> +
> + ti,watchdog-timer:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + Watchdog timer in ms. 0 (default) disables the watchdog
> + minimum: 0
> + maximum: 160000
> + enum: [ 0, 40000, 80000, 160000]
> +
> + input-voltage-limit-microvolt:
> + description: |
> + Minimum input voltage limit in µV with a 100000 µV step
> + minimum: 3900000
> + maximum: 5400000
> +
> + input-current-limit-microamp:
> + description: |
> + Maximum input current limit in µA with a 100000 µA step
> + minimum: 100000
> + maximum: 3200000
> +
> +required:
> + - compatible
> + - reg
> + - monitored-battery
additionalProperties: false
And then fix what breaks in the example.
> +
> +examples:
> + - |
> + bat: battery {
> + compatible = "simple-battery";
> + constant-charge-current-max-microamp = <2040000>;
> + constant-charge-voltage-max-microvolt = <4352000>;
> + precharge-current-microamp = <180000>;
> + charge-term-current-microamp = <180000>;
> + };
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> + i2c {
> +
> + clock-frequency = <400000>;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + charger@6b {
> + compatible = "ti,bq25601";
> + reg = <0x6b>;
> + monitored-battery = <&bat>;
> +
> + interrupt-parent = <&gpio1>;
> + interrupts = <16 IRQ_TYPE_EDGE_FALLING>;
> + watchdog-timer = <40000>;
> +
> + input-voltage-limit-microvolt = <4500000>;
> + input-current-limit-microamp = <2400000>;
> + };
> + };
> +...
> --
> 2.28.0
>
next prev parent reply other threads:[~2020-09-22 22:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 16:45 [PATCH v3 0/2] Introduce the BQ256XX family of chargers Ricardo Rivera-Matos
2020-09-10 16:45 ` [PATCH v3 1/2] dt-bindings: power: Add the bq256xx dt bindings Ricardo Rivera-Matos
2020-09-22 22:22 ` Rob Herring [this message]
2020-09-22 22:56 ` [EXTERNAL] " Ricardo Rivera-Matos
2020-09-23 1:05 ` Dan Murphy
2020-09-23 1:14 ` Ricardo Rivera-Matos
2020-09-10 16:45 ` [PATCH v3 2/2] power: supply: bq256xx: Introduce the BQ256XX charger driver Ricardo Rivera-Matos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922222203.GA3360459@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=r-rivera-matos@ti.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.