From: Jason Gunthorpe <jgg@nvidia.com>
To: Kamal Heib <kamalheib1@gmail.com>
Cc: <linux-rdma@vger.kernel.org>, Doug Ledford <dledford@redhat.com>,
Yishai Hadas <yishaih@nvidia.com>
Subject: Re: [PATCH for-rc] RDMA/mlx4: Fix return value when QP type isn't supported
Date: Tue, 22 Sep 2020 20:30:03 -0300 [thread overview]
Message-ID: <20200922233003.GA809877@nvidia.com> (raw)
In-Reply-To: <20200922134429.130255-1-kamalheib1@gmail.com>
On Tue, Sep 22, 2020 at 04:44:29PM +0300, Kamal Heib wrote:
> The proper return code is "-EOPNOTSUPP" when trying to modify a raw
> packet QP over an IB port.
>
> Fixes: 3987a2d3193c ("IB/mlx4: Add raw packet QP support")
> Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
> ---
> drivers/infiniband/hw/mlx4/qp.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Is it? Why? EOPNOTSUPP should be used by the uverbs layer to indicate
that the operation is not implemented in the driver
Calling modify_qp against a RAW_QP when it is not supported by spec is
EINVAL?
Jason
next prev parent reply other threads:[~2020-09-22 23:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 13:44 [PATCH for-rc] RDMA/mlx4: Fix return value when QP type isn't supported Kamal Heib
2020-09-22 23:30 ` Jason Gunthorpe [this message]
2020-09-27 13:04 ` Kamal Heib
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922233003.GA809877@nvidia.com \
--to=jgg@nvidia.com \
--cc=dledford@redhat.com \
--cc=kamalheib1@gmail.com \
--cc=linux-rdma@vger.kernel.org \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.