From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKun9-0005hU-Hn for kexec@lists.infradead.org; Wed, 23 Sep 2020 02:46:00 +0000 Date: Wed, 23 Sep 2020 10:45:48 +0800 From: Baoquan He Subject: Re: [PATCH 1/3] MIPS: Crash kernel should be able to see old memories Message-ID: <20200923024548.GL25604@MiWiFi-R3L-srv> References: <1600828257-31316-1-git-send-email-chenhc@lemote.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1600828257-31316-1-git-send-email-chenhc@lemote.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Huacai Chen Cc: Thomas Bogendoerfer , Huacai Chen , kexec@lists.infradead.org, linux-mips@vger.kernel.org, Jiaxun Yang , Eric Biederman , Fuxin Zhang , Dave Young , Vivek Goyal On 09/23/20 at 10:30am, Huacai Chen wrote: > Kexec-tools use mem=X@Y to pass usable memories to crash kernel, but in > commit a94e4f24ec836c8984f83959 ("MIPS: init: Drop boot_mem_map") all > BIOS passed memories are removed by early_parse_mem(). I think this is > reasonable for a normal kernel but not for a crash kernel, because a > crash kernel should be able to see all old memories, even though it is > not supposed to use them. I am not familiar with MIPS code, but we analyze and fill memmap= to pass usable memory to crashkenrel in kexec-tools, do you mean you are specifying memmap= or mem= by hand? And we don't have mem=X@Y, only mem=nn[KMG]. > > Fixes: a94e4f24ec836c8984f83959 ("MIPS: init: Drop boot_mem_map") > Signed-off-by: Huacai Chen > --- > arch/mips/kernel/setup.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c > index 4c04a86..e2804a2 100644 > --- a/arch/mips/kernel/setup.c > +++ b/arch/mips/kernel/setup.c > @@ -392,8 +392,10 @@ static int __init early_parse_mem(char *p) > */ > if (usermem == 0) { > usermem = 1; > +#ifndef CONFIG_CRASH_DUMP > memblock_remove(memblock_start_of_DRAM(), > memblock_end_of_DRAM() - memblock_start_of_DRAM()); > +#endif > } > start = 0; > size = memparse(p, &p); > -- > 2.7.0 > _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 184D0C4363D for ; Wed, 23 Sep 2020 02:46:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B7C3F20735 for ; Wed, 23 Sep 2020 02:46:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="g6nISIh/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726969AbgIWCqB (ORCPT ); Tue, 22 Sep 2020 22:46:01 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:41129 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726835AbgIWCqB (ORCPT ); Tue, 22 Sep 2020 22:46:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600829160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yFl7X3RZX/t9Bt2pfDI/ltPnjdZAcydrWhFfcJxomVk=; b=g6nISIh/R9hgy/l9YdxM+lP0wOKqsuTVTAPyZikLGwA1T44bz0UtidtVCATRPmAtF86JNd 1WOioFmY7zQjXxX4sLGNArvRXiaYh4aF9r362vtCggk5DPPmSqAU8x8QscMADuYcv25Sjj lwodIF5vW97Iqvu7gXHDpchhbRd5uDk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-596-Xxn4qfmdOtOOOiSXOS7AVA-1; Tue, 22 Sep 2020 22:45:56 -0400 X-MC-Unique: Xxn4qfmdOtOOOiSXOS7AVA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E83C0801AE8; Wed, 23 Sep 2020 02:45:54 +0000 (UTC) Received: from localhost (ovpn-12-42.pek2.redhat.com [10.72.12.42]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3161027CB7; Wed, 23 Sep 2020 02:45:50 +0000 (UTC) Date: Wed, 23 Sep 2020 10:45:48 +0800 From: Baoquan He To: Huacai Chen Cc: Thomas Bogendoerfer , Eric Biederman , Dave Young , Vivek Goyal , linux-mips@vger.kernel.org, kexec@lists.infradead.org, Fuxin Zhang , Huacai Chen , Jiaxun Yang Subject: Re: [PATCH 1/3] MIPS: Crash kernel should be able to see old memories Message-ID: <20200923024548.GL25604@MiWiFi-R3L-srv> References: <1600828257-31316-1-git-send-email-chenhc@lemote.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1600828257-31316-1-git-send-email-chenhc@lemote.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On 09/23/20 at 10:30am, Huacai Chen wrote: > Kexec-tools use mem=X@Y to pass usable memories to crash kernel, but in > commit a94e4f24ec836c8984f83959 ("MIPS: init: Drop boot_mem_map") all > BIOS passed memories are removed by early_parse_mem(). I think this is > reasonable for a normal kernel but not for a crash kernel, because a > crash kernel should be able to see all old memories, even though it is > not supposed to use them. I am not familiar with MIPS code, but we analyze and fill memmap= to pass usable memory to crashkenrel in kexec-tools, do you mean you are specifying memmap= or mem= by hand? And we don't have mem=X@Y, only mem=nn[KMG]. > > Fixes: a94e4f24ec836c8984f83959 ("MIPS: init: Drop boot_mem_map") > Signed-off-by: Huacai Chen > --- > arch/mips/kernel/setup.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c > index 4c04a86..e2804a2 100644 > --- a/arch/mips/kernel/setup.c > +++ b/arch/mips/kernel/setup.c > @@ -392,8 +392,10 @@ static int __init early_parse_mem(char *p) > */ > if (usermem == 0) { > usermem = 1; > +#ifndef CONFIG_CRASH_DUMP > memblock_remove(memblock_start_of_DRAM(), > memblock_end_of_DRAM() - memblock_start_of_DRAM()); > +#endif > } > start = 0; > size = memparse(p, &p); > -- > 2.7.0 >