From: Thierry Reding <thierry.reding@gmail.com>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: linux-pwm@vger.kernel.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Lee Jones" <lee.jones@linaro.org>,
"Guru Das Srinagesh" <gurus@codeaurora.org>
Subject: Re: [PATCH] pwm: Allow store 64-bit duty cycle from sysfs interface
Date: Wed, 23 Sep 2020 14:11:04 +0200 [thread overview]
Message-ID: <20200923121104.GC1848911@ulmo> (raw)
In-Reply-To: <20200824145539.3160946-1-jarkko.nikula@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 708 bytes --]
On Mon, Aug 24, 2020 at 05:55:39PM +0300, Jarkko Nikula wrote:
> PWM core was converted to u64 by the commit a9d887dc1c60 ("pwm: Convert
> period and duty cycle to u64") but did not change the duty_cycle_store()
> so it will error out if trying to pass a numeric string bigger than
> 2^32-1.
>
> Fix this by using u64 and kstrtou64() in duty_cycle_store().
>
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> ---
> I don't think this qualifies for a Fixes tag since original commit doesn't
> cause a regression while still might be good for v5.9 material.
> ---
> drivers/pwm/sysfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-09-23 12:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 14:55 [PATCH] pwm: Allow store 64-bit duty cycle from sysfs interface Jarkko Nikula
2020-08-27 20:37 ` Guru Das Srinagesh
2020-09-07 15:22 ` Uwe Kleine-König
2020-09-23 12:11 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200923121104.GC1848911@ulmo \
--to=thierry.reding@gmail.com \
--cc=gurus@codeaurora.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=lee.jones@linaro.org \
--cc=linux-pwm@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.