From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D398C4363D for ; Wed, 23 Sep 2020 14:04:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C802E221EB for ; Wed, 23 Sep 2020 14:04:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pk6zY+8B" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C802E221EB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ECWmuWMu7IOnr2RDh0UFytEu2MiMaXVjgurEwJR1xiA=; b=pk6zY+8Bm7qINDEq0omH58URe gRly99i6sH4dFfaBaAmBkdgwO0LRI7fd8t8H9OX5p3lbk+pgUXHGWkOdGGvINqa+Omr2g23y08J6s dhfalWkdwcLVGxgNy5KF4fhzhw1q8//rNqlgPVXWr922xi4iPiR7s+esL2w7No3+JajWRbzkJpbz3 n8/dQsr7ZCen/+bM2n9jphq5r4/uMnHNFNSaD9dV/5D3VlKtTbM1oAqw/z/kGexMNjXdSFp//hrE2 KjLfVbkj//CgpBzpifalGAcZS9Oz45Ny2DTjYzKrD9h9BaKEW3/Vh/W0g/Q9JKhH77LDw36cMVpkL nI7ta8asA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kL5O5-00044g-Nl; Wed, 23 Sep 2020 14:04:49 +0000 Received: from mail-io1-f65.google.com ([209.85.166.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kL5O2-00043Z-33; Wed, 23 Sep 2020 14:04:47 +0000 Received: by mail-io1-f65.google.com with SMTP id z13so23802702iom.8; Wed, 23 Sep 2020 07:04:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/2YIbGPyeDVPWPtl7cPgfN2lbTkXGFerVZnaUBAltaA=; b=nN1Sx2AdwS/SclBzKQpmrI+Gim+E7mqSPTVMsOvWg/F2iYdKiQipKAVlsEqtXwjzQ6 igflx+0RHhahM3pPkpZxmyadp26LN93KWggE+yGFtdqEbBKXpez45ID3TxOWsS8EMZcn 7coyhWJUGK0hFIEFMNNyGH/gD8ho/7ON/55Jrb+jnPTgyJDrbdaXnMqoIwMyREPwpiPi U2omI2080Zp5CJG437VLrZeWItiMlIuV4NJ0+neWrcQOZI+PzlFDKzv9l16YBO5e6EP5 hvvfgZFILwK1G5HMLf4KfJww5bneacPOpYpZxwxhNBwulT8U5Sf9IRt2jJS2c5TXzAzc Nv/Q== X-Gm-Message-State: AOAM530+vrTcS6zVRPEDrriefFwh0hqJENNga2T73Tqc9HoRLYwrb0pQ HuJjrhU+T18kByCO03ZUjg== X-Google-Smtp-Source: ABdhPJxstAEhgQaXKaAuFPlgyAyzZjgHKa6/lnHgGk0H6MXAN1HOfoHNKgPecNsaSTpPJLkpHpfD2A== X-Received: by 2002:a6b:be46:: with SMTP id o67mr7181697iof.133.1600869885401; Wed, 23 Sep 2020 07:04:45 -0700 (PDT) Received: from xps15 ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id l6sm10864315ilt.34.2020.09.23.07.04.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Sep 2020 07:04:44 -0700 (PDT) Received: (nullmailer pid 644635 invoked by uid 1000); Wed, 23 Sep 2020 14:04:43 -0000 Date: Wed, 23 Sep 2020 08:04:43 -0600 From: Rob Herring To: Maxime Chevallier Subject: Re: [PATCH v3 1/3] media: dt-bindings: media: Document Rockchip VIP bindings Message-ID: <20200923140443.GA639013@bogus> References: <20200922165535.1356622-1-maxime.chevallier@bootlin.com> <20200922165535.1356622-2-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200922165535.1356622-2-maxime.chevallier@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200923_100446_154319_8E30CC2B X-CRM114-Status: GOOD ( 20.73 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Dafna Hirschfeld , Heiko Stuebner , linux-kernel@vger.kernel.org, Paul Kocialkowski , linux-rockchip@lists.infradead.org, Helen Koike , Ezequiel Garcia , Thomas Petazzoni , Miquel Raynal , Hans Verkuil , Mauro Carvalho Chehab , Robin Murphy , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Tue, Sep 22, 2020 at 06:55:33PM +0200, Maxime Chevallier wrote: > Add a documentation for the Rockchip Camera Interface controller > binding. > > This controller can be found on platforms such as the PX30 or the > RK3288, the PX30 being the only platform supported so far. > > Signed-off-by: Maxime Chevallier > --- > V3 : > - renamed the controller > > .../bindings/media/rockchip-vip.yaml | 100 ++++++++++++++++++ > 1 file changed, 100 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/rockchip-vip.yaml > > diff --git a/Documentation/devicetree/bindings/media/rockchip-vip.yaml b/Documentation/devicetree/bindings/media/rockchip-vip.yaml > new file mode 100644 > index 000000000000..652c46053b29 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/rockchip-vip.yaml > @@ -0,0 +1,100 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/rockchip-vip.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip VIP Camera Interface > + > +maintainers: > + - Maxime Chevallier > + > +description: |- > + Camera Interface for Rockcip platforms > + > +properties: > + compatible: > + const: rockchip,px30-vip > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: ACLK > + - description: HCLK > + - description: PCLK IN > + > + clock-names: > + items: > + - const: aclk > + - const: hclkf > + - const: pclkin > + > + resets: > + items: > + - description: AXI > + - description: AHB > + - description: PCLK IN > + > + reset-names: > + items: > + - const: axi > + - const: ahb > + - const: pclkin > + > + power-domains: > + maxItems: 1 > + description: phandle to the associated power domain Drop description. > + > + # See ./video-interfaces.txt for details > + port: > + type: object > + additionalProperties: false Need a description of the data the port represents. > + > + properties: > + endpoint: You can drop 'endpoint' since you don't have any other endpoint properties. > + type: object > + > + properties: > + remote-endpoint: true > + > + required: > + - remote-endpoint > + > + required: > + - endpoint > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks port should be required. > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + > + vip: vip@ff490000 { > + compatible = "rockchip,px30-vip"; > + reg = <0x0 0xff490000 0x0 0x200>; > + interrupts = ; > + clocks = <&cru ACLK_CIF>, <&cru HCLK_CIF>, <&cru PCLK_CIF>, <&cru SCLK_CIF_OUT>; > + clock-names = "aclk", "hclk", "pclkin"; > + resets = <&cru SRST_CIF_A>, <&cru SRST_CIF_H>, <&cru SRST_CIF_PCLKIN>; > + reset-names = "axi", "ahb", "pclkin"; > + power-domains = <&power PX30_PD_VI>; > + port { Some indentation problems here. > + vip_in: endpoint { > + remote-endpoint = <&tw9900_out>; > + }; > + }; > + }; > +... > -- > 2.25.4 > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76A13C4363D for ; Wed, 23 Sep 2020 14:06:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0B2742137B for ; Wed, 23 Sep 2020 14:06:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="X4TdF3FS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B2742137B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qHd2SSd+Cm2a1wA0EICizzJT6nxfQ00UEFs8E9gW9TQ=; b=X4TdF3FSZAFPan7fli/oCEHkY diBNjwecbiwp5x6oXZ474Jcat8kRM686Y6TTl0j9+qcW1J5dCuSAf/PLzpL6PzZmZwTzv2TwMlyJX FnOTTqkF1sXQp8QvzNBNuRAd55Bv8fMvo+Nxf4FBa+dQNBFOmPAXssMR6e6XD/nxF86lhZ35BkQ+E b66ruVPL8wtguK1yjN5348shCE9GXNOszHb5ApRtc2RvVxhQ1e0PRB76TP92eDIxsESso+3LK/L2h qJXEgH2DFYMpxC83Gcfvq1NTHpQjCcjjRaVCh0pINqWua1Zua9HR2GbLqBlDCoRRTSWZeqnsbod5r AO49icALQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kL5O4-00044F-Ch; Wed, 23 Sep 2020 14:04:48 +0000 Received: from mail-io1-f65.google.com ([209.85.166.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kL5O2-00043Z-33; Wed, 23 Sep 2020 14:04:47 +0000 Received: by mail-io1-f65.google.com with SMTP id z13so23802702iom.8; Wed, 23 Sep 2020 07:04:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/2YIbGPyeDVPWPtl7cPgfN2lbTkXGFerVZnaUBAltaA=; b=nN1Sx2AdwS/SclBzKQpmrI+Gim+E7mqSPTVMsOvWg/F2iYdKiQipKAVlsEqtXwjzQ6 igflx+0RHhahM3pPkpZxmyadp26LN93KWggE+yGFtdqEbBKXpez45ID3TxOWsS8EMZcn 7coyhWJUGK0hFIEFMNNyGH/gD8ho/7ON/55Jrb+jnPTgyJDrbdaXnMqoIwMyREPwpiPi U2omI2080Zp5CJG437VLrZeWItiMlIuV4NJ0+neWrcQOZI+PzlFDKzv9l16YBO5e6EP5 hvvfgZFILwK1G5HMLf4KfJww5bneacPOpYpZxwxhNBwulT8U5Sf9IRt2jJS2c5TXzAzc Nv/Q== X-Gm-Message-State: AOAM530+vrTcS6zVRPEDrriefFwh0hqJENNga2T73Tqc9HoRLYwrb0pQ HuJjrhU+T18kByCO03ZUjg== X-Google-Smtp-Source: ABdhPJxstAEhgQaXKaAuFPlgyAyzZjgHKa6/lnHgGk0H6MXAN1HOfoHNKgPecNsaSTpPJLkpHpfD2A== X-Received: by 2002:a6b:be46:: with SMTP id o67mr7181697iof.133.1600869885401; Wed, 23 Sep 2020 07:04:45 -0700 (PDT) Received: from xps15 ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id l6sm10864315ilt.34.2020.09.23.07.04.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Sep 2020 07:04:44 -0700 (PDT) Received: (nullmailer pid 644635 invoked by uid 1000); Wed, 23 Sep 2020 14:04:43 -0000 Date: Wed, 23 Sep 2020 08:04:43 -0600 From: Rob Herring To: Maxime Chevallier Subject: Re: [PATCH v3 1/3] media: dt-bindings: media: Document Rockchip VIP bindings Message-ID: <20200923140443.GA639013@bogus> References: <20200922165535.1356622-1-maxime.chevallier@bootlin.com> <20200922165535.1356622-2-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200922165535.1356622-2-maxime.chevallier@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200923_100446_154319_8E30CC2B X-CRM114-Status: GOOD ( 20.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Dafna Hirschfeld , Heiko Stuebner , linux-kernel@vger.kernel.org, Paul Kocialkowski , linux-rockchip@lists.infradead.org, Helen Koike , Ezequiel Garcia , Thomas Petazzoni , Miquel Raynal , Hans Verkuil , Mauro Carvalho Chehab , Robin Murphy , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 22, 2020 at 06:55:33PM +0200, Maxime Chevallier wrote: > Add a documentation for the Rockchip Camera Interface controller > binding. > > This controller can be found on platforms such as the PX30 or the > RK3288, the PX30 being the only platform supported so far. > > Signed-off-by: Maxime Chevallier > --- > V3 : > - renamed the controller > > .../bindings/media/rockchip-vip.yaml | 100 ++++++++++++++++++ > 1 file changed, 100 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/rockchip-vip.yaml > > diff --git a/Documentation/devicetree/bindings/media/rockchip-vip.yaml b/Documentation/devicetree/bindings/media/rockchip-vip.yaml > new file mode 100644 > index 000000000000..652c46053b29 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/rockchip-vip.yaml > @@ -0,0 +1,100 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/rockchip-vip.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip VIP Camera Interface > + > +maintainers: > + - Maxime Chevallier > + > +description: |- > + Camera Interface for Rockcip platforms > + > +properties: > + compatible: > + const: rockchip,px30-vip > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: ACLK > + - description: HCLK > + - description: PCLK IN > + > + clock-names: > + items: > + - const: aclk > + - const: hclkf > + - const: pclkin > + > + resets: > + items: > + - description: AXI > + - description: AHB > + - description: PCLK IN > + > + reset-names: > + items: > + - const: axi > + - const: ahb > + - const: pclkin > + > + power-domains: > + maxItems: 1 > + description: phandle to the associated power domain Drop description. > + > + # See ./video-interfaces.txt for details > + port: > + type: object > + additionalProperties: false Need a description of the data the port represents. > + > + properties: > + endpoint: You can drop 'endpoint' since you don't have any other endpoint properties. > + type: object > + > + properties: > + remote-endpoint: true > + > + required: > + - remote-endpoint > + > + required: > + - endpoint > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks port should be required. > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + > + vip: vip@ff490000 { > + compatible = "rockchip,px30-vip"; > + reg = <0x0 0xff490000 0x0 0x200>; > + interrupts = ; > + clocks = <&cru ACLK_CIF>, <&cru HCLK_CIF>, <&cru PCLK_CIF>, <&cru SCLK_CIF_OUT>; > + clock-names = "aclk", "hclk", "pclkin"; > + resets = <&cru SRST_CIF_A>, <&cru SRST_CIF_H>, <&cru SRST_CIF_PCLKIN>; > + reset-names = "axi", "ahb", "pclkin"; > + power-domains = <&power PX30_PD_VI>; > + port { Some indentation problems here. > + vip_in: endpoint { > + remote-endpoint = <&tw9900_out>; > + }; > + }; > + }; > +... > -- > 2.25.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5B2FC4363D for ; Wed, 23 Sep 2020 14:04:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 676EB2220D for ; Wed, 23 Sep 2020 14:04:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600869887; bh=cXyRaF1L2ihiN1wJhVwViUjQm7XHbWY8lkRMEV1OWcI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=pun23cfDGI0b6b9HR8jbREfs80abtpITmRuR0RycLKv/lc5bVkV5Zcf8RCd9BXr3y 7vT5BKSKcRu9JUx2Tb3PpvtWwcE3/2bjFY0AeEfiogI9p1nAMvlH0PUL/UbbLbtKZE m3h+6tN7qd5EywKYbYymF7L+wBeuqCLlgd4d1V1g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726526AbgIWOEq (ORCPT ); Wed, 23 Sep 2020 10:04:46 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:37524 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726234AbgIWOEq (ORCPT ); Wed, 23 Sep 2020 10:04:46 -0400 Received: by mail-io1-f67.google.com with SMTP id y13so23812277iow.4; Wed, 23 Sep 2020 07:04:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/2YIbGPyeDVPWPtl7cPgfN2lbTkXGFerVZnaUBAltaA=; b=lj/u2bxYSUABC/FcqNSJwNRXtJ4TCCsRZNr12+oKTFeP0HuRfg0tWAb49ZZ/TCBkGr 68GP+E33mbgazj6cyg69N/mTaSxHo1dEliRyKl4LRfa8OI1GiKhAKLIP5UzLJybBNElK +tY++BC5aCyPfEWiWBQo1EClLKKXKnfEoq2VLcl6Mu5KokBr21ZEFr9UnqduVUPwKFgq TqsTJTrpAip23U+PokXQhnJBRjz/GFnuZh2w1MPBpDcwYHEvieYZWGmxz/Iqs70iXcZl FfyvJLTu4kochBZ8adhSTbOj4DfDCvCkiNtrHX0j4rUNEn9WKkyqHGbqCxFXCCwr6Hrw b2Pw== X-Gm-Message-State: AOAM533Tf+frFlofEzzMxIs8za/cNBKAAJI6COkGRVU81zIQBGoDYtDU 8BKqg7kORgqPUWn3n/4p3g== X-Google-Smtp-Source: ABdhPJxstAEhgQaXKaAuFPlgyAyzZjgHKa6/lnHgGk0H6MXAN1HOfoHNKgPecNsaSTpPJLkpHpfD2A== X-Received: by 2002:a6b:be46:: with SMTP id o67mr7181697iof.133.1600869885401; Wed, 23 Sep 2020 07:04:45 -0700 (PDT) Received: from xps15 ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id l6sm10864315ilt.34.2020.09.23.07.04.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Sep 2020 07:04:44 -0700 (PDT) Received: (nullmailer pid 644635 invoked by uid 1000); Wed, 23 Sep 2020 14:04:43 -0000 Date: Wed, 23 Sep 2020 08:04:43 -0600 From: Rob Herring To: Maxime Chevallier Cc: Mauro Carvalho Chehab , Robin Murphy , Mark Rutland , Heiko Stuebner , Hans Verkuil , Ezequiel Garcia , Helen Koike , Dafna Hirschfeld , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Thomas Petazzoni , Miquel Raynal , Paul Kocialkowski Subject: Re: [PATCH v3 1/3] media: dt-bindings: media: Document Rockchip VIP bindings Message-ID: <20200923140443.GA639013@bogus> References: <20200922165535.1356622-1-maxime.chevallier@bootlin.com> <20200922165535.1356622-2-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200922165535.1356622-2-maxime.chevallier@bootlin.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Sep 22, 2020 at 06:55:33PM +0200, Maxime Chevallier wrote: > Add a documentation for the Rockchip Camera Interface controller > binding. > > This controller can be found on platforms such as the PX30 or the > RK3288, the PX30 being the only platform supported so far. > > Signed-off-by: Maxime Chevallier > --- > V3 : > - renamed the controller > > .../bindings/media/rockchip-vip.yaml | 100 ++++++++++++++++++ > 1 file changed, 100 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/rockchip-vip.yaml > > diff --git a/Documentation/devicetree/bindings/media/rockchip-vip.yaml b/Documentation/devicetree/bindings/media/rockchip-vip.yaml > new file mode 100644 > index 000000000000..652c46053b29 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/rockchip-vip.yaml > @@ -0,0 +1,100 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/rockchip-vip.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip VIP Camera Interface > + > +maintainers: > + - Maxime Chevallier > + > +description: |- > + Camera Interface for Rockcip platforms > + > +properties: > + compatible: > + const: rockchip,px30-vip > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: ACLK > + - description: HCLK > + - description: PCLK IN > + > + clock-names: > + items: > + - const: aclk > + - const: hclkf > + - const: pclkin > + > + resets: > + items: > + - description: AXI > + - description: AHB > + - description: PCLK IN > + > + reset-names: > + items: > + - const: axi > + - const: ahb > + - const: pclkin > + > + power-domains: > + maxItems: 1 > + description: phandle to the associated power domain Drop description. > + > + # See ./video-interfaces.txt for details > + port: > + type: object > + additionalProperties: false Need a description of the data the port represents. > + > + properties: > + endpoint: You can drop 'endpoint' since you don't have any other endpoint properties. > + type: object > + > + properties: > + remote-endpoint: true > + > + required: > + - remote-endpoint > + > + required: > + - endpoint > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks port should be required. > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + > + vip: vip@ff490000 { > + compatible = "rockchip,px30-vip"; > + reg = <0x0 0xff490000 0x0 0x200>; > + interrupts = ; > + clocks = <&cru ACLK_CIF>, <&cru HCLK_CIF>, <&cru PCLK_CIF>, <&cru SCLK_CIF_OUT>; > + clock-names = "aclk", "hclk", "pclkin"; > + resets = <&cru SRST_CIF_A>, <&cru SRST_CIF_H>, <&cru SRST_CIF_PCLKIN>; > + reset-names = "axi", "ahb", "pclkin"; > + power-domains = <&power PX30_PD_VI>; > + port { Some indentation problems here. > + vip_in: endpoint { > + remote-endpoint = <&tw9900_out>; > + }; > + }; > + }; > +... > -- > 2.25.4 >