From: Kevin Wolf <kwolf@redhat.com>
To: Alberto Garcia <berto@igalia.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH] docs: Document the throttle block filter
Date: Wed, 23 Sep 2020 18:30:26 +0200 [thread overview]
Message-ID: <20200923163026.GH6912@linux.fritz.box> (raw)
In-Reply-To: <w51wo0ka3hb.fsf@maestria.local.igalia.com>
Am 23.09.2020 um 17:59 hat Alberto Garcia geschrieben:
> On Wed 23 Sep 2020 05:55:22 PM CEST, Kevin Wolf wrote:
> >> +A throttle-group can also be created with the -object command line
> >> +option but at the moment there is no way to pass a 'limits' parameter
> >> +that contains a ThrottleLimits structure. The solution is to set the
> >> +individual values directly, like in this example:
> >> +
> >> + -object throttle-group,id=group0,x-iops-total=1000,x-bps-write=2097152
> >> +
> >> +Note however that this not stable API (hence the 'x-' prefixes) and
> >> +can change or disappear in the future.
> >
> > Should we use a stronger wording here, like "will disappear when
> > -object gains support for structured options and enables use of
> > 'limits'"?
>
> Sounds good, I can send v2 if you want, or feel free to change the
> sentence yourself when applying the patch now.
Ok, I just did that and also gave the sentence a verb while at it. ;-)
Kevin
prev parent reply other threads:[~2020-09-23 16:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 17:30 [PATCH] docs: Document the throttle block filter Alberto Garcia
2020-09-23 15:55 ` Kevin Wolf
2020-09-23 15:59 ` Alberto Garcia
2020-09-23 16:30 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200923163026.GH6912@linux.fritz.box \
--to=kwolf@redhat.com \
--cc=berto@igalia.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.