From: "hch@lst.de" <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Huai-Cheng Kuo <hh81478072@gmail.com>, "hch@lst.de" <hch@lst.de>,
Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
"sagi@grimberg.me" <sagi@grimberg.me>
Subject: Re: [PATCH] nvme-core: don't use NVME_NSID_ALL for cmd-effect
Date: Wed, 23 Sep 2020 20:02:29 +0200 [thread overview]
Message-ID: <20200923180229.GA24820@lst.de> (raw)
In-Reply-To: <20200923173544.GA4036936@dhcp-10-100-145-180.wdl.wdc.com>
On Wed, Sep 23, 2020 at 10:35:44AM -0700, Keith Busch wrote:
> On Tue, Sep 22, 2020 at 09:04:36PM +0000, Chaitanya Kulkarni wrote:
> > In the function nvme_get_effects_log() it uses NVME_NSID_ALL which has
> > namespace scope. The command effect log page is controller specific.
> >
> > Replace NVME_NSID_ALL with 0x00 which specifies the controller scope
> > instead of namespace scope.
> >
> > Reported-by: Huai-Cheng Kuo <hh81478072@gmail.com>
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=209287
> > Fixes: be93e87e7802 ("nvme: support for multiple Command Sets Supported and Effects log pages")
>
> This is actually the wrong fixes tag. The code was simply carried
> forward from 84fef62d135b6.
>
> But otherwise, yes, this looks correct.
I've fixed up the fixes tag in the nvme-5.9 branch.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
prev parent reply other threads:[~2020-09-23 18:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200922194938.51845-1-chaitanya.kulkarni@wdc.com>
2020-09-22 21:04 ` [PATCH] nvme-core: don't use NVME_NSID_ALL for cmd-effect Chaitanya Kulkarni
2020-09-23 17:35 ` Keith Busch
2020-09-23 18:02 ` hch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200923180229.GA24820@lst.de \
--to=hch@lst.de \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=hh81478072@gmail.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.