From: Jason Gunthorpe <jgg@nvidia.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Bernard Metzler <BMT@zurich.ibm.com>,
Leon Romanovsky <leon@kernel.org>,
Doug Ledford <dledford@redhat.com>,
Adit Ranadive <aditr@vmware.com>,
"Ariel Elior" <aelior@marvell.com>,
Christian Benvenuti <benve@cisco.com>,
"Dennis Dalessandro" <dennis.dalessandro@intel.com>,
Devesh Sharma <devesh.sharma@broadcom.com>,
Faisal Latif <faisal.latif@intel.com>,
"Gal Pressman" <galpress@amazon.com>,
Lijun Ou <oulijun@huawei.com>, <linux-rdma@vger.kernel.org>,
Michal Kalderon <mkalderon@marvell.com>,
"Mike Marciniszyn" <mike.marciniszyn@intel.com>,
Naresh Kumar PBS <nareshkumar.pbs@broadcom.com>,
Nelson Escobar <neescoba@cisco.com>,
"Parav Pandit" <parav@nvidia.com>,
Parvi Kaustubhi <pkaustub@cisco.com>,
"Potnuri Bharat Teja" <bharat@chelsio.com>,
Selvin Xavier <selvin.xavier@broadcom.com>,
Shiraz Saleem <shiraz.saleem@intel.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>,
VMware PV-Drivers <pv-drivers@vmware.com>,
Weihang Li <liweihang@huawei.com>,
"Wei Hu(Xavier)" <huwei87@hisilicon.com>,
Yishai Hadas <yishaih@nvidia.com>,
Zhu Yanjun <yanjunz@nvidia.com>
Subject: Re: [PATCH rdma-next] RDMA: Explicitly pass in the dma_device to ib_register_device
Date: Wed, 23 Sep 2020 15:35:56 -0300 [thread overview]
Message-ID: <20200923183556.GB9475@nvidia.com> (raw)
In-Reply-To: <20200923053955.GB4809@infradead.org>
On Wed, Sep 23, 2020 at 06:39:55AM +0100, Christoph Hellwig wrote:
> > I wonder if dma_virt_ops ignores the masking.. Still seems best to set
> > it consistently when using dma_virt_ops.
>
> dma_virt_ops doesn't look at the mask. But in retrospective
> dma_virt_ops has been a really bad idea. I'd much rather move the
> handling of non-physical devices back into the RDMA core in the long
> run.
Doesn't that mean we need to put all the ugly IB DMA ops wrappers back
though?
Why was dma_virt_ops such a bad idea?
Jason
next prev parent reply other threads:[~2020-09-23 18:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 8:27 [PATCH rdma-next] RDMA: Explicitly pass in the dma_device to ib_register_device Leon Romanovsky
2020-09-22 8:58 ` Bernard Metzler
2020-09-22 10:14 ` Leon Romanovsky
2020-09-22 14:22 ` Bernard Metzler
2020-09-22 16:22 ` Jason Gunthorpe
2020-09-23 5:39 ` Christoph Hellwig
2020-09-23 18:35 ` Jason Gunthorpe [this message]
2020-09-24 5:53 ` Christoph Hellwig
2020-09-24 6:13 ` Christoph Hellwig
2020-09-24 11:55 ` Jason Gunthorpe
2020-09-24 7:31 ` Parav Pandit
2020-09-22 10:15 ` kernel test robot
2020-09-23 5:38 ` Christoph Hellwig
2020-09-23 6:45 ` Leon Romanovsky
2020-09-23 6:54 ` Christoph Hellwig
2020-09-23 7:10 ` Leon Romanovsky
2020-09-23 7:21 ` Christoph Hellwig
2020-09-23 18:34 ` Jason Gunthorpe
2020-09-24 5:49 ` Christoph Hellwig
2020-09-24 11:49 ` Jason Gunthorpe
2020-10-06 14:29 ` Bart Van Assche
2020-10-06 16:53 ` Jason Gunthorpe
2020-10-06 18:22 ` Bart Van Assche
2020-10-06 18:39 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200923183556.GB9475@nvidia.com \
--to=jgg@nvidia.com \
--cc=BMT@zurich.ibm.com \
--cc=aditr@vmware.com \
--cc=aelior@marvell.com \
--cc=benve@cisco.com \
--cc=bharat@chelsio.com \
--cc=dennis.dalessandro@intel.com \
--cc=devesh.sharma@broadcom.com \
--cc=dledford@redhat.com \
--cc=faisal.latif@intel.com \
--cc=galpress@amazon.com \
--cc=hch@infradead.org \
--cc=huwei87@hisilicon.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=liweihang@huawei.com \
--cc=mike.marciniszyn@intel.com \
--cc=mkalderon@marvell.com \
--cc=nareshkumar.pbs@broadcom.com \
--cc=neescoba@cisco.com \
--cc=oulijun@huawei.com \
--cc=parav@nvidia.com \
--cc=pkaustub@cisco.com \
--cc=pv-drivers@vmware.com \
--cc=selvin.xavier@broadcom.com \
--cc=shiraz.saleem@intel.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
--cc=yanjunz@nvidia.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.