From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/qt5/qt5declarative: remove optional quick module option
Date: Wed, 23 Sep 2020 20:36:59 +0200 [thread overview]
Message-ID: <20200923203659.334cf251@windsurf> (raw)
In-Reply-To: <20200923182300.58950-1-b.bilas@grinn-global.com>
On Wed, 23 Sep 2020 20:23:00 +0200
Bartosz Bilas <b.bilas@grinn-global.com> wrote:
> Since commit [1] we are not able to disable/enable this module
> so let's force to set Qt5 OpenGL support by default
> if it's possible because currently quick's components
> are being built anyway.
>
> This should fix the build errors with qt5location package
> which includes couple of built-in components that require
> OpenGL support [2] when Qt Quick module is detected.
>
> http://autobuild.buildroot.net/results/ddd/ddda7cdb9400f6ca7d548e9b5ada18674fbe42e0/
> http://autobuild.buildroot.net/results/ddb/ddb25ebb591ed6029a7bd4934464171358553936/
>
> [1] https://git.buildroot.net/buildroot/commit/package/qt5/qt5declarative/qt5declarative.mk?id=1bdceb5d735aad5fbf32b35e3a7f573ecb727e20
> [2] https://code.woboq.org/qt5/qtdeclarative/src/quick/scenegraph/coreapi/qsgmaterialshader.h.html#105
>
> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
I am still confused: why should we force something in qt5declarative,
to fix a build issue in qt5location ?
Isn't it a bug in qt5location to use the ->program() method when OpenGL
is disabled, while this method is only available when OpenGL support is
enabled ?
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-09-23 18:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 18:23 [Buildroot] [PATCH] package/qt5/qt5declarative: remove optional quick module option Bartosz Bilas
2020-09-23 18:36 ` Thomas Petazzoni [this message]
2020-09-23 18:49 ` Bartosz Bilas
2022-01-09 14:19 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200923203659.334cf251@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.