All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] boards: chromebook: Move "mksd.sh" out of chromebook snow folder.
Date: Wed, 23 Sep 2020 20:56:17 +0200	[thread overview]
Message-ID: <20200923205617.42ba52fe@windsurf> (raw)
In-Reply-To: <20200921181246.88781-3-bilalwasim676@gmail.com>

Hello Bilal,

Thanks for your contribution!

On Mon, 21 Sep 2020 23:12:45 +0500
Bilal Wasim <bilalwasim676@gmail.com> wrote:

> The same script is used by Chromebook Elm to generate a bootable
> SD / USB image. Therefore, move the script out of the snow folder
> to one level above (boards/chromebook/snow -> boards/chromebook).
> 
> Update the Chrome snow defconfig to reflect the new location of the
> script.
> 
> Signed-off-by: Bilal Wasim <bilalwasim676@gmail.com>
> ---
>  board/chromebook/{snow => }/mksd.sh | 0
>  configs/chromebook_snow_defconfig   | 2 +-
>  2 files changed, 1 insertion(+), 1 deletion(-)
>  rename board/chromebook/{snow => }/mksd.sh (100%)

I fixed up a bit the commit title and commit log, and applied. This
indeed is needed as a pre-requisite to adding the Chromebook Elm
configuration.

Another question: could you see if this mksd.sh script can be dropped
in favor of using genimage to generate the SD card image? Indeed,
genimage now has support for GPT partitions, so I believe it should be
able to generate a working image. Do you think you could have a look at
that ?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2020-09-23 18:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-21 18:12 [Buildroot] [PATCH 0/3] Buildroot support for Chromebook Elm Bilal Wasim
2020-09-21 18:12 ` [Buildroot] [PATCH 1/3] configs: Add default configuration " Bilal Wasim
2020-09-23 19:02   ` Thomas Petazzoni
2020-09-21 18:12 ` [Buildroot] [PATCH 2/3] boards: chromebook: Move "mksd.sh" out of chromebook snow folder Bilal Wasim
2020-09-23 18:56   ` Thomas Petazzoni [this message]
2020-09-21 18:12 ` [Buildroot] [PATCH 3/3] boards: chromebook: Add support of Chromebook Elm Bilal Wasim
2020-09-23 19:08   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200923205617.42ba52fe@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.