From: Jonathan Cameron <jic23@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: ssp: use PLATFORM_DEVID_NONE
Date: Wed, 23 Sep 2020 21:32:52 +0100 [thread overview]
Message-ID: <20200923213252.25e19944@archlinux> (raw)
In-Reply-To: <20200921204939.20341-1-krzk@kernel.org>
On Mon, 21 Sep 2020 22:49:39 +0200
Krzysztof Kozlowski <krzk@kernel.org> wrote:
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
> - it brings some meaning,
> - it might point attention why auto device ID was not used.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied to the togreg branch of iio.git.
Thanks,
Jonathan
> ---
> drivers/iio/common/ssp_sensors/ssp_dev.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/common/ssp_sensors/ssp_dev.c b/drivers/iio/common/ssp_sensors/ssp_dev.c
> index a94dbcf491ce..1aee87100038 100644
> --- a/drivers/iio/common/ssp_sensors/ssp_dev.c
> +++ b/drivers/iio/common/ssp_sensors/ssp_dev.c
> @@ -503,7 +503,8 @@ static int ssp_probe(struct spi_device *spi)
> return -ENODEV;
> }
>
> - ret = mfd_add_devices(&spi->dev, -1, sensorhub_sensor_devs,
> + ret = mfd_add_devices(&spi->dev, PLATFORM_DEVID_NONE,
> + sensorhub_sensor_devs,
> ARRAY_SIZE(sensorhub_sensor_devs), NULL, 0, NULL);
> if (ret < 0) {
> dev_err(&spi->dev, "mfd add devices fail\n");
prev parent reply other threads:[~2020-09-23 20:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 20:49 [PATCH] iio: ssp: use PLATFORM_DEVID_NONE Krzysztof Kozlowski
2020-09-23 20:32 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200923213252.25e19944@archlinux \
--to=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=krzk@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.