From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: u-boot@lists.denx.de
Subject: [PATCH 1/1] fs/squashfs: parameter check sqfs_read_metablock()
Date: Wed, 23 Sep 2020 21:49:41 +0200 [thread overview]
Message-ID: <20200923214941.5a39daf1@windsurf> (raw)
In-Reply-To: <20200923191351.33474-1-xypron.glpk@gmx.de>
On Wed, 23 Sep 2020 21:13:51 +0200
Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> We should check if the incoming parameter file_mapping is not NULL instead
> of checking after adding an offset.
>
> Reported-by: Coverity CID 307210
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
However, I wonder if this check is really useful. sqfs_read_metablock()
is an internal function, so it should be up to the callers to make sure
that they don't pass a NULL file_mapping argument.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-09-23 19:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 19:13 [PATCH 1/1] fs/squashfs: parameter check sqfs_read_metablock() Heinrich Schuchardt
2020-09-23 19:49 ` Thomas Petazzoni [this message]
2020-09-23 20:36 ` Heinrich Schuchardt
2020-09-30 12:50 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200923214941.5a39daf1@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.