Re: [PATCH v6 bpf-next 2/6] bpf: move to generic BTF show support, apply it to seq files/strings

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2342 bytes --]

Hi Alan,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on bpf-next/master]

url:    https://github.com/0day-ci/linux/commits/Alan-Maguire/bpf-add-helpers-to-support-BTF-based-kernel-data-display/20200924-015115
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   kernel/bpf/btf.c: In function 'btf_type_seq_show_flags':
>> kernel/bpf/btf.c:5325:14: warning: assignment left-hand side might be a candidate for a format attribute [-Wsuggest-attribute=format]
    5325 |  sseq.showfn = btf_seq_show;
         |              ^
   kernel/bpf/btf.c: In function 'btf_type_snprintf_show':
   kernel/bpf/btf.c:5379:24: warning: assignment left-hand side might be a candidate for a format attribute [-Wsuggest-attribute=format]
    5379 |  ssnprintf.show.showfn = btf_snprintf_show;
         |                        ^

# https://github.com/0day-ci/linux/commit/f8bb50c0c9cdac7a730f35d0e579c25d0bc3947f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Alan-Maguire/bpf-add-helpers-to-support-BTF-based-kernel-data-display/20200924-015115
git checkout f8bb50c0c9cdac7a730f35d0e579c25d0bc3947f
vim +5325 kernel/bpf/btf.c

  5318	
  5319	static int btf_type_seq_show_flags(const struct btf *btf, u32 type_id,
  5320					   void *obj, struct seq_file *m, u64 flags)
  5321	{
  5322		struct btf_show sseq;
  5323	
  5324		sseq.target = m;
> 5325		sseq.showfn = btf_seq_show;
  5326		sseq.flags = flags;
  5327	
  5328		btf_type_show(btf, type_id, obj, &sseq);
  5329	
  5330		return sseq.state.status;
  5331	}
  5332	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 65137 bytes --]