From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Eric Sandeen <sandeen@redhat.com>,
xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs_repair: coordinate parallel updates to the rt bitmap
Date: Thu, 24 Sep 2020 07:19:11 +0100 [thread overview]
Message-ID: <20200924061911.GB27289@infradead.org> (raw)
In-Reply-To: <20200924060001.GZ7955@magnolia>
On Wed, Sep 23, 2020 at 11:00:01PM -0700, Darrick J. Wong wrote:
> > > + struct aglock *lock = &ag_locks[(signed)NULLAGNUMBER];
> >
> > Err, what is this weird cast doing here?
>
> Well.... ag_locks is allocated with length ag_locks[agcount + 1], and
> then the pointer is incremented so that ag_locks[-1] is the rt lock.
At least in the for-next branch it isn't:
ag_locks = calloc(mp->m_sb.sb_agcount, sizeof(struct aglock));
More importantly, I can't even find other uses of ag_locks for the
RT subvolume. Is this hidden in one of your series?
Either way I think a separate lock for the RT subvolume would make a
whole lot more sense.
next prev parent reply other threads:[~2020-09-24 6:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 18:24 [PATCH] xfs_repair: coordinate parallel updates to the rt bitmap Darrick J. Wong
2020-09-24 5:40 ` Christoph Hellwig
2020-09-24 6:00 ` Darrick J. Wong
2020-09-24 6:19 ` Christoph Hellwig [this message]
2020-09-24 15:06 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924061911.GB27289@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.