From: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] cmake: ignore generated files
Date: Thu, 24 Sep 2020 17:34:37 +0700 [thread overview]
Message-ID: <20200924103437.GA18952@danh.dev> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2009232224410.5061@tvgsbejvaqbjf.bet>
Hi Dscho,
On 2020-09-23 22:27:17+0200, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> > ... the above sounds like the argument concentrates too much on
> > where the build directory is (i.e. between "in place" and "a
> > throw-away directory next door"), which sounds like much smaller
> > point compared to the other things that needs to be improved in the
> > VS users. And making a choice against what is recommended as best
> > practice...? I dunno.
>
> All I want is for the CMake support to be easier to use, yet we go in the
> opposite direction: instead of allowing to use CMake under more
> circumstances (which actually *works*, we just don't have the appropriate
> patterns in our `.gitignore` yet to avoid adding and committing the
> generated files), we now seem to intend to require a separate build
> directory.
I've left Windows development land for a long time.
So, please take below discussion with grain of salt.
When I was there, CMake Users on Windows mostly used CMake-GUI to
generate build system for CMake since running CMake as CLI in Windows
takes too much hassle.
When I was there, CMake-GUI shows the option to choose build directories
explicitly, and whenever the source directories changed, the build
directories also changed, with some [-/]build added into sourcedir [1]
I heard that nowaday, CMake is supported natively with MSVC, I don't
know what is the default option when using CMake with MSVC, but from
the history of MSVC always supports building out of tree, and
information for Microsoft Docs [2]:
Click the Show All Files button at the top of Solution
Explorer to see all the CMake-generated output in the
out/build/<config> folders.
I think the default UX with CMake on Windows is building project out
of tree.
> That's the opposite direction of making things more convenient for Visual
> Studio users.
So, I don't think we would provide them more convenient with this change.
1: https://cmake.org/runningcmake/
2: https://docs.microsoft.com/en-us/cpp/build/cmake-projects-in-visual-studio?view=vs-2019
--
Danh
next prev parent reply other threads:[~2020-09-24 10:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 20:37 [PATCH] cmake: ignore generated files Johannes Schindelin via GitGitGadget
2020-09-17 21:49 ` Junio C Hamano
2020-09-18 13:11 ` Johannes Schindelin
2020-09-18 15:28 ` Junio C Hamano
2020-09-18 15:50 ` Đoàn Trần Công Danh
2020-09-18 16:21 ` Junio C Hamano
2020-09-19 0:40 ` Đoàn Trần Công Danh
2020-09-19 0:50 ` Junio C Hamano
2020-09-20 17:37 ` Johannes Schindelin
2020-09-23 15:59 ` Junio C Hamano
2020-09-23 20:27 ` Johannes Schindelin
2020-09-23 20:38 ` Junio C Hamano
2020-09-25 6:40 ` Johannes Schindelin
2020-09-24 10:34 ` Đoàn Trần Công Danh [this message]
2020-09-25 5:02 ` Johannes Schindelin
2020-09-20 17:15 ` Johannes Schindelin
2020-09-21 22:46 ` Junio C Hamano
2020-09-23 13:08 ` Johannes Schindelin
2020-09-24 9:19 ` SZEDER Gábor
2020-09-24 17:11 ` Junio C Hamano
2020-09-23 17:47 ` Junio C Hamano
2020-09-23 17:53 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924103437.GA18952@danh.dev \
--to=congdanhqx@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.