All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Linus Walleij <linus.walleij@linaro.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Kent Gibson <warthog618@gmail.com>
Cc: linux-gpio@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: [PATCH 1/9] lib: string_helpers: provide kfree_strarray()
Date: Thu, 24 Sep 2020 13:38:34 +0200	[thread overview]
Message-ID: <20200924113842.11670-2-brgl@bgdev.pl> (raw)
In-Reply-To: <20200924113842.11670-1-brgl@bgdev.pl>

From: Bartosz Golaszewski <bgolaszewski@baylibre.com>

There's a common pattern of dynamically allocating an array of char
pointers and then also dynamically allocating each string in this
array. Provide a helper for freeing such a string array with one call.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
 include/linux/string_helpers.h |  2 ++
 lib/string_helpers.c           | 22 ++++++++++++++++++++++
 2 files changed, 24 insertions(+)

diff --git a/include/linux/string_helpers.h b/include/linux/string_helpers.h
index 86f150c2a6b6..55b25120a1c6 100644
--- a/include/linux/string_helpers.h
+++ b/include/linux/string_helpers.h
@@ -94,4 +94,6 @@ char *kstrdup_quotable(const char *src, gfp_t gfp);
 char *kstrdup_quotable_cmdline(struct task_struct *task, gfp_t gfp);
 char *kstrdup_quotable_file(struct file *file, gfp_t gfp);
 
+void kfree_strarray(char **str_array, size_t num_str);
+
 #endif
diff --git a/lib/string_helpers.c b/lib/string_helpers.c
index 963050c0283e..56c01ec8a076 100644
--- a/lib/string_helpers.c
+++ b/lib/string_helpers.c
@@ -649,3 +649,25 @@ char *kstrdup_quotable_file(struct file *file, gfp_t gfp)
 	return pathname;
 }
 EXPORT_SYMBOL_GPL(kstrdup_quotable_file);
+
+/**
+ * kfree_strarray - free a number of dynamically allocated strings contained
+ *                  in an array and the array itself
+ *
+ * @str_array: Dynamically allocated array of strings to free. If NULL - the
+ *             function does nothing.
+ * @num_str: Number of strings (starting from the beginning of the array) to
+ *           free.
+ *
+ * Passing a non-null str_array and num_str == 0 as well as NULL str_array and
+ * num_str == 0 are valid use-cases.
+ */
+void kfree_strarray(char **str_array, size_t num_str)
+{
+	unsigned int i;
+
+	for (i = 0; i < num_str; i++)
+		kfree(str_array[i]);
+	kfree(str_array);
+}
+EXPORT_SYMBOL_GPL(kfree_strarray);
-- 
2.26.1


  reply	other threads:[~2020-09-24 11:39 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-24 11:38 [PATCH 0/9] gpio: mockup: refactoring + documentation Bartosz Golaszewski
2020-09-24 11:38 ` Bartosz Golaszewski [this message]
2020-09-25  8:48   ` [PATCH 1/9] lib: string_helpers: provide kfree_strarray() Andy Shevchenko
2020-09-25 11:32     ` Bartosz Golaszewski
2020-09-25 12:28       ` Andy Shevchenko
2020-09-24 11:38 ` [PATCH 2/9] Documentation: gpio: add documentation for gpio-mockup Bartosz Golaszewski
2020-09-24 11:38 ` [PATCH 3/9] gpio: mockup: drop unneeded includes Bartosz Golaszewski
2020-09-24 11:38 ` [PATCH 4/9] gpio: mockup: use KBUILD_MODNAME Bartosz Golaszewski
2020-09-24 11:38 ` [PATCH 5/9] gpio: mockup: use pr_fmt() Bartosz Golaszewski
2020-09-24 16:04   ` Joe Perches
2020-09-24 11:38 ` [PATCH 6/9] gpio: mockup: remove unneeded return statement Bartosz Golaszewski
2020-09-24 11:38 ` [PATCH 7/9] gpio: mockup: pass the chip label as device property Bartosz Golaszewski
2020-09-25  9:00   ` Andy Shevchenko
2020-09-24 11:38 ` [PATCH 8/9] gpio: mockup: use the generic 'gpio-line-names' property Bartosz Golaszewski
2020-09-25  9:03   ` Andy Shevchenko
2020-09-25 11:40     ` Bartosz Golaszewski
2020-09-25 12:30       ` Andy Shevchenko
2020-09-28  8:44         ` Bartosz Golaszewski
2020-09-28  9:11           ` Andy Shevchenko
2020-09-28  9:58             ` Bartosz Golaszewski
2020-09-24 11:38 ` [PATCH 9/9] gpio: mockup: refactor the module init function Bartosz Golaszewski
2020-09-25  9:04 ` [PATCH 0/9] gpio: mockup: refactoring + documentation Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200924113842.11670-2-brgl@bgdev.pl \
    --to=brgl@bgdev.pl \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=corbet@lwn.net \
    --cc=linus.walleij@linaro.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=warthog618@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.