From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E47A6C4363D for ; Thu, 24 Sep 2020 12:41:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 73EF1206D9 for ; Thu, 24 Sep 2020 12:41:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sVp5ap9x"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="A3sI1Nbs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 73EF1206D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zxAt0r+nrdd/4cfxVDohiLeHhr3p9sNlhOA2VHogmpA=; b=sVp5ap9xw4ZBF+7BG7Ua8WvgT wZ7h0uUxKhT/G3hoLvGYDxMUGiQrE37mlJGKPPAnWkjaD7BF7DHvFQnfXdsNb29YnqMOWtr1tdGcT bPVL6l7MwQ89D73zw+2tqPZUnlcAFzpErGCwRUw6s/lqCQC6jt3BKw9BdubuU8cR9Jsd8fhkKI0e6 +F/MTv3lRYbIsn+HToW0oN4tCixcSzPNGS3gm6Ka136Jkp1vBniG1T7GkRDGUvIePZbfpLO8zl3gL UipiBY+hVPkj31WuyWVguGsc1LqJdfddSCX+XJBP+xMXbjP68HIXblglcpURvlPUZ04lPoL/FrlMw /BD6esdpA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLQXI-0004HG-W1; Thu, 24 Sep 2020 12:39:45 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLQXG-0004Fw-D1 for linux-arm-kernel@lists.infradead.org; Thu, 24 Sep 2020 12:39:43 +0000 Received: by mail-wm1-x343.google.com with SMTP id e11so6723860wme.0 for ; Thu, 24 Sep 2020 05:39:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=zWTsbwqu5u31iU7OL0QOQ6Z5T6BsEEYTr2C+q8i32Ms=; b=A3sI1Nbs6OeluEErpb9S8ydWCHVOVgifN0EiclOoqeLwIYvSfvt80rDHa2tSUUxPbm DompAts1y/IGboXsPK6hEpVV1x+4RxKvesJ5bvpqOx3EC70hxN69do3zCuOY3ae0F8Pw fwTPyGq7r75jillegw2Snmd0x8WaPSPciNJ8gGY6KFDr+w0qs0QDf6/AMzaxfzyRvadk XhEbAPbtdVP0tcC5ZM7NSry6RYvnaiyv+I72bwo1R4xV0XWlifd2EmNVR6fcNgnaWlZ1 Qk1ZX6pzTBYCI2ZRLX3qvn7h+k4BX/pDDtY8JoEo8v4cr+oC8aLxLQ1Kt5prI7tWrnCd mCzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=zWTsbwqu5u31iU7OL0QOQ6Z5T6BsEEYTr2C+q8i32Ms=; b=fdGpRp01kqI6rmmLzVu2zR4+/1SLUPo7M+SLobj/KlBuwZoLb/Y7NsRHyxQN8S5kog U16o53HxXSrn2PAB0aDi97VqMIN1eL457iMfkc6G/VtGzEJG2Io0/irhXzWfQLSJBm+Y wEcccyeWhTnH5mlvnuYKpqZul0PwKuEftIe5N3OlRB8TlJNZ3rxjpfA8DN0oFfxXUmOY 1Wz6P0LpJqkfozLM/x2/T8M5UsL1usKODtMIZV8mxBjDheJcoewYrqOHUQe3VKnSZ496 PUd4Sf+53832Mb1SBpdhMeaKxY4vWph0gjb9rM4oyocJAWPD+oLsjCTAj41wSuknKOUu uHfQ== X-Gm-Message-State: AOAM530A2IGHKCjfAQ0B4y2wA83KrKjmleZNQ0rT+S2yyBOP5wh1rb49 3yEtdrYuyS42YNpII0Z2G0Fx90J4pbYz2g== X-Google-Smtp-Source: ABdhPJzRewLMSesYUgH51L0Nb4lc9SwRXVKb/C8N6/c4ECvtlaXsKtencSQUQBWbkrMIfs03Twyikg== X-Received: by 2002:a1c:f612:: with SMTP id w18mr4443877wmc.47.1600951179539; Thu, 24 Sep 2020 05:39:39 -0700 (PDT) Received: from dell ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id u8sm3169859wmj.45.2020.09.24.05.39.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2020 05:39:38 -0700 (PDT) Date: Thu, 24 Sep 2020 13:39:36 +0100 From: Lee Jones To: Marc Zyngier Subject: Re: [PATCH] mfd: syscon: Don't free allocated name for regmap_config Message-ID: <20200924123936.GJ4678@dell> References: <20200903160237.932818-1-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200903160237.932818-1-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200924_083942_456883_84B0C97B X-CRM114-Status: GOOD ( 16.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-team@android.com, Arnd Bergmann , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAwMyBTZXAgMjAyMCwgTWFyYyBaeW5naWVyIHdyb3RlOgoKPiBUaGUgbmFtZSBhbGxv Y2F0ZWQgZm9yIHRoZSByZWdtYXBfY29uZmlnIHN0cnVjdHVyZSBpcyBmcmVlZAo+IHByZXR0eSBl YXJseSwgcmlnaHQgYWZ0ZXIgdGhlIHJlZ2lzdHJhdGlvbiBvZiB0aGUgTU1JTyByZWdpb24uCj4g Cj4gVW5mb3J0dW5hdGVseSwgdGhhdCBkb2Vzbid0IGZvbGxvdyB0aGUgbGlmZSBjeWNsZSB0aGF0 IGRlYnVnZnMKPiBleHBlY3RzLCBhcyBpdCBjYW4gYWNjZXNzIHRoZSBuYW1lIGZpZWxkIGxvbmcg YWZ0ZXIgdGhlIGZyZWUKPiBoYXMgb2NjdXJlZC4KPiAKPiBNb3ZlIHRoZSBmcmVlIG9uIHRoZSBl cnJvciBwYXRoLCBhbmQga2VlcCBpdCBmb3JldmVyIG90aGVyd2lzZS4KPiAKPiBGaXhlczogZTE1 ZDdmMmI4MWQyICgibWZkOiBzeXNjb246IFVzZSBhIHVuaXF1ZSBuYW1lIHdpdGggcmVnbWFwX2Nv bmZpZyIpCj4gU2lnbmVkLW9mZi1ieTogTWFyYyBaeW5naWVyIDxtYXpAa2VybmVsLm9yZz4KPiAt LS0KPiAgZHJpdmVycy9tZmQvc3lzY29uLmMgfCAyICstCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGlu c2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKRml4ZWQgdGhlIHNwZWxsaW5nIG1pc3Rha2UgYW5k IGFwcGxpZWQsIHRoYW5rcy4KCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10KU2VuaW9yIFRlY2hu aWNhbCBMZWFkIC0gRGV2ZWxvcGVyIFNlcnZpY2VzCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNl IHNvZnR3YXJlIGZvciBBcm0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIg fCBCbG9nCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44294C4363D for ; Thu, 24 Sep 2020 12:39:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE4FF235FD for ; Thu, 24 Sep 2020 12:39:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="A3sI1Nbs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727790AbgIXMjl (ORCPT ); Thu, 24 Sep 2020 08:39:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727570AbgIXMjl (ORCPT ); Thu, 24 Sep 2020 08:39:41 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFD49C0613CE for ; Thu, 24 Sep 2020 05:39:40 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id w2so3385867wmi.1 for ; Thu, 24 Sep 2020 05:39:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=zWTsbwqu5u31iU7OL0QOQ6Z5T6BsEEYTr2C+q8i32Ms=; b=A3sI1Nbs6OeluEErpb9S8ydWCHVOVgifN0EiclOoqeLwIYvSfvt80rDHa2tSUUxPbm DompAts1y/IGboXsPK6hEpVV1x+4RxKvesJ5bvpqOx3EC70hxN69do3zCuOY3ae0F8Pw fwTPyGq7r75jillegw2Snmd0x8WaPSPciNJ8gGY6KFDr+w0qs0QDf6/AMzaxfzyRvadk XhEbAPbtdVP0tcC5ZM7NSry6RYvnaiyv+I72bwo1R4xV0XWlifd2EmNVR6fcNgnaWlZ1 Qk1ZX6pzTBYCI2ZRLX3qvn7h+k4BX/pDDtY8JoEo8v4cr+oC8aLxLQ1Kt5prI7tWrnCd mCzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=zWTsbwqu5u31iU7OL0QOQ6Z5T6BsEEYTr2C+q8i32Ms=; b=ByNwrevwruyO4FajLBTzbAvxhM3UtxUujJIn/hf1kQAaUUC80D++aW8Ad5yhX8YQh7 ZC5uoPgJdfpXm97E5AsYskcVTV/h4XFsbfWbc8HAUWzFrj3pre0dkwZKbQJgV2+iE4Qz F0psJ/4c0XFxjVwon1/NgeVeip581i9j2HktsTR0A0VdaMHUTOdTjcs0p1FNKjKfXmru L0V+Ns9vDSjOGyqkZ3PvKOweBwhXlswL3vq77LK5xchKvGGiSa4Ild3FzE6kEjc7oP6a 2bmOif6WogezZrWgqAVtcwfi9I04jv9w11Ssy0gJqg979hM+TlTFj2xi8KBxhGBpj0AU u8ZQ== X-Gm-Message-State: AOAM5333tinfgJD6bVMINmkCXtN/y9/U3R/jnB+YgE3+XT7PTTQM1vLH yJhpPMeuQ70Ol5jykxIDGAK/Yw== X-Google-Smtp-Source: ABdhPJzRewLMSesYUgH51L0Nb4lc9SwRXVKb/C8N6/c4ECvtlaXsKtencSQUQBWbkrMIfs03Twyikg== X-Received: by 2002:a1c:f612:: with SMTP id w18mr4443877wmc.47.1600951179539; Thu, 24 Sep 2020 05:39:39 -0700 (PDT) Received: from dell ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id u8sm3169859wmj.45.2020.09.24.05.39.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2020 05:39:38 -0700 (PDT) Date: Thu, 24 Sep 2020 13:39:36 +0100 From: Lee Jones To: Marc Zyngier Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Suman Anna , kernel-team@android.com Subject: Re: [PATCH] mfd: syscon: Don't free allocated name for regmap_config Message-ID: <20200924123936.GJ4678@dell> References: <20200903160237.932818-1-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200903160237.932818-1-maz@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 03 Sep 2020, Marc Zyngier wrote: > The name allocated for the regmap_config structure is freed > pretty early, right after the registration of the MMIO region. > > Unfortunately, that doesn't follow the life cycle that debugfs > expects, as it can access the name field long after the free > has occured. > > Move the free on the error path, and keep it forever otherwise. > > Fixes: e15d7f2b81d2 ("mfd: syscon: Use a unique name with regmap_config") > Signed-off-by: Marc Zyngier > --- > drivers/mfd/syscon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Fixed the spelling mistake and applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog