From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Joel Becker <jlbec@evilplan.org>, Christoph Hellwig <hch@lst.de>
Cc: linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: [PATCH 07/12] samples: configfs: replace simple_strtoul() with kstrtoint()
Date: Thu, 24 Sep 2020 14:45:21 +0200 [thread overview]
Message-ID: <20200924124526.17365-8-brgl@bgdev.pl> (raw)
In-Reply-To: <20200924124526.17365-1-brgl@bgdev.pl>
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
simple_strtoul() is deprecated. Use kstrtoint().
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
samples/configfs/configfs_sample.c | 29 +++++++++--------------------
1 file changed, 9 insertions(+), 20 deletions(-)
diff --git a/samples/configfs/configfs_sample.c b/samples/configfs/configfs_sample.c
index 3e6f0e0b0f72..d89a1ffea620 100644
--- a/samples/configfs/configfs_sample.c
+++ b/samples/configfs/configfs_sample.c
@@ -14,6 +14,7 @@
#include <linux/configfs.h>
#include <linux/init.h>
+#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/slab.h>
@@ -61,17 +62,11 @@ static ssize_t childless_storeme_store(struct config_item *item,
const char *page, size_t count)
{
struct childless *childless = to_childless(item);
- unsigned long tmp;
- char *p = (char *) page;
-
- tmp = simple_strtoul(p, &p, 10);
- if (!p || (*p && (*p != '\n')))
- return -EINVAL;
-
- if (tmp > INT_MAX)
- return -ERANGE;
+ int ret;
- childless->storeme = tmp;
+ ret = kstrtoint(page, 10, &childless->storeme);
+ if (ret)
+ return ret;
return count;
}
@@ -144,17 +139,11 @@ static ssize_t simple_child_storeme_store(struct config_item *item,
const char *page, size_t count)
{
struct simple_child *simple_child = to_simple_child(item);
- unsigned long tmp;
- char *p = (char *) page;
-
- tmp = simple_strtoul(p, &p, 10);
- if (!p || (*p && (*p != '\n')))
- return -EINVAL;
-
- if (tmp > INT_MAX)
- return -ERANGE;
+ int ret;
- simple_child->storeme = tmp;
+ ret = kstrtoint(page, 10, &simple_child->storeme);
+ if (ret)
+ return ret;
return count;
}
--
2.17.1
next prev parent reply other threads:[~2020-09-24 12:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 12:45 [PATCH 00/12] samples: configfs: refactor the configfs sample code Bartosz Golaszewski
2020-09-24 12:45 ` [PATCH 01/12] MAINTAINERS: add the sample directory to the configfs entry Bartosz Golaszewski
2020-09-24 12:45 ` [PATCH 02/12] samples: configfs: order includes alphabetically Bartosz Golaszewski
2020-10-07 13:43 ` Christoph Hellwig
2020-10-08 13:23 ` Bartosz Golaszewski
2020-10-08 14:05 ` Christoph Hellwig
2020-09-24 12:45 ` [PATCH 03/12] samples: configfs: remove redundant newlines Bartosz Golaszewski
2020-09-24 12:45 ` [PATCH 04/12] samples: configfs: drop unnecessary ternary operators Bartosz Golaszewski
2020-09-24 12:45 ` [PATCH 05/12] samples: configfs: improve alignment of broken lines Bartosz Golaszewski
2020-10-07 13:44 ` Christoph Hellwig
2020-09-24 12:45 ` [PATCH 06/12] samples: configfs: fix alignment in item struct Bartosz Golaszewski
2020-09-24 12:45 ` Bartosz Golaszewski [this message]
2020-09-24 12:45 ` [PATCH 08/12] samples: configfs: don't reinitialize variables which are already zeroed Bartosz Golaszewski
2020-09-24 12:45 ` [PATCH 09/12] samples: configfs: prefer sizeof(*var) to sizeof(struct var_type) Bartosz Golaszewski
2020-10-07 13:46 ` Christoph Hellwig
2020-09-24 12:45 ` [PATCH 10/12] samples: configfs: consolidate local variables of the same type Bartosz Golaszewski
2020-09-24 12:45 ` [PATCH 11/12] samples: configfs: don't use spaces before tabs Bartosz Golaszewski
2020-09-24 12:45 ` [PATCH 12/12] samples: configfs: prefer pr_err() over bare printk(KERN_ERR Bartosz Golaszewski
2020-10-06 10:40 ` [PATCH 00/12] samples: configfs: refactor the configfs sample code Bartosz Golaszewski
2020-10-07 13:46 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924124526.17365-8-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=bgolaszewski@baylibre.com \
--cc=hch@lst.de \
--cc=jlbec@evilplan.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.