From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peilin Ye Date: Thu, 24 Sep 2020 14:25:25 +0000 Subject: Re: [PATCH 0/3] Prevent out-of-bounds access for built-in font data buffers Message-Id: <20200924142525.GA879276@PWN> List-Id: References: <0000000000006b9e8d059952095e@google.com> <20200924140937.GA749208@kroah.com> In-Reply-To: <20200924140937.GA749208@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Greg Kroah-Hartman Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , Jiri Slaby , syzkaller-bugs@googlegroups.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel-mentees@lists.linuxfoundation.org On Thu, Sep 24, 2020 at 04:09:37PM +0200, Greg Kroah-Hartman wrote: > On Thu, Sep 24, 2020 at 09:38:22AM -0400, Peilin Ye wrote: > > Peilin Ye (3): > > fbdev, newport_con: Move FONT_EXTRA_WORDS macros into linux/font.h > > Fonts: Support FONT_EXTRA_WORDS macros for built-in fonts > > fbcon: Fix global-out-of-bounds read in fbcon_get_font() > > > > drivers/video/console/newport_con.c | 7 +------ > > drivers/video/fbdev/core/fbcon.c | 12 ++++++++++++ > > drivers/video/fbdev/core/fbcon.h | 7 ------- > > drivers/video/fbdev/core/fbcon_rotate.c | 1 + > > drivers/video/fbdev/core/tileblit.c | 1 + > > include/linux/font.h | 13 +++++++++++++ > > lib/fonts/font_10x18.c | 9 ++++----- > > lib/fonts/font_6x10.c | 9 +++++---- > > lib/fonts/font_6x11.c | 9 ++++----- > > lib/fonts/font_7x14.c | 9 ++++----- > > lib/fonts/font_8x16.c | 9 ++++----- > > lib/fonts/font_8x8.c | 9 ++++----- > > lib/fonts/font_acorn_8x8.c | 9 ++++++--- > > lib/fonts/font_mini_4x6.c | 8 ++++---- > > lib/fonts/font_pearl_8x8.c | 9 ++++----- > > lib/fonts/font_sun12x22.c | 9 ++++----- > > lib/fonts/font_sun8x16.c | 7 ++++--- > > lib/fonts/font_ter16x32.c | 9 ++++----- > > 18 files changed, 79 insertions(+), 67 deletions(-) > > Gotta love going backwards in arrays :) > > Nice work, whole series is: > > Reviewed-by: Greg Kroah-Hartman Thank you for reviewing it! Peilin Ye From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB362C2D0E2 for ; Thu, 24 Sep 2020 14:25:39 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 179FD206B8 for ; Thu, 24 Sep 2020 14:25:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lZ2IHLOv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 179FD206B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 7795E2E0FE; Thu, 24 Sep 2020 14:25:38 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lwSZjP-LwNKa; Thu, 24 Sep 2020 14:25:37 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 31FA7228AC; Thu, 24 Sep 2020 14:25:37 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 232E3C0859; Thu, 24 Sep 2020 14:25:37 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id D4A3FC0051 for ; Thu, 24 Sep 2020 14:25:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id C95A586B90 for ; Thu, 24 Sep 2020 14:25:35 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vlYok4pZCNJT for ; Thu, 24 Sep 2020 14:25:35 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by whitealder.osuosl.org (Postfix) with ESMTPS id 1CEC386B78 for ; Thu, 24 Sep 2020 14:25:35 +0000 (UTC) Received: by mail-pl1-f193.google.com with SMTP id m15so1753284pls.8 for ; Thu, 24 Sep 2020 07:25:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BhjXs0X1T6fyEGbqATV3iAKCYDUTserBVGQfsds99Q8=; b=lZ2IHLOvUlSzofjJzppCZLACHPsTpIecrUUi9yAxP/p2GvombkArlU1xTZQhAGnnjK g2GebQ/478ooEg8r5LWavf20tfUHnei0vBc51EApwiUQoShSyH+V6dwxfT2qcl8s0iSS /qXQEn0URynfGfyTDlit78GesAM221oMd2R25Hi9nVYzscs9+9GmmaflqLcEp5ACCvT/ q2mNkYlPDdTJPfqnwcNgEyRQxXy4CapItbbfWtij9i+M1fCht3TSleY5p+Zb5vH+e6cl tghZdra5yDIl1eJHDG5d1wXzyMT90qrJwYHZO22BNM6r+7AMsLHgWTizzxRn/54oshsA YJOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BhjXs0X1T6fyEGbqATV3iAKCYDUTserBVGQfsds99Q8=; b=EjKAGJmSvtDcXoROLXVvHeqPLfi7BA9SBjh4bu3JcXbrTfYbBC3ZbOVSTIrJ/9PHnU 7dCKRweNFQryPachWNI5z2Heq5x5hsmOEoXnb5ed2WNPKJ5WInAerPIDUMV/NvurP9Rm zKB4GDacZwOqRhenR/CeLP+ajFEZCbemnLuTAqjiHw3fG/hCUbGyUSCD5+1kEp2mkbXn 4vjum1HWWKj1iLQvKgUEwy/2Gg85YK8uG5yoVzosOPNkCiZ3A8goJeShVrLJ2NpFLHLG AxqfxGEiyiykskFNi79/ePcL0sePcBmdu23CZqswmlotpi1J5B4iBvKJP/m1i8qCwsAJ YCkg== X-Gm-Message-State: AOAM530k5IbXOA0UTS7hNlhJrSdaapiFCV/E2N5nTJUZ5V7mYx5r+M0A mJaKKNSSuNyunGD38/V51A== X-Google-Smtp-Source: ABdhPJylzhyMM4ZubAhCo7dYA3YL2otZrpcXevMiKCn9wIriHYocj00wslJC0GNCVDoN5qMmkBz98A== X-Received: by 2002:a17:90b:796:: with SMTP id l22mr4254744pjz.199.1600957534641; Thu, 24 Sep 2020 07:25:34 -0700 (PDT) Received: from PWN (n11212042027.netvigator.com. [112.120.42.27]) by smtp.gmail.com with ESMTPSA id gb17sm2667794pjb.15.2020.09.24.07.25.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2020 07:25:33 -0700 (PDT) Date: Thu, 24 Sep 2020 10:25:25 -0400 From: Peilin Ye To: Greg Kroah-Hartman Message-ID: <20200924142525.GA879276@PWN> References: <0000000000006b9e8d059952095e@google.com> <20200924140937.GA749208@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200924140937.GA749208@kroah.com> Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , Jiri Slaby , syzkaller-bugs@googlegroups.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [Linux-kernel-mentees] [PATCH 0/3] Prevent out-of-bounds access for built-in font data buffers X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Thu, Sep 24, 2020 at 04:09:37PM +0200, Greg Kroah-Hartman wrote: > On Thu, Sep 24, 2020 at 09:38:22AM -0400, Peilin Ye wrote: > > Peilin Ye (3): > > fbdev, newport_con: Move FONT_EXTRA_WORDS macros into linux/font.h > > Fonts: Support FONT_EXTRA_WORDS macros for built-in fonts > > fbcon: Fix global-out-of-bounds read in fbcon_get_font() > > > > drivers/video/console/newport_con.c | 7 +------ > > drivers/video/fbdev/core/fbcon.c | 12 ++++++++++++ > > drivers/video/fbdev/core/fbcon.h | 7 ------- > > drivers/video/fbdev/core/fbcon_rotate.c | 1 + > > drivers/video/fbdev/core/tileblit.c | 1 + > > include/linux/font.h | 13 +++++++++++++ > > lib/fonts/font_10x18.c | 9 ++++----- > > lib/fonts/font_6x10.c | 9 +++++---- > > lib/fonts/font_6x11.c | 9 ++++----- > > lib/fonts/font_7x14.c | 9 ++++----- > > lib/fonts/font_8x16.c | 9 ++++----- > > lib/fonts/font_8x8.c | 9 ++++----- > > lib/fonts/font_acorn_8x8.c | 9 ++++++--- > > lib/fonts/font_mini_4x6.c | 8 ++++---- > > lib/fonts/font_pearl_8x8.c | 9 ++++----- > > lib/fonts/font_sun12x22.c | 9 ++++----- > > lib/fonts/font_sun8x16.c | 7 ++++--- > > lib/fonts/font_ter16x32.c | 9 ++++----- > > 18 files changed, 79 insertions(+), 67 deletions(-) > > Gotta love going backwards in arrays :) > > Nice work, whole series is: > > Reviewed-by: Greg Kroah-Hartman Thank you for reviewing it! Peilin Ye _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08702C4363D for ; Fri, 25 Sep 2020 07:10:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A119423600 for ; Fri, 25 Sep 2020 07:10:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lZ2IHLOv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A119423600 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6A4A86EC19; Fri, 25 Sep 2020 07:10:16 +0000 (UTC) Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by gabe.freedesktop.org (Postfix) with ESMTPS id 10FF76E442 for ; Thu, 24 Sep 2020 14:25:35 +0000 (UTC) Received: by mail-pl1-x643.google.com with SMTP id bb1so1775850plb.2 for ; Thu, 24 Sep 2020 07:25:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BhjXs0X1T6fyEGbqATV3iAKCYDUTserBVGQfsds99Q8=; b=lZ2IHLOvUlSzofjJzppCZLACHPsTpIecrUUi9yAxP/p2GvombkArlU1xTZQhAGnnjK g2GebQ/478ooEg8r5LWavf20tfUHnei0vBc51EApwiUQoShSyH+V6dwxfT2qcl8s0iSS /qXQEn0URynfGfyTDlit78GesAM221oMd2R25Hi9nVYzscs9+9GmmaflqLcEp5ACCvT/ q2mNkYlPDdTJPfqnwcNgEyRQxXy4CapItbbfWtij9i+M1fCht3TSleY5p+Zb5vH+e6cl tghZdra5yDIl1eJHDG5d1wXzyMT90qrJwYHZO22BNM6r+7AMsLHgWTizzxRn/54oshsA YJOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BhjXs0X1T6fyEGbqATV3iAKCYDUTserBVGQfsds99Q8=; b=KuRWvhOu6bIZhr+Ta/aOee0EoIebRQPZgInvtMDQ0x2+ZBvkO5H1VGAlHk/9RhY/FU srBW0JWMeGmEu/LUWDndqdMs64ppEQSKfu0+i8XCzWm7PTaBsf4VmttR/wUvS6TfETqV AORnFKy/BwuSgqkqwOyGNsLdsppR/anR9HS2vnvYVdpU4uqKi5Gozco+pzN2ApJRLaXu WhMBcKmsRwoolZt0DQ2W1Jz2KYpN2NdZLVnvg8Q8fRwDyxFzB9l0EGH+qN/cPmFsE7oH cmmzuLTIVlGybytgdiwh2SnSkLAgF0Yu59KD7Ws4ZiHob/7w3kC0/cgCJ959kDqscroQ 79Kg== X-Gm-Message-State: AOAM531IO5aPf+rsjVjPrr0kyH91b+ZPNwPjfzzziyqXVdmfCWxg0ruA 7Bmi5vmj1L4wtxpVVnSP3w== X-Google-Smtp-Source: ABdhPJylzhyMM4ZubAhCo7dYA3YL2otZrpcXevMiKCn9wIriHYocj00wslJC0GNCVDoN5qMmkBz98A== X-Received: by 2002:a17:90b:796:: with SMTP id l22mr4254744pjz.199.1600957534641; Thu, 24 Sep 2020 07:25:34 -0700 (PDT) Received: from PWN (n11212042027.netvigator.com. [112.120.42.27]) by smtp.gmail.com with ESMTPSA id gb17sm2667794pjb.15.2020.09.24.07.25.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2020 07:25:33 -0700 (PDT) Date: Thu, 24 Sep 2020 10:25:25 -0400 From: Peilin Ye To: Greg Kroah-Hartman Subject: Re: [PATCH 0/3] Prevent out-of-bounds access for built-in font data buffers Message-ID: <20200924142525.GA879276@PWN> References: <0000000000006b9e8d059952095e@google.com> <20200924140937.GA749208@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200924140937.GA749208@kroah.com> X-Mailman-Approved-At: Fri, 25 Sep 2020 07:09:24 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , Jiri Slaby , syzkaller-bugs@googlegroups.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel-mentees@lists.linuxfoundation.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Sep 24, 2020 at 04:09:37PM +0200, Greg Kroah-Hartman wrote: > On Thu, Sep 24, 2020 at 09:38:22AM -0400, Peilin Ye wrote: > > Peilin Ye (3): > > fbdev, newport_con: Move FONT_EXTRA_WORDS macros into linux/font.h > > Fonts: Support FONT_EXTRA_WORDS macros for built-in fonts > > fbcon: Fix global-out-of-bounds read in fbcon_get_font() > > > > drivers/video/console/newport_con.c | 7 +------ > > drivers/video/fbdev/core/fbcon.c | 12 ++++++++++++ > > drivers/video/fbdev/core/fbcon.h | 7 ------- > > drivers/video/fbdev/core/fbcon_rotate.c | 1 + > > drivers/video/fbdev/core/tileblit.c | 1 + > > include/linux/font.h | 13 +++++++++++++ > > lib/fonts/font_10x18.c | 9 ++++----- > > lib/fonts/font_6x10.c | 9 +++++---- > > lib/fonts/font_6x11.c | 9 ++++----- > > lib/fonts/font_7x14.c | 9 ++++----- > > lib/fonts/font_8x16.c | 9 ++++----- > > lib/fonts/font_8x8.c | 9 ++++----- > > lib/fonts/font_acorn_8x8.c | 9 ++++++--- > > lib/fonts/font_mini_4x6.c | 8 ++++---- > > lib/fonts/font_pearl_8x8.c | 9 ++++----- > > lib/fonts/font_sun12x22.c | 9 ++++----- > > lib/fonts/font_sun8x16.c | 7 ++++--- > > lib/fonts/font_ter16x32.c | 9 ++++----- > > 18 files changed, 79 insertions(+), 67 deletions(-) > > Gotta love going backwards in arrays :) > > Nice work, whole series is: > > Reviewed-by: Greg Kroah-Hartman Thank you for reviewing it! Peilin Ye _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7160C4363D for ; Thu, 24 Sep 2020 14:25:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 74BC220758 for ; Thu, 24 Sep 2020 14:25:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lZ2IHLOv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728215AbgIXOZf (ORCPT ); Thu, 24 Sep 2020 10:25:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727974AbgIXOZf (ORCPT ); Thu, 24 Sep 2020 10:25:35 -0400 Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23F7DC0613CE; Thu, 24 Sep 2020 07:25:35 -0700 (PDT) Received: by mail-pl1-x644.google.com with SMTP id y6so1749075plt.9; Thu, 24 Sep 2020 07:25:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BhjXs0X1T6fyEGbqATV3iAKCYDUTserBVGQfsds99Q8=; b=lZ2IHLOvUlSzofjJzppCZLACHPsTpIecrUUi9yAxP/p2GvombkArlU1xTZQhAGnnjK g2GebQ/478ooEg8r5LWavf20tfUHnei0vBc51EApwiUQoShSyH+V6dwxfT2qcl8s0iSS /qXQEn0URynfGfyTDlit78GesAM221oMd2R25Hi9nVYzscs9+9GmmaflqLcEp5ACCvT/ q2mNkYlPDdTJPfqnwcNgEyRQxXy4CapItbbfWtij9i+M1fCht3TSleY5p+Zb5vH+e6cl tghZdra5yDIl1eJHDG5d1wXzyMT90qrJwYHZO22BNM6r+7AMsLHgWTizzxRn/54oshsA YJOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BhjXs0X1T6fyEGbqATV3iAKCYDUTserBVGQfsds99Q8=; b=JTHs9vyUBeqLPtWEJXbeHHE17JTfl18RDVDAj/goD8ifyxqpA+M2WcIiifp32Le+mT rgd1j0XH3aN8xNtWTq+9sT08rf919PZYGJY1dbKFRotClRjReUYwXp/X9yERIicpjk64 thXX6d61CSr6j8PpA7UB/mkF0zESspsjQ1/WqYmfQZHMpC+Yzm+brhnRS9mNdX9sdsNn 5QuJEeR3nt+Ovj3e3FJND7XIyGx/z6UllS29tKNHlNjlXYTCcqrUZuWbJRQoapj0bNTK g9Ts8FrLvwTmJXUbiNiSlBl/XA1a43AW1rc+JilDNmorGjHBduAbhQusK66Pb/mCuUqU +hlg== X-Gm-Message-State: AOAM532ZwrcHSvYjcI8llCSfyWEICZ7r8ccyaQOHWM7ybHbRdAFEzzPM 8Xe0Vj68xz3AkmLIR+CA0w== X-Google-Smtp-Source: ABdhPJylzhyMM4ZubAhCo7dYA3YL2otZrpcXevMiKCn9wIriHYocj00wslJC0GNCVDoN5qMmkBz98A== X-Received: by 2002:a17:90b:796:: with SMTP id l22mr4254744pjz.199.1600957534641; Thu, 24 Sep 2020 07:25:34 -0700 (PDT) Received: from PWN (n11212042027.netvigator.com. [112.120.42.27]) by smtp.gmail.com with ESMTPSA id gb17sm2667794pjb.15.2020.09.24.07.25.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2020 07:25:33 -0700 (PDT) Date: Thu, 24 Sep 2020 10:25:25 -0400 From: Peilin Ye To: Greg Kroah-Hartman Cc: Bartlomiej Zolnierkiewicz , Jiri Slaby , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, syzkaller-bugs@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] Prevent out-of-bounds access for built-in font data buffers Message-ID: <20200924142525.GA879276@PWN> References: <0000000000006b9e8d059952095e@google.com> <20200924140937.GA749208@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200924140937.GA749208@kroah.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 24, 2020 at 04:09:37PM +0200, Greg Kroah-Hartman wrote: > On Thu, Sep 24, 2020 at 09:38:22AM -0400, Peilin Ye wrote: > > Peilin Ye (3): > > fbdev, newport_con: Move FONT_EXTRA_WORDS macros into linux/font.h > > Fonts: Support FONT_EXTRA_WORDS macros for built-in fonts > > fbcon: Fix global-out-of-bounds read in fbcon_get_font() > > > > drivers/video/console/newport_con.c | 7 +------ > > drivers/video/fbdev/core/fbcon.c | 12 ++++++++++++ > > drivers/video/fbdev/core/fbcon.h | 7 ------- > > drivers/video/fbdev/core/fbcon_rotate.c | 1 + > > drivers/video/fbdev/core/tileblit.c | 1 + > > include/linux/font.h | 13 +++++++++++++ > > lib/fonts/font_10x18.c | 9 ++++----- > > lib/fonts/font_6x10.c | 9 +++++---- > > lib/fonts/font_6x11.c | 9 ++++----- > > lib/fonts/font_7x14.c | 9 ++++----- > > lib/fonts/font_8x16.c | 9 ++++----- > > lib/fonts/font_8x8.c | 9 ++++----- > > lib/fonts/font_acorn_8x8.c | 9 ++++++--- > > lib/fonts/font_mini_4x6.c | 8 ++++---- > > lib/fonts/font_pearl_8x8.c | 9 ++++----- > > lib/fonts/font_sun12x22.c | 9 ++++----- > > lib/fonts/font_sun8x16.c | 7 ++++--- > > lib/fonts/font_ter16x32.c | 9 ++++----- > > 18 files changed, 79 insertions(+), 67 deletions(-) > > Gotta love going backwards in arrays :) > > Nice work, whole series is: > > Reviewed-by: Greg Kroah-Hartman Thank you for reviewing it! Peilin Ye