From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Ye Bin <yebin10@huawei.com>
Cc: riteshh@linux.ibm.com, jack@suse.cz, adilger.kernel@dilger.ca,
jack@suse.com, linux-ext4@vger.kernel.org
Subject: Re: [PATCH v5 1/2] ext4: Discard preallocations before releasing group lock
Date: Thu, 24 Sep 2020 10:58:23 -0400 [thread overview]
Message-ID: <20200924145823.GF482521@mit.edu> (raw)
In-Reply-To: <20200916113859.1556397-2-yebin10@huawei.com>
On Wed, Sep 16, 2020 at 07:38:58PM +0800, Ye Bin wrote:
> From: Jan Kara <jack@suse.cz>
>
> ext4_mb_discard_group_preallocations() can be releasing group lock with
> preallocations accumulated on its local list. Thus although
> discard_pa_seq was incremented and concurrent allocating processes will
> be retrying allocations, it can happen that premature ENOSPC error is
> returned because blocks used for preallocations are not available for
> reuse yet. Make sure we always free locally accumulated preallocations
> before releasing group lock.
>
> Fixes: 07b5b8e1ac40 ("ext4: mballoc: introduce pcpu seqcnt for freeing PA to improve ENOSPC handling")
> Signed-off-by: Jan Kara <jack@suse.cz>
> Signed-off-by: Ye Bin <yebin10@huawei.com>
> Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>
Thanks, applied.
- Ted
next prev parent reply other threads:[~2020-09-24 14:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 11:38 [PATCH v5 0/2] Fix dead loop in ext4_mb_new_blocks Ye Bin
2020-09-16 11:38 ` [PATCH v5 1/2] ext4: Discard preallocations before releasing group lock Ye Bin
2020-09-18 9:07 ` Ritesh Harjani
2020-09-18 9:56 ` Jan Kara
2020-09-24 15:00 ` Theodore Y. Ts'o
2020-09-24 15:12 ` Jan Kara
2020-09-24 14:58 ` Theodore Y. Ts'o [this message]
2020-09-16 11:38 ` [PATCH v5 2/2] ext4: Fix dead loop in ext4_mb_new_blocks Ye Bin
2020-09-24 14:59 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924145823.GF482521@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=riteshh@linux.ibm.com \
--cc=yebin10@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.