From: Kalle Valo <kvalo@codeaurora.org>
To: Zhang Changzhong <zhangchangzhong@huawei.com>
Cc: <davem@davemloft.net>, <kuba@kernel.org>,
<linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] brcmfmac: check return value of driver_for_each_device()
Date: Thu, 24 Sep 2020 15:48:13 +0000 (UTC) [thread overview]
Message-ID: <20200924154813.78757C433FF@smtp.codeaurora.org> (raw)
In-Reply-To: <1600481191-14250-1-git-send-email-zhangchangzhong@huawei.com>
Zhang Changzhong <zhangchangzhong@huawei.com> wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c:1576:6: warning:
> variable 'ret' set but not used [-Wunused-but-set-variable]
> 1576 | int ret;
> | ^~~
>
> driver_for_each_device() has been declared with __must_check, so the
> return value should be checked.
>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Patch applied to wireless-drivers-next.git, thanks.
72a398a63b88 brcmfmac: check return value of driver_for_each_device()
--
https://patchwork.kernel.org/patch/11786561/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-09-24 15:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-19 2:06 [PATCH v2] brcmfmac: check return value of driver_for_each_device() Zhang Changzhong
2020-09-24 15:48 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924154813.78757C433FF@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=zhangchangzhong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.