From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB7A6C4346E for ; Thu, 24 Sep 2020 23:47:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 61540239CF for ; Thu, 24 Sep 2020 23:47:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="VFyC5KeN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726758AbgIXXrn (ORCPT ); Thu, 24 Sep 2020 19:47:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726205AbgIXXrn (ORCPT ); Thu, 24 Sep 2020 19:47:43 -0400 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42B22C0613CE for ; Thu, 24 Sep 2020 16:47:43 -0700 (PDT) Received: by mail-pf1-x444.google.com with SMTP id n14so1261111pff.6 for ; Thu, 24 Sep 2020 16:47:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=dhceond6MhN2R2DQeCMd0g/2xnp3K8y0mvTHC2tschA=; b=VFyC5KeNqyRRNwJ2rIqr64ZAdhtd3ZjHKi/FlEg6q1kPOgt6jHtVOG5WenIgUz+WhE wPdvUdWlU8OufLk3klwumvuTjCzgSVta9G3tmEHbHyw00UO5g5AmnSaWsmsA1JTkdntn +CeaImnE6+DIvQMWrDoXvTu0JKpZVaUbnMIps= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=dhceond6MhN2R2DQeCMd0g/2xnp3K8y0mvTHC2tschA=; b=G3eVfJ/SxPmnu5M+g7Rvy3K4DKH+CRyPEuenp+po6Xd4qpZugwS52y3txyGx/I6WAN lJsxsZoDTnEaBofqdjzfX1bfAp25tItPMygpKgIYNd4adXLw5fCFprLeIJTBFoeay7Oo 060qtQsa/7iYf1AF52WXNSAeo4EfXOYpAiFd2VEmxt0q+ugP//m7CRchIpc0MVd4J07I 3i/hJs/9tJFT+oszfsyfByfNCmbo/rE4mh1Ctrya0BMfyj7CWQJq5ZmTgYRv8i0/0OlF UVZcUTiBL8giCahsE5FErnZNDZmf7KMAnlya1e9RCmXtfBVAfAUHzzjFEWPVGbad9jiW Ncww== X-Gm-Message-State: AOAM530dImG/H2Dqm15SvwlTR3JnpNMP8e0En1WnZZWcd2f8dJ7secDB JS4Kuke7W8DHPVGVU2bLUBoM7Q== X-Google-Smtp-Source: ABdhPJxFkZ2rv0mIiwE5o4BC/5A99M3zCAJji9u/yHJrgtSMDtuGx5fu+J4480xg2ZG87UninMdAIQ== X-Received: by 2002:a17:902:b18f:b029:d2:1ec0:4161 with SMTP id s15-20020a170902b18fb02900d21ec04161mr1559187plr.58.1600991262838; Thu, 24 Sep 2020 16:47:42 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id n125sm526792pfn.185.2020.09.24.16.47.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2020 16:47:42 -0700 (PDT) Date: Thu, 24 Sep 2020 16:47:41 -0700 From: Kees Cook To: YiFei Zhu Cc: containers@lists.linux-foundation.org, YiFei Zhu , bpf@vger.kernel.org, linux-kernel@vger.kernel.org, Aleksa Sarai , Andrea Arcangeli , Andy Lutomirski , Dimitrios Skarlatos , Giuseppe Scrivano , Hubertus Franke , Jack Chen , Jann Horn , Josep Torrellas , Tianyin Xu , Tobin Feldman-Fitzthum , Tycho Andersen , Valentin Rothberg , Will Drewry Subject: Re: [PATCH v2 seccomp 5/6] selftests/seccomp: Compare bitmap vs filter overhead Message-ID: <202009241646.5739BE3@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Thu, Sep 24, 2020 at 07:44:20AM -0500, YiFei Zhu wrote: > From: Kees Cook > > As part of the seccomp benchmarking, include the expectations with > regard to the timing behavior of the constant action bitmaps, and report > inconsistencies better. > > Example output with constant action bitmaps on x86: > > $ sudo ./seccomp_benchmark 100000000 > Current BPF sysctl settings: > net.core.bpf_jit_enable = 1 > net.core.bpf_jit_harden = 0 > Benchmarking 100000000 syscalls... > 63.896255358 - 0.008504529 = 63887750829 (63.9s) > getpid native: 638 ns > 130.383312423 - 63.897315189 = 66485997234 (66.5s) > getpid RET_ALLOW 1 filter (bitmap): 664 ns > 196.789080421 - 130.384414983 = 66404665438 (66.4s) > getpid RET_ALLOW 2 filters (bitmap): 664 ns > 268.844643304 - 196.790234168 = 72054409136 (72.1s) > getpid RET_ALLOW 3 filters (full): 720 ns > 342.627472515 - 268.845799103 = 73781673412 (73.8s) > getpid RET_ALLOW 4 filters (full): 737 ns > Estimated total seccomp overhead for 1 bitmapped filter: 26 ns > Estimated total seccomp overhead for 2 bitmapped filters: 26 ns > Estimated total seccomp overhead for 3 full filters: 82 ns > Estimated total seccomp overhead for 4 full filters: 99 ns > Estimated seccomp entry overhead: 26 ns > Estimated seccomp per-filter overhead (last 2 diff): 17 ns > Estimated seccomp per-filter overhead (filters / 4): 18 ns > Expectations: > native ≤ 1 bitmap (638 ≤ 664): ✔️ > native ≤ 1 filter (638 ≤ 720): ✔️ > per-filter (last 2 diff) ≈ per-filter (filters / 4) (17 ≈ 18): ✔️ > 1 bitmapped ≈ 2 bitmapped (26 ≈ 26): ✔️ > entry ≈ 1 bitmapped (26 ≈ 26): ✔️ > entry ≈ 2 bitmapped (26 ≈ 26): ✔️ > native + entry + (per filter * 4) ≈ 4 filters total (732 ≈ 737): ✔️ > > Signed-off-by: Kees Cook > Signed-off-by: YiFei Zhu BTW, did this benchmark tool's results match your expectations from what you saw with your RFC? (I assume it helped since you've included in here.) -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CAACC4346E for ; Thu, 24 Sep 2020 23:47:48 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 81F89239CF for ; Thu, 24 Sep 2020 23:47:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="VFyC5KeN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 81F89239CF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=containers-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 3EA57874F3; Thu, 24 Sep 2020 23:47:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 09jCF9NqgWKK; Thu, 24 Sep 2020 23:47:46 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 9FD1F874CB; Thu, 24 Sep 2020 23:47:46 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 886CFC0889; Thu, 24 Sep 2020 23:47:46 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 49BF8C0051 for ; Thu, 24 Sep 2020 23:47:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 387ED861B2 for ; Thu, 24 Sep 2020 23:47:45 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yPpK4FdEt2Lx for ; Thu, 24 Sep 2020 23:47:43 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 3E1D78612E for ; Thu, 24 Sep 2020 23:47:43 +0000 (UTC) Received: by mail-pf1-f195.google.com with SMTP id x22so1241496pfo.12 for ; Thu, 24 Sep 2020 16:47:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=dhceond6MhN2R2DQeCMd0g/2xnp3K8y0mvTHC2tschA=; b=VFyC5KeNqyRRNwJ2rIqr64ZAdhtd3ZjHKi/FlEg6q1kPOgt6jHtVOG5WenIgUz+WhE wPdvUdWlU8OufLk3klwumvuTjCzgSVta9G3tmEHbHyw00UO5g5AmnSaWsmsA1JTkdntn +CeaImnE6+DIvQMWrDoXvTu0JKpZVaUbnMIps= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=dhceond6MhN2R2DQeCMd0g/2xnp3K8y0mvTHC2tschA=; b=SbUGWAQvI//rW682q3YTozmiuWemjT01JH9aP/jFTdK2cEgfSNhSn5si8G1a6tEIFJ l9XNathWzkQSSPHb/7et0PlwDh2YOvyE1olWtrUb99tOMJcKBt74pHh/QNYkXLU15Kwl 4fc5XVWb9BKPeNzVbgm6fMPb+cZfa12iom0GJ40HQpxvx3/o3DBjl6jkh/G86DB63Mmt VXV1nX0uw0f6lnceAEWldMQW9619aziT4FKopGrQUTNayMFXLvvb9btG7NpAoIXoGSfq f/K6KIUYwY/eRseqt+fdp76Vs9j7yw4DY2kDQagYywFHd5yNYwef2LNdpPy9JvOE5LkA FHpg== X-Gm-Message-State: AOAM5305YyI4MA6jPF84lJiBi6y3iV8cTKn2ufQkmRG7nv9jQpvOHxwk QVYnSCak+uvoLoFTMMx0qbpDoQ== X-Google-Smtp-Source: ABdhPJxFkZ2rv0mIiwE5o4BC/5A99M3zCAJji9u/yHJrgtSMDtuGx5fu+J4480xg2ZG87UninMdAIQ== X-Received: by 2002:a17:902:b18f:b029:d2:1ec0:4161 with SMTP id s15-20020a170902b18fb02900d21ec04161mr1559187plr.58.1600991262838; Thu, 24 Sep 2020 16:47:42 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id n125sm526792pfn.185.2020.09.24.16.47.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2020 16:47:42 -0700 (PDT) Date: Thu, 24 Sep 2020 16:47:41 -0700 From: Kees Cook To: YiFei Zhu Subject: Re: [PATCH v2 seccomp 5/6] selftests/seccomp: Compare bitmap vs filter overhead Message-ID: <202009241646.5739BE3@keescook> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: Andrea Arcangeli , Giuseppe Scrivano , Valentin Rothberg , Jann Horn , YiFei Zhu , containers@lists.linux-foundation.org, Tobin Feldman-Fitzthum , linux-kernel@vger.kernel.org, Andy Lutomirski , Hubertus Franke , Jack Chen , Dimitrios Skarlatos , Josep Torrellas , Will Drewry , bpf@vger.kernel.org, Tianyin Xu X-BeenThere: containers@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux Containers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: containers-bounces@lists.linux-foundation.org Sender: "Containers" T24gVGh1LCBTZXAgMjQsIDIwMjAgYXQgMDc6NDQ6MjBBTSAtMDUwMCwgWWlGZWkgWmh1IHdyb3Rl Ogo+IEZyb206IEtlZXMgQ29vayA8a2Vlc2Nvb2tAY2hyb21pdW0ub3JnPgo+IAo+IEFzIHBhcnQg b2YgdGhlIHNlY2NvbXAgYmVuY2htYXJraW5nLCBpbmNsdWRlIHRoZSBleHBlY3RhdGlvbnMgd2l0 aAo+IHJlZ2FyZCB0byB0aGUgdGltaW5nIGJlaGF2aW9yIG9mIHRoZSBjb25zdGFudCBhY3Rpb24g Yml0bWFwcywgYW5kIHJlcG9ydAo+IGluY29uc2lzdGVuY2llcyBiZXR0ZXIuCj4gCj4gRXhhbXBs ZSBvdXRwdXQgd2l0aCBjb25zdGFudCBhY3Rpb24gYml0bWFwcyBvbiB4ODY6Cj4gCj4gJCBzdWRv IC4vc2VjY29tcF9iZW5jaG1hcmsgMTAwMDAwMDAwCj4gQ3VycmVudCBCUEYgc3lzY3RsIHNldHRp bmdzOgo+IG5ldC5jb3JlLmJwZl9qaXRfZW5hYmxlID0gMQo+IG5ldC5jb3JlLmJwZl9qaXRfaGFy ZGVuID0gMAo+IEJlbmNobWFya2luZyAxMDAwMDAwMDAgc3lzY2FsbHMuLi4KPiA2My44OTYyNTUz NTggLSAwLjAwODUwNDUyOSA9IDYzODg3NzUwODI5ICg2My45cykKPiBnZXRwaWQgbmF0aXZlOiA2 MzggbnMKPiAxMzAuMzgzMzEyNDIzIC0gNjMuODk3MzE1MTg5ID0gNjY0ODU5OTcyMzQgKDY2LjVz KQo+IGdldHBpZCBSRVRfQUxMT1cgMSBmaWx0ZXIgKGJpdG1hcCk6IDY2NCBucwo+IDE5Ni43ODkw ODA0MjEgLSAxMzAuMzg0NDE0OTgzID0gNjY0MDQ2NjU0MzggKDY2LjRzKQo+IGdldHBpZCBSRVRf QUxMT1cgMiBmaWx0ZXJzIChiaXRtYXApOiA2NjQgbnMKPiAyNjguODQ0NjQzMzA0IC0gMTk2Ljc5 MDIzNDE2OCA9IDcyMDU0NDA5MTM2ICg3Mi4xcykKPiBnZXRwaWQgUkVUX0FMTE9XIDMgZmlsdGVy cyAoZnVsbCk6IDcyMCBucwo+IDM0Mi42Mjc0NzI1MTUgLSAyNjguODQ1Nzk5MTAzID0gNzM3ODE2 NzM0MTIgKDczLjhzKQo+IGdldHBpZCBSRVRfQUxMT1cgNCBmaWx0ZXJzIChmdWxsKTogNzM3IG5z Cj4gRXN0aW1hdGVkIHRvdGFsIHNlY2NvbXAgb3ZlcmhlYWQgZm9yIDEgYml0bWFwcGVkIGZpbHRl cjogMjYgbnMKPiBFc3RpbWF0ZWQgdG90YWwgc2VjY29tcCBvdmVyaGVhZCBmb3IgMiBiaXRtYXBw ZWQgZmlsdGVyczogMjYgbnMKPiBFc3RpbWF0ZWQgdG90YWwgc2VjY29tcCBvdmVyaGVhZCBmb3Ig MyBmdWxsIGZpbHRlcnM6IDgyIG5zCj4gRXN0aW1hdGVkIHRvdGFsIHNlY2NvbXAgb3ZlcmhlYWQg Zm9yIDQgZnVsbCBmaWx0ZXJzOiA5OSBucwo+IEVzdGltYXRlZCBzZWNjb21wIGVudHJ5IG92ZXJo ZWFkOiAyNiBucwo+IEVzdGltYXRlZCBzZWNjb21wIHBlci1maWx0ZXIgb3ZlcmhlYWQgKGxhc3Qg MiBkaWZmKTogMTcgbnMKPiBFc3RpbWF0ZWQgc2VjY29tcCBwZXItZmlsdGVyIG92ZXJoZWFkIChm aWx0ZXJzIC8gNCk6IDE4IG5zCj4gRXhwZWN0YXRpb25zOgo+IAluYXRpdmUg4omkIDEgYml0bWFw ICg2Mzgg4omkIDY2NCk6IOKclO+4jwo+IAluYXRpdmUg4omkIDEgZmlsdGVyICg2Mzgg4omkIDcy MCk6IOKclO+4jwo+IAlwZXItZmlsdGVyIChsYXN0IDIgZGlmZikg4omIIHBlci1maWx0ZXIgKGZp bHRlcnMgLyA0KSAoMTcg4omIIDE4KTog4pyU77iPCj4gCTEgYml0bWFwcGVkIOKJiCAyIGJpdG1h cHBlZCAoMjYg4omIIDI2KTog4pyU77iPCj4gCWVudHJ5IOKJiCAxIGJpdG1hcHBlZCAoMjYg4omI IDI2KTog4pyU77iPCj4gCWVudHJ5IOKJiCAyIGJpdG1hcHBlZCAoMjYg4omIIDI2KTog4pyU77iP Cj4gCW5hdGl2ZSArIGVudHJ5ICsgKHBlciBmaWx0ZXIgKiA0KSDiiYggNCBmaWx0ZXJzIHRvdGFs ICg3MzIg4omIIDczNyk6IOKclO+4jwo+IAo+IFNpZ25lZC1vZmYtYnk6IEtlZXMgQ29vayA8a2Vl c2Nvb2tAY2hyb21pdW0ub3JnPgo+IFNpZ25lZC1vZmYtYnk6IFlpRmVpIFpodSA8eWlmZWlmejJA aWxsaW5vaXMuZWR1PgoKQlRXLCBkaWQgdGhpcyBiZW5jaG1hcmsgdG9vbCdzIHJlc3VsdHMgbWF0 Y2ggeW91ciBleHBlY3RhdGlvbnMgZnJvbSB3aGF0CnlvdSBzYXcgd2l0aCB5b3VyIFJGQz8gKEkg YXNzdW1lIGl0IGhlbHBlZCBzaW5jZSB5b3UndmUgaW5jbHVkZWQgaW4KaGVyZS4pCgotLSAKS2Vl cyBDb29rCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkNv bnRhaW5lcnMgbWFpbGluZyBsaXN0CkNvbnRhaW5lcnNAbGlzdHMubGludXgtZm91bmRhdGlvbi5v cmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vY29u dGFpbmVycw==