Re: [PATCH] mmc: rtsx: Add SD Express mode support for RTS5261

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 5364 bytes --]

Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on char-misc/char-misc-testing]
[also build test ERROR on soc/for-next linus/master v5.9-rc6 next-20200924]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/rui_feng-realsil-com-cn/mmc-rtsx-Add-SD-Express-mode-support-for-RTS5261/20200924-154122
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 26ed5146bd17cbcd0fb84e358902ac244728a3f3
config: riscv-allyesconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/mmc/host/rtsx_pci_sdmmc.c: In function 'sd_power_on':
   drivers/mmc/host/rtsx_pci_sdmmc.c:931:20: error: 'MMC_CAP2_SD_EXP' undeclared (first use in this function); did you mean 'MMC_CAP2_NO_SD'?
     931 |    mmc->caps2 &= ~(MMC_CAP2_SD_EXP | MMC_CAP2_SD_EXP_1_2V);
         |                    ^~~~~~~~~~~~~~~
         |                    MMC_CAP2_NO_SD
   drivers/mmc/host/rtsx_pci_sdmmc.c:931:20: note: each undeclared identifier is reported only once for each function it appears in
   drivers/mmc/host/rtsx_pci_sdmmc.c:931:38: error: 'MMC_CAP2_SD_EXP_1_2V' undeclared (first use in this function); did you mean 'MMC_CAP2_HS400_1_2V'?
     931 |    mmc->caps2 &= ~(MMC_CAP2_SD_EXP | MMC_CAP2_SD_EXP_1_2V);
         |                                      ^~~~~~~~~~~~~~~~~~~~
         |                                      MMC_CAP2_HS400_1_2V
   drivers/mmc/host/rtsx_pci_sdmmc.c: In function 'sdmmc_get_cd':
   drivers/mmc/host/rtsx_pci_sdmmc.c:1141:17: error: 'MMC_CAP2_SD_EXP' undeclared (first use in this function); did you mean 'MMC_CAP2_NO_SD'?
    1141 |   mmc->caps2 |= MMC_CAP2_SD_EXP | MMC_CAP2_SD_EXP_1_2V;
         |                 ^~~~~~~~~~~~~~~
         |                 MMC_CAP2_NO_SD
   drivers/mmc/host/rtsx_pci_sdmmc.c:1141:35: error: 'MMC_CAP2_SD_EXP_1_2V' undeclared (first use in this function); did you mean 'MMC_CAP2_HS400_1_2V'?
    1141 |   mmc->caps2 |= MMC_CAP2_SD_EXP | MMC_CAP2_SD_EXP_1_2V;
         |                                   ^~~~~~~~~~~~~~~~~~~~
         |                                   MMC_CAP2_HS400_1_2V
   drivers/mmc/host/rtsx_pci_sdmmc.c: At top level:
   drivers/mmc/host/rtsx_pci_sdmmc.c:1376:3: error: 'const struct mmc_host_ops' has no member named 'init_sd_express'
    1376 |  .init_sd_express = sdmmc_init_sd_express,
         |   ^~~~~~~~~~~~~~~
>> drivers/mmc/host/rtsx_pci_sdmmc.c:1376:21: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init]
    1376 |  .init_sd_express = sdmmc_init_sd_express,
         |                     ^~~~~~~~~~~~~~~~~~~~~
   drivers/mmc/host/rtsx_pci_sdmmc.c:1376:21: note: (near initialization for 'realtek_pci_sdmmc_ops')
   drivers/mmc/host/rtsx_pci_sdmmc.c:1376:21: warning: excess elements in struct initializer
   drivers/mmc/host/rtsx_pci_sdmmc.c:1376:21: note: (near initialization for 'realtek_pci_sdmmc_ops')
   drivers/mmc/host/rtsx_pci_sdmmc.c: In function 'init_extra_caps':
   drivers/mmc/host/rtsx_pci_sdmmc.c:1399:17: error: 'MMC_CAP2_SD_EXP' undeclared (first use in this function); did you mean 'MMC_CAP2_NO_SD'?
    1399 |   mmc->caps2 |= MMC_CAP2_SD_EXP | MMC_CAP2_SD_EXP_1_2V;
         |                 ^~~~~~~~~~~~~~~
         |                 MMC_CAP2_NO_SD
   drivers/mmc/host/rtsx_pci_sdmmc.c:1399:35: error: 'MMC_CAP2_SD_EXP_1_2V' undeclared (first use in this function); did you mean 'MMC_CAP2_HS400_1_2V'?
    1399 |   mmc->caps2 |= MMC_CAP2_SD_EXP | MMC_CAP2_SD_EXP_1_2V;
         |                                   ^~~~~~~~~~~~~~~~~~~~
         |                                   MMC_CAP2_HS400_1_2V
   cc1: some warnings being treated as errors

# https://github.com/0day-ci/linux/commit/37daa224f78ef228349cee981d690b735fb9bb2b
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review rui_feng-realsil-com-cn/mmc-rtsx-Add-SD-Express-mode-support-for-RTS5261/20200924-154122
git checkout 37daa224f78ef228349cee981d690b735fb9bb2b
vim +1376 drivers/mmc/host/rtsx_pci_sdmmc.c

  1366	
  1367	static const struct mmc_host_ops realtek_pci_sdmmc_ops = {
  1368		.pre_req = sdmmc_pre_req,
  1369		.post_req = sdmmc_post_req,
  1370		.request = sdmmc_request,
  1371		.set_ios = sdmmc_set_ios,
  1372		.get_ro = sdmmc_get_ro,
  1373		.get_cd = sdmmc_get_cd,
  1374		.start_signal_voltage_switch = sdmmc_switch_voltage,
  1375		.execute_tuning = sdmmc_execute_tuning,
> 1376		.init_sd_express = sdmmc_init_sd_express,
  1377	};
  1378	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 66135 bytes --]