From: Simon Horman <horms@verge.net.au>
To: Bhupesh Sharma <bhsharma@redhat.com>
Cc: bhupesh.linux@gmail.com, kexec@lists.infradead.org
Subject: Re: [PATCH] kexec/arm64: Add support for ARMv8.2 (large space addressing) 52-bit VA extensions
Date: Fri, 25 Sep 2020 08:07:17 +0200 [thread overview]
Message-ID: <20200925060715.GC618@vergenet.net> (raw)
In-Reply-To: <20200915210755.555316-1-bhsharma@redhat.com>
Hi Bhupesh,
thanks for your patch.
...
> +static int get_vabits_actual_from_id_aa64mmfr2_el1(void)
> +{
> + int l_vabits_actual;
> + unsigned long val;
> +
> + /* Check if ID_AA64MMFR2_EL1 CPU-ID register indicates
> + * ARMv8.2/LVA support:
> + * VARange, bits [19:16]
> + * From ARMv8.2:
> + * Indicates support for a larger virtual address.
> + * Defined values are:
> + * 0b0000 VMSAv8-64 supports 48-bit VAs.
> + * 0b0001 VMSAv8-64 supports 52-bit VAs when using the 64KB
> + * page size. The other translation granules support
> + * 48-bit VAs.
> + *
> + * See ARMv8 ARM for more details.
> + */
> + if (!(getauxval(AT_HWCAP) & HWCAP_CPUID)) {
Likely my build environment wants updating, but the above does not seem
to build in my (aged) environment.
$ aarch64-linux-gnu-gcc --version
aarch64-linux-gnu-gcc (Linaro GCC 7.2-2017.11) 7.2.1 20171011
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
$ aarch64-linux-gnu-gcc -Wall -Wextra -Wpointer-arith -Wwrite-strings -Wformat -O2 -fomit-frame-pointer -pipe -fno-strict-aliasing -Wall -Wstrict-prototypes -I/home/horms/local/opt/gcc-linaro-7.2.1-2017.11-x86_64_aarch64-linux-gnu/include -I./include -I./util_lib/include -Iinclude/ -I ./kexec/ -I./kexec/libfdt -I./kexec/arch/arm64/include -c -MD -o kexec/arch/arm64/kexec-uImage-arm64.o kexec/arch/arm64/kexec-uImage-arm64.c
kexec/arch/arm64/common-arm64.c: In function ‘get_vabits_actual_from_id_aa64mmfr2_el1’:
kexec/arch/arm64/common-arm64.c:133:30: error: ‘HWCAP_CPUID’ undeclared (first use in this function); did you mean ‘HWCAP_CRC32’?
if (!(getauxval(AT_HWCAP) & HWCAP_CPUID)) {
...
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2020-09-25 6:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 21:07 [PATCH] kexec/arm64: Add support for ARMv8.2 (large space addressing) 52-bit VA extensions Bhupesh Sharma
2020-09-25 6:07 ` Simon Horman [this message]
2020-09-28 20:32 ` Bhupesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925060715.GC618@vergenet.net \
--to=horms@verge.net.au \
--cc=bhsharma@redhat.com \
--cc=bhupesh.linux@gmail.com \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.