From: Greg KH <greg@kroah.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Oliver Neukum <oneukum@suse.com>,
bjorn@mork.no, linux-usb@vger.kernel.org
Subject: Re: [RFC] fixes for hangs and error reporting in CDC_WDM
Date: Fri, 25 Sep 2020 17:28:32 +0200 [thread overview]
Message-ID: <20200925152832.GA3191454@kroah.com> (raw)
In-Reply-To: <22e1b8f3-947a-6f15-a788-d639cbabde5c@i-love.sakura.ne.jp>
On Sat, Sep 26, 2020 at 12:20:57AM +0900, Tetsuo Handa wrote:
> On 2020/09/26 0:11, Greg KH wrote:
> > On Tue, Sep 22, 2020 at 01:21:19PM +0200, Oliver Neukum wrote:
> >> Stress testing has shown that CDC-WDM has some issues with hangs
> >> and error reporting
> >>
> >> 1. wakeups are not correctly handled in multhreaded environments
> >> 2. unresponsive hardware is not handled
> >> 3. errors are not correctly reported. This needs flush() to be
> >> implemented.
> >>
> >> This version makes wdm_flush() use interruptible sleep.
> >>
> >> For easier review all squashed together:
> >>
> >
> > I have like 3 or 4 different "RFC" series here from you for this driver,
> > which one is the "newest"?
>
> https://lkml.kernel.org/r/20200923092136.14824-1-oneukum@suse.com
>
> is the newest series from Oliver. But
>
> https://lkml.kernel.org/r/b27841ab-a88c-13e2-a66f-6df7af1f46b4@i-love.sakura.ne.jp
>
> is the squashed version with updated comments and deduplicated code.
>
> >
> > And can you send a series that isn't RFC so that I can know you feel it
> > is good enough to be merged?
>
> Do you want this fix as a series of patches (the former link)?
> Since I think that the changeset should be atomically applied, I posted the latter link.
A single patch would be good to send to me again, burried at the end of
a long thread is hard to dig out.
Also with proper authorship is needed, did Oliver write this, or did
you?
There is the co-developed-by: tag, which looks like it might be relevant
here, can you do that?
thanks,
greg k-h
next prev parent reply other threads:[~2020-09-25 15:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 11:21 [RFC] fixes for hangs and error reporting in CDC_WDM Oliver Neukum
2020-09-22 11:21 ` [RFC 1/7] CDC-WDM: fix hangs in flush() in multithreaded cases Oliver Neukum
2020-09-22 11:21 ` [RFC 2/7] CDC-WDM: introduce a timeout in flush() Oliver Neukum
2020-09-22 11:21 ` [RFC 3/7] CDC-WDM: remove use of intf->dev after potential disconnect Oliver Neukum
2020-09-22 11:21 ` [RFC 4/7] CDC-WDM: fix race reporting errors in flush Oliver Neukum
2020-09-22 11:21 ` [RFC 5/7] CDC-WDM: correct error reporting in write() Oliver Neukum
2020-09-22 11:21 ` [RFC 6/7] CDC-WDM: implement fsync Oliver Neukum
2020-09-22 11:21 ` [RFC 7/7] CDC-WDM: making flush() interruptible Oliver Neukum
2020-09-22 11:38 ` Tetsuo Handa
2020-09-22 11:49 ` Oliver Neukum
2020-09-25 15:11 ` [RFC] fixes for hangs and error reporting in CDC_WDM Greg KH
2020-09-25 15:20 ` Tetsuo Handa
2020-09-25 15:28 ` Greg KH [this message]
2020-09-25 15:34 ` Tetsuo Handa
2020-09-26 5:40 ` Greg KH
2020-09-29 8:46 ` Oliver Neukum
2020-09-29 10:17 ` Tetsuo Handa
-- strict thread matches above, loose matches on Subject: below --
2020-09-22 10:13 Oliver Neukum
2020-09-22 10:42 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925152832.GA3191454@kroah.com \
--to=greg@kroah.com \
--cc=bjorn@mork.no \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.