From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Marek Vasut <marex@denx.de>
Cc: Alexandre Torgue <alexandre.torgue@st.com>,
linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH] ARM: dts: stm32: Enable thermal sensor support on stm32mp15xx-dhcor
Date: Fri, 25 Sep 2020 21:50:40 +0530 [thread overview]
Message-ID: <20200925162040.GA4746@linux> (raw)
In-Reply-To: <b93bb099-644f-ec0f-50ca-0c537c769e51@denx.de>
On Fri, Sep 25, 2020 at 01:12:12PM +0200, Marek Vasut wrote:
> On 9/25/20 4:21 AM, Manivannan Sadhasivam wrote:
> >
> >
> > On 24 September 2020 4:11:11 PM IST, Marek Vasut <marex@denx.de> wrote:
> >> On 9/24/20 7:16 AM, Manivannan Sadhasivam wrote:
> >>>
> >>>
> >>> On 24 September 2020 4:55:35 AM IST, Marek Vasut <marex@denx.de>
> >> wrote:
> >>>> Enable STM32 Digital Thermal Sensor driver for stm32mp15xx-dhcor
> >> SoMs.
> >>>>
> >>>> Fixes: 94cafe1b6482 ("ARM: dts: stm32: Add Avenger96 devicetree
> >> support
> >>>> based on STM32MP157A")
> >>>
> >>> The change looks good but what does this patch fixes?
> >>
> >> The missing temp sensor, which helps you detect overheat of the SoC.
> >> That is esp. important on the 800 MHz AV96.
> >
> > This doesn't quality as a "fix". Essentially you're just adding a missing feature and not fixing any issues. So please remove the fixes tag and resubmit.
>
> I would argue that if the system overheats and crashes, we want to know
> about that, possibly in advance so thermal throttling can be applied.
> Currently this is not possible and I think that is a bug.
No, this is not a _bug_. This is a missing feature that the current kernel
doesn't support and you know about that! The fact that you can trigger a crash
due to hw limitation doesn't qualify as a bug IMO. And you can do that by other
means also (CPU throttling without CPUFreq support etc...)
Anyway, I'll stop here and let Alex to make a call.
Either case, feel free to add:
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-25 16:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 23:25 [PATCH] ARM: dts: stm32: Enable thermal sensor support on stm32mp15xx-dhcor Marek Vasut
2020-09-24 5:16 ` Manivannan Sadhasivam
2020-09-24 10:41 ` Marek Vasut
2020-09-25 2:21 ` Manivannan Sadhasivam
2020-09-25 11:12 ` Marek Vasut
2020-09-25 16:20 ` Manivannan Sadhasivam [this message]
2020-09-25 18:06 ` Marek Vasut
2020-11-09 13:55 ` Alexandre Torgue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925162040.GA4746@linux \
--to=manivannan.sadhasivam@linaro.org \
--cc=alexandre.torgue@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.