From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 681D7C4363D for ; Fri, 25 Sep 2020 16:45:52 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E929620838 for ; Fri, 25 Sep 2020 16:45:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="jwvnVnHL"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="ZqMX2Llp"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="wjyiZ5Kb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E929620838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1kLqr1-0001BI-5p; Fri, 25 Sep 2020 16:45:51 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLqr0-0001BB-GA for linux-f2fs-devel@lists.sourceforge.net; Fri, 25 Sep 2020 16:45:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VuW6qGzzuxVPyqm1oCHDsVB2lhJ9SNnnPwwWOz6XIbg=; b=jwvnVnHLHmsMVakaIdsuPvqzzj JwmFSTFUk54y03i0EPX/3TkxxyU/U/SowhG6yZSdDe+VyB+viPONjG0dupL8dyGjvq8ZyXQcbYESL 6+9KFl3/VgHn1HHw197uD2iH5uK1acFy1CCv26O5UzYetx7B6S8ydATNtsYUVguJp9js=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=VuW6qGzzuxVPyqm1oCHDsVB2lhJ9SNnnPwwWOz6XIbg=; b=ZqMX2Llp+uwJkkF/Qzb5r9ydr9 pkczD78ADxEmvLI5k1gstf+uWDj47LXQA7rCLnJhrEkFRTpPEQwkz7oh8rZGySeSzm06P6Wb5rk1K C3xVDyK3MjctMAye7olR489/qEwLL+5IHAv2aI/cGqTflB0Jyg5gbMA1IY/mJvMAVs+c=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1kLqqw-005jMe-5D for linux-f2fs-devel@lists.sourceforge.net; Fri, 25 Sep 2020 16:45:50 +0000 Received: from gmail.com (unknown [104.132.1.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5D562207C4; Fri, 25 Sep 2020 16:45:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601052340; bh=jCFSSAzfkPx0FSPQZ22vjowCCmUJwQx6Nnx+KhlIOzU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wjyiZ5KbaEaamDgZO/UH46Jx+G5zQ1OuC8xQnXkX5QjK3+dqnkXTgI310MPEtjdS0 +6ejXQSItYHr02ZIjcXYVIfhXd2z9tbnPrQzJrYMvlhYt/rl9IzsxAwuZK7vtp+Bz8 0YEwOtDDH30ohov6SWDlO6CeGJTIl2vtNANp9mHY= Date: Fri, 25 Sep 2020 09:45:38 -0700 From: Eric Biggers To: Chao Yu Message-ID: <20200925164538.GB3315208@gmail.com> References: <000000000000f9f80905b01c7185@google.com> <20200925163819.GA3315208@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200925163819.GA3315208@gmail.com> X-Headers-End: 1kLqqw-005jMe-5D Subject: Re: [f2fs-dev] KMSAN: uninit-value in f2fs_lookup X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: syzbot , syzkaller-bugs@googlegroups.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, glider@google.com, jaegeuk@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Fri, Sep 25, 2020 at 09:38:19AM -0700, Eric Biggers wrote: > On Fri, Sep 25, 2020 at 05:06:33PM +0800, Chao Yu wrote: > > Hi, > > > > I don't see any problem here, thanks for your report. :) > > > > Thanks, > > What about if max_depth == 0 in __f2fs_find_entry()? Then __f2fs_find_entry() > would return NULL without initializing *res_page. ... and I now see Dan Carpenter already pointed this out. I was a bit late! - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2E21C4363D for ; Fri, 25 Sep 2020 16:45:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D70921D42 for ; Fri, 25 Sep 2020 16:45:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601052348; bh=jCFSSAzfkPx0FSPQZ22vjowCCmUJwQx6Nnx+KhlIOzU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=tiaKYYjmmFKN78tWoLTEicFbyUdw+Su+h9YL+XTnWx1devZd/mXyo97qrU1iwAifD D7wFGmNe0aaqrAZ/tV/iWTGVmGc/iaQ1y7FYqE3QyIH4JXZ4s7szhH86L+1EWGRL6Q sYEPF2GEAC4MGeSRlKuhUV1mWDObxEexhSRn+z+0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729446AbgIYQpo (ORCPT ); Fri, 25 Sep 2020 12:45:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:45792 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727495AbgIYQpl (ORCPT ); Fri, 25 Sep 2020 12:45:41 -0400 Received: from gmail.com (unknown [104.132.1.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5D562207C4; Fri, 25 Sep 2020 16:45:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601052340; bh=jCFSSAzfkPx0FSPQZ22vjowCCmUJwQx6Nnx+KhlIOzU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wjyiZ5KbaEaamDgZO/UH46Jx+G5zQ1OuC8xQnXkX5QjK3+dqnkXTgI310MPEtjdS0 +6ejXQSItYHr02ZIjcXYVIfhXd2z9tbnPrQzJrYMvlhYt/rl9IzsxAwuZK7vtp+Bz8 0YEwOtDDH30ohov6SWDlO6CeGJTIl2vtNANp9mHY= Date: Fri, 25 Sep 2020 09:45:38 -0700 From: Eric Biggers To: Chao Yu Cc: syzbot , chao@kernel.org, glider@google.com, jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [f2fs-dev] KMSAN: uninit-value in f2fs_lookup Message-ID: <20200925164538.GB3315208@gmail.com> References: <000000000000f9f80905b01c7185@google.com> <20200925163819.GA3315208@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200925163819.GA3315208@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 25, 2020 at 09:38:19AM -0700, Eric Biggers wrote: > On Fri, Sep 25, 2020 at 05:06:33PM +0800, Chao Yu wrote: > > Hi, > > > > I don't see any problem here, thanks for your report. :) > > > > Thanks, > > What about if max_depth == 0 in __f2fs_find_entry()? Then __f2fs_find_entry() > would return NULL without initializing *res_page. ... and I now see Dan Carpenter already pointed this out. I was a bit late! - Eric