From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: x86/irq: Make run_on_irqstack_cond() typesafe
Date: Sat, 26 Sep 2020 00:36:20 +0800 [thread overview]
Message-ID: <202009260047.ojDOQljH%lkp@intel.com> (raw)
In-Reply-To: <87pn6eb5tv.fsf@nanos.tec.linutronix.de>
[-- Attachment #1: Type: text/plain, Size: 8325 bytes --]
Hi Thomas,
I love your patch! Yet something to improve:
[auto build test ERROR on tip/master]
[also build test ERROR on tip/x86/asm linus/master v5.9-rc6]
[cannot apply to tip/x86/core next-20200925]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Thomas-Gleixner/x86-irq-Make-run_on_irqstack_cond-typesafe/20200922-160014
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 45c1c667ec05586335a6eaecbcb95733ff196274
config: i386-randconfig-a002-20200921 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/65df891c3f7e34199a0abea30babb0667efe5b74
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Thomas-Gleixner/x86-irq-Make-run_on_irqstack_cond-typesafe/20200922-160014
git checkout 65df891c3f7e34199a0abea30babb0667efe5b74
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from arch/x86/include/asm/idtentry.h:12,
from arch/x86/include/asm/traps.h:9,
from arch/x86/mm/fault.c:23:
arch/x86/include/asm/irq_stack.h: In function 'run_on_irqstack_cond':
>> arch/x86/include/asm/irq_stack.h:77:3: error: too few arguments to function '__run_on_irqstack'
77 | __run_on_irqstack(func);
| ^~~~~~~~~~~~~~~~~
arch/x86/include/asm/irq_stack.h:54:20: note: declared here
54 | static inline void __run_on_irqstack(void (*func)(void), void *arg) { }
| ^~~~~~~~~~~~~~~~~
--
In file included from arch/x86/include/asm/idtentry.h:12,
from arch/x86/include/asm/traps.h:9,
from arch/x86/mm/extable.c:9:
arch/x86/include/asm/irq_stack.h: In function 'run_on_irqstack_cond':
>> arch/x86/include/asm/irq_stack.h:77:3: error: too few arguments to function '__run_on_irqstack'
77 | __run_on_irqstack(func);
| ^~~~~~~~~~~~~~~~~
arch/x86/include/asm/irq_stack.h:54:20: note: declared here
54 | static inline void __run_on_irqstack(void (*func)(void), void *arg) { }
| ^~~~~~~~~~~~~~~~~
arch/x86/mm/extable.c: At top level:
arch/x86/mm/extable.c:27:16: warning: no previous prototype for 'ex_handler_default' [-Wmissing-prototypes]
27 | __visible bool ex_handler_default(const struct exception_table_entry *fixup,
| ^~~~~~~~~~~~~~~~~~
arch/x86/mm/extable.c:37:16: warning: no previous prototype for 'ex_handler_fault' [-Wmissing-prototypes]
37 | __visible bool ex_handler_fault(const struct exception_table_entry *fixup,
| ^~~~~~~~~~~~~~~~
arch/x86/mm/extable.c:58:16: warning: no previous prototype for 'ex_handler_fprestore' [-Wmissing-prototypes]
58 | __visible bool ex_handler_fprestore(const struct exception_table_entry *fixup,
| ^~~~~~~~~~~~~~~~~~~~
arch/x86/mm/extable.c:73:16: warning: no previous prototype for 'ex_handler_uaccess' [-Wmissing-prototypes]
73 | __visible bool ex_handler_uaccess(const struct exception_table_entry *fixup,
| ^~~~~~~~~~~~~~~~~~
arch/x86/mm/extable.c:84:16: warning: no previous prototype for 'ex_handler_rdmsr_unsafe' [-Wmissing-prototypes]
84 | __visible bool ex_handler_rdmsr_unsafe(const struct exception_table_entry *fixup,
| ^~~~~~~~~~~~~~~~~~~~~~~
arch/x86/mm/extable.c:101:16: warning: no previous prototype for 'ex_handler_wrmsr_unsafe' [-Wmissing-prototypes]
101 | __visible bool ex_handler_wrmsr_unsafe(const struct exception_table_entry *fixup,
| ^~~~~~~~~~~~~~~~~~~~~~~
arch/x86/mm/extable.c:117:16: warning: no previous prototype for 'ex_handler_clear_fs' [-Wmissing-prototypes]
117 | __visible bool ex_handler_clear_fs(const struct exception_table_entry *fixup,
| ^~~~~~~~~~~~~~~~~~~
--
In file included from arch/x86/include/asm/idtentry.h:12,
from arch/x86/include/asm/traps.h:9,
from arch/x86/entry/common.c:29:
arch/x86/include/asm/irq_stack.h: In function 'run_on_irqstack_cond':
>> arch/x86/include/asm/irq_stack.h:77:3: error: too few arguments to function '__run_on_irqstack'
77 | __run_on_irqstack(func);
| ^~~~~~~~~~~~~~~~~
arch/x86/include/asm/irq_stack.h:54:20: note: declared here
54 | static inline void __run_on_irqstack(void (*func)(void), void *arg) { }
| ^~~~~~~~~~~~~~~~~
arch/x86/entry/common.c: At top level:
arch/x86/entry/common.c:84:24: warning: no previous prototype for 'do_int80_syscall_32' [-Wmissing-prototypes]
84 | __visible noinstr void do_int80_syscall_32(struct pt_regs *regs)
| ^~~~~~~~~~~~~~~~~~~
arch/x86/entry/common.c:143:24: warning: no previous prototype for 'do_fast_syscall_32' [-Wmissing-prototypes]
143 | __visible noinstr long do_fast_syscall_32(struct pt_regs *regs)
| ^~~~~~~~~~~~~~~~~~
arch/x86/entry/common.c:195:24: warning: no previous prototype for 'do_SYSENTER_32' [-Wmissing-prototypes]
195 | __visible noinstr long do_SYSENTER_32(struct pt_regs *regs)
| ^~~~~~~~~~~~~~
--
In file included from arch/x86/include/asm/idtentry.h:12,
from arch/x86/include/asm/traps.h:9,
from arch/x86/kernel/doublefault_32.c:11:
arch/x86/include/asm/irq_stack.h: In function 'run_on_irqstack_cond':
>> arch/x86/include/asm/irq_stack.h:77:3: error: too few arguments to function '__run_on_irqstack'
77 | __run_on_irqstack(func);
| ^~~~~~~~~~~~~~~~~
arch/x86/include/asm/irq_stack.h:54:20: note: declared here
54 | static inline void __run_on_irqstack(void (*func)(void), void *arg) { }
| ^~~~~~~~~~~~~~~~~
arch/x86/kernel/doublefault_32.c: At top level:
arch/x86/kernel/doublefault_32.c:23:36: warning: no previous prototype for 'doublefault_shim' [-Wmissing-prototypes]
23 | asmlinkage noinstr void __noreturn doublefault_shim(void)
| ^~~~~~~~~~~~~~~~
arch/x86/kernel/doublefault_32.c:119:6: warning: no previous prototype for 'doublefault_init_cpu_tss' [-Wmissing-prototypes]
119 | void doublefault_init_cpu_tss(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~
--
In file included from arch/x86/include/asm/idtentry.h:12,
from arch/x86/include/asm/traps.h:9,
from arch/x86/kernel/kvm.c:31:
arch/x86/include/asm/irq_stack.h: In function 'run_on_irqstack_cond':
>> arch/x86/include/asm/irq_stack.h:77:3: error: too few arguments to function '__run_on_irqstack'
77 | __run_on_irqstack(func);
| ^~~~~~~~~~~~~~~~~
arch/x86/include/asm/irq_stack.h:54:20: note: declared here
54 | static inline void __run_on_irqstack(void (*func)(void), void *arg) { }
| ^~~~~~~~~~~~~~~~~
arch/x86/kernel/kvm.c: At top level:
arch/x86/kernel/kvm.c:876:16: warning: no previous prototype for '__kvm_vcpu_is_preempted' [-Wmissing-prototypes]
876 | __visible bool __kvm_vcpu_is_preempted(long cpu)
| ^~~~~~~~~~~~~~~~~~~~~~~
vim +/__run_on_irqstack +77 arch/x86/include/asm/irq_stack.h
69
70
71 static __always_inline void run_on_irqstack_cond(void (*func)(void),
72 struct pt_regs *regs)
73 {
74 lockdep_assert_irqs_disabled();
75
76 if (irq_needs_irq_stack(regs))
> 77 __run_on_irqstack(func);
78 else
79 func();
80 }
81
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 37793 bytes --]
prev parent reply other threads:[~2020-09-25 16:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 7:58 x86/irq: Make run_on_irqstack_cond() typesafe Thomas Gleixner
2020-09-22 18:45 ` Sami Tolvanen
2020-09-22 20:38 ` [tip: x86/urgent] " tip-bot2 for Thomas Gleixner
2020-09-23 19:19 ` Kees Cook
2020-09-23 19:36 ` Jann Horn
2020-09-25 16:36 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202009260047.ojDOQljH%lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.