From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5B38C47425 for ; Sat, 26 Sep 2020 04:25:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A34F12078B for ; Sat, 26 Sep 2020 04:25:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="D1xoiKND" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A34F12078B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 91E386ED98; Sat, 26 Sep 2020 04:25:15 +0000 (UTC) Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id AF24D6ED93 for ; Sat, 26 Sep 2020 04:25:06 +0000 (UTC) Received: by mail-pf1-x442.google.com with SMTP id z18so5075178pfg.0 for ; Fri, 25 Sep 2020 21:25:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vw5JB3RRsbohaer3Y56R1IPsXZfXmp2s3xn/82rJ0CY=; b=D1xoiKNDyt3hh17/hK6uqP4SAJ0L1P3/8IXEZSgrQKf9rBZXqkaliK02LneXiMkHGc hxYhfBZgNzpCVtoUOBPYp/QXx5X4/02K3L9IlZyEnsTLPVYvwP/uqLK4KsdUC+CbktyT 8DNFlax8CYkd9Trrqr9xoxsbV9QIMOilaXcPWav2ATUes6LDMvL85b+AkLVf6tvVHYom +Id89kS5caa8WGXDDtF5fDnl4RarlgFQyvitdpowCBq68FauqBrCZSuZArik8Bp9lmvK Fh0WjZM6QEhINjtqmgHLGVqCcIl0sx1uE4RQxjHaCKgOy70fCPRfjDyzqBwVCDnyFq3g I5WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vw5JB3RRsbohaer3Y56R1IPsXZfXmp2s3xn/82rJ0CY=; b=Kq+Z67e5El+adUx0UNrsTsaXlN5xq/OsrOJNOUY9UYau2iXBqd7us8hbDcfwPjzbrg BT8MGIWs2hd/3vjGfAL2bn3wzaQNF1faw2zOzEIJz89ho0QWiGfuFzxTT+gSrA2fPFPl s2Oo4InVLdNzd5o1rUpLrz694D1IowSyygjYSGawDt641li4WczcnbwfZxCmP8UOKX2O Q/IpPrgP+Uqg1MM51kXGACu8LohIbq373ry61UwB0iawb+0SOjwgKb5Rvb0PQalYxGSk h84YnYP+6KDXWq//m3ih6gWTtXbimf2GttBM7SN13jOAmKET45srowyH2bKkyrMFyFCm AgIg== X-Gm-Message-State: AOAM533RzTgQGemDcYy+aOoidKpMXY+G9B986NKmwyFUzEDfIuDKNoRf /qnw8foP6fq5Ytyf4s8zjAZUpQ== X-Google-Smtp-Source: ABdhPJyvQ50xfxJX8TpnL1MvlzaJmF3SWzncH/tqsov+stEHycC5jsIv3tQvdZov8P+AXKPfVqQiWA== X-Received: by 2002:a62:cd49:0:b029:150:7742:c6c8 with SMTP id o70-20020a62cd490000b02901507742c6c8mr2126731pfg.61.1601094306220; Fri, 25 Sep 2020 21:25:06 -0700 (PDT) Received: from localhost.localdomain ([2601:1c2:680:1319:692:26ff:feda:3a81]) by smtp.gmail.com with ESMTPSA id a5sm3585886pgk.13.2020.09.25.21.25.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Sep 2020 21:25:05 -0700 (PDT) From: John Stultz To: lkml Subject: [RFC][PATCH 6/6] dma-buf: heaps: Skip sync if not mapped Date: Sat, 26 Sep 2020 04:24:53 +0000 Message-Id: <20200926042453.67517-7-john.stultz@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200926042453.67517-1-john.stultz@linaro.org> References: <20200926042453.67517-1-john.stultz@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sandeep Patil , dri-devel@lists.freedesktop.org, Ezequiel Garcia , Robin Murphy , James Jones , Liam Mark , Laura Abbott , Hridya Valsaraju , =?UTF-8?q?=C3=98rjan=20Eide?= , Suren Baghdasaryan , linux-media@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" VGhpcyBwYXRjaCBpcyBiYXNpY2FsbHkgYSBwb3J0IG9mIMOYcmphbiBFaWRlJ3Mgc2ltaWxhciBw YXRjaCBmb3IgSU9OCiBodHRwczovL2xvcmUua2VybmVsLm9yZy9sa21sLzIwMjAwNDE0MTM0NjI5 LjU0NTY3LTEtb3JqYW4uZWlkZUBhcm0uY29tLwoKT25seSBzeW5jIHRoZSBzZy1saXN0IG9mIGRt YS1idWYgaGVhcCBhdHRhY2htZW50IHdoZW4gdGhlIGF0dGFjaG1lbnQKaXMgYWN0dWFsbHkgbWFw cGVkIG9uIHRoZSBkZXZpY2UuCgpkbWEtYnVmcyBtYXkgYmUgc3luY2VkIGF0IGFueSB0aW1lLiBJ dCBjYW4gYmUgcmVhY2hlZCBmcm9tIHVzZXIgc3BhY2UKdmlhIERNQV9CVUZfSU9DVExfU1lOQywg c28gdGhlcmUgYXJlIG5vIGd1YXJhbnRlZXMgZnJvbSBjYWxsZXJzIG9uIHdoZW4Kc3luY3MgbWF5 IGJlIGF0dGVtcHRlZCwgYW5kIGRtYV9idWZfZW5kX2NwdV9hY2Nlc3MoKSBhbmQKZG1hX2J1Zl9i ZWdpbl9jcHVfYWNjZXNzKCkgbWF5IG5vdCBiZSBwYWlyZWQuCgpTaW5jZSB0aGUgc2dfbGlzdCdz IGRtYV9hZGRyZXNzIGlzbid0IHNldCB1cCB1bnRpbCB0aGUgYnVmZmVyIGlzIHVzZWQKb24gdGhl IGRldmljZSwgYW5kIGRtYV9tYXBfc2coKSBpcyBjYWxsZWQgb24gaXQsIHRoZSBkbWFfYWRkcmVz cyB3aWxsIGJlCk5VTEwgaWYgc3luYyBpcyBhdHRlbXB0ZWQgb24gdGhlIGRtYS1idWYgYmVmb3Jl IGl0J3MgbWFwcGVkIG9uIGEgZGV2aWNlLgoKQmVmb3JlIHY1LjAgKGNvbW1pdCA1NTg5N2FmNjMw OTEgKCJkbWEtZGlyZWN0OiBtZXJnZSBzd2lvdGxiX2RtYV9vcHMKaW50byB0aGUgZG1hX2RpcmVj dCBjb2RlIikpIHRoaXMgd2FzIGEgcHJvYmxlbSBhcyB0aGUgZG1hLWFwaSAoYXQgbGVhc3QKdGhl IHN3aW90bGJfZG1hX29wcyBvbiBhcm02NCkgd291bGQgdXNlIHRoZSBwb3RlbnRpYWxseSBpbnZh bGlkCmRtYV9hZGRyZXNzLiBIb3cgdGhhdCBmYWlsZWQgZGVwZW5kZWQgb24gaG93IHRoZSBkZXZp Y2UgaGFuZGxlZCBwaHlzaWNhbAphZGRyZXNzIDAuIElmIDAgd2FzIGEgdmFsaWQgYWRkcmVzcyB0 byBwaHlzaWNhbCByYW0sIHRoYXQgcGFnZSB3b3VsZCBnZXQKZmx1c2hlZCBhIGxvdCwgd2hpbGUg dGhlIGFjdHVhbCBwYWdlcyBpbiB0aGUgYnVmZmVyIHdvdWxkIG5vdCBnZXQgc3luY2VkCmNvcnJl Y3RseS4gV2hpbGUgaWYgMCBpcyBhbiBpbnZhbGlkIHBoeXNpY2FsIGFkZHJlc3MgaXQgbWF5IGNh dXNlIGEKZmF1bHQgYW5kIHRyaWdnZXIgYSBjcmFzaC4KCkluIHY1LjAgdGhpcyB3YXMgaW5jaWRl bnRhbGx5IGZpeGVkIGJ5IGNvbW1pdCA1NTg5N2FmNjMwOTEgKCJkbWEtZGlyZWN0OgptZXJnZSBz d2lvdGxiX2RtYV9vcHMgaW50byB0aGUgZG1hX2RpcmVjdCBjb2RlIiksIGFzIHRoaXMgbW92ZWQg dGhlCmRtYS1hcGkgdG8gdXNlIHRoZSBwYWdlIHBvaW50ZXIgaW4gdGhlIHNnX2xpc3QsIGFuZCAo Zm9yIElvbiBidWZmZXJzIGF0CmxlYXN0KSB0aGlzIHdpbGwgYWx3YXlzIGJlIHZhbGlkIGlmIHRo ZSBzZ19saXN0IGV4aXN0cyBhdCBhbGwuCgpCdXQsIHRoaXMgaXNzdWUgaXMgcmUtaW50cm9kdWNl ZCBpbiB2NS4zIHdpdGgKY29tbWl0IDQ0OWZhNTRkNjgxNSAoImRtYS1kaXJlY3Q6IGNvcnJlY3Qg dGhlIHBoeXNpY2FsIGFkZHIgaW4KZG1hX2RpcmVjdF9zeW5jX3NnX2Zvcl9jcHUvZGV2aWNlIikg bW92ZXMgdGhlIGRtYS1hcGkgYmFjayB0byB0aGUgb2xkCmJlaGF2aW91ciBhbmQgcGlja3MgdGhl IGRtYV9hZGRyZXNzIHRoYXQgbWF5IGJlIGludmFsaWQuCgpkbWEtYnVmIGNvcmUgZG9lc24ndCBl bnN1cmUgdGhhdCB0aGUgYnVmZmVyIGlzIG1hcHBlZCBvbiB0aGUgZGV2aWNlLCBhbmQKdGh1cyBo YXZlIGEgdmFsaWQgc2dfbGlzdCwgYmVmb3JlIGNhbGxpbmcgdGhlIGV4cG9ydGVyJ3MKYmVnaW5f Y3B1X2FjY2Vzcy4KCkxvZ2ljIGFuZCBjb21taXQgbWVzc2FnZSBvcmlnaW5hbGx5IGJ5OiDDmHJq YW4gRWlkZSA8b3JqYW4uZWlkZUBhcm0uY29tPgoKQ2M6IFN1bWl0IFNlbXdhbCA8c3VtaXQuc2Vt d2FsQGxpbmFyby5vcmc+CkNjOiBMaWFtIE1hcmsgPGxtYXJrQGNvZGVhdXJvcmEub3JnPgpDYzog TGF1cmEgQWJib3R0IDxsYWJib3R0QGtlcm5lbC5vcmc+CkNjOiBCcmlhbiBTdGFya2V5IDxCcmlh bi5TdGFya2V5QGFybS5jb20+CkNjOiBIcmlkeWEgVmFsc2FyYWp1IDxocmlkeWFAZ29vZ2xlLmNv bT4KQ2M6IFN1cmVuIEJhZ2hkYXNhcnlhbiA8c3VyZW5iQGdvb2dsZS5jb20+CkNjOiBTYW5kZWVw IFBhdGlsIDxzc3BhdGlsQGdvb2dsZS5jb20+CkNjOiDDmHJqYW4gRWlkZSA8b3JqYW4uZWlkZUBh cm0uY29tPgpDYzogUm9iaW4gTXVycGh5IDxyb2Jpbi5tdXJwaHlAYXJtLmNvbT4KQ2M6IEV6ZXF1 aWVsIEdhcmNpYSA8ZXplcXVpZWxAY29sbGFib3JhLmNvbT4KQ2M6IFNpbW9uIFNlciA8Y29udGFj dEBlbWVyc2lvbi5mcj4KQ2M6IEphbWVzIEpvbmVzIDxqYWpvbmVzQG52aWRpYS5jb20+CkNjOiBs aW51eC1tZWRpYUB2Z2VyLmtlcm5lbC5vcmcKQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKU2lnbmVkLW9mZi1ieTogSm9obiBTdHVsdHogPGpvaG4uc3R1bHR6QGxpbmFyby5vcmc+ Ci0tLQogZHJpdmVycy9kbWEtYnVmL2hlYXBzL2NtYV9oZWFwLmMgICAgfCAxMCArKysrKysrKysr CiBkcml2ZXJzL2RtYS1idWYvaGVhcHMvc3lzdGVtX2hlYXAuYyB8IDEwICsrKysrKysrKysKIDIg ZmlsZXMgY2hhbmdlZCwgMjAgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZG1h LWJ1Zi9oZWFwcy9jbWFfaGVhcC5jIGIvZHJpdmVycy9kbWEtYnVmL2hlYXBzL2NtYV9oZWFwLmMK aW5kZXggM2FkZmRiZWQwODI5Li5iNmFiMDM5MmFkOWEgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZG1h LWJ1Zi9oZWFwcy9jbWFfaGVhcC5jCisrKyBiL2RyaXZlcnMvZG1hLWJ1Zi9oZWFwcy9jbWFfaGVh cC5jCkBAIC00NCw2ICs0NCw3IEBAIHN0cnVjdCBkbWFfaGVhcF9hdHRhY2htZW50IHsKIAlzdHJ1 Y3QgZGV2aWNlICpkZXY7CiAJc3RydWN0IHNnX3RhYmxlIHRhYmxlOwogCXN0cnVjdCBsaXN0X2hl YWQgbGlzdDsKKwlib29sIG1hcHBlZDsKIH07CiAKIHN0YXRpYyBpbnQgY21hX2hlYXBfYXR0YWNo KHN0cnVjdCBkbWFfYnVmICpkbWFidWYsCkBAIC02OCw2ICs2OSw3IEBAIHN0YXRpYyBpbnQgY21h X2hlYXBfYXR0YWNoKHN0cnVjdCBkbWFfYnVmICpkbWFidWYsCiAKIAlhLT5kZXYgPSBhdHRhY2ht ZW50LT5kZXY7CiAJSU5JVF9MSVNUX0hFQUQoJmEtPmxpc3QpOworCWEtPm1hcHBlZCA9IGZhbHNl OwogCiAJYXR0YWNobWVudC0+cHJpdiA9IGE7CiAKQEAgLTEwMSw2ICsxMDMsNyBAQCBzdGF0aWMg c3RydWN0IHNnX3RhYmxlICpjbWFfaGVhcF9tYXBfZG1hX2J1ZihzdHJ1Y3QgZG1hX2J1Zl9hdHRh Y2htZW50ICphdHRhY2htZQogCWlmICghZG1hX21hcF9zZyhhdHRhY2htZW50LT5kZXYsIHRhYmxl LT5zZ2wsIHRhYmxlLT5uZW50cywKIAkJCWRpcmVjdGlvbikpCiAJCXRhYmxlID0gRVJSX1BUUigt RU5PTUVNKTsKKwlhLT5tYXBwZWQgPSB0cnVlOwogCXJldHVybiB0YWJsZTsKIH0KIApAQCAtMTA4 LDYgKzExMSw5IEBAIHN0YXRpYyB2b2lkIGNtYV9oZWFwX3VubWFwX2RtYV9idWYoc3RydWN0IGRt YV9idWZfYXR0YWNobWVudCAqYXR0YWNobWVudCwKIAkJCQkgICBzdHJ1Y3Qgc2dfdGFibGUgKnRh YmxlLAogCQkJCSAgIGVudW0gZG1hX2RhdGFfZGlyZWN0aW9uIGRpcmVjdGlvbikKIHsKKwlzdHJ1 Y3QgZG1hX2hlYXBfYXR0YWNobWVudCAqYSA9IGF0dGFjaG1lbnQtPnByaXY7CisKKwlhLT5tYXBw ZWQgPSBmYWxzZTsKIAlkbWFfdW5tYXBfc2coYXR0YWNobWVudC0+ZGV2LCB0YWJsZS0+c2dsLCB0 YWJsZS0+bmVudHMsIGRpcmVjdGlvbik7CiB9CiAKQEAgLTEyMyw2ICsxMjksOCBAQCBzdGF0aWMg aW50IGNtYV9oZWFwX2RtYV9idWZfYmVnaW5fY3B1X2FjY2VzcyhzdHJ1Y3QgZG1hX2J1ZiAqZG1h YnVmLAogCiAJbXV0ZXhfbG9jaygmYnVmZmVyLT5sb2NrKTsKIAlsaXN0X2Zvcl9lYWNoX2VudHJ5 KGEsICZidWZmZXItPmF0dGFjaG1lbnRzLCBsaXN0KSB7CisJCWlmICghYS0+bWFwcGVkKQorCQkJ Y29udGludWU7CiAJCWRtYV9zeW5jX3NnX2Zvcl9jcHUoYS0+ZGV2LCBhLT50YWJsZS5zZ2wsIGEt PnRhYmxlLm5lbnRzLAogCQkJCSAgICBkaXJlY3Rpb24pOwogCX0KQEAgLTE0Miw2ICsxNTAsOCBA QCBzdGF0aWMgaW50IGNtYV9oZWFwX2RtYV9idWZfZW5kX2NwdV9hY2Nlc3Moc3RydWN0IGRtYV9i dWYgKmRtYWJ1ZiwKIAogCW11dGV4X2xvY2soJmJ1ZmZlci0+bG9jayk7CiAJbGlzdF9mb3JfZWFj aF9lbnRyeShhLCAmYnVmZmVyLT5hdHRhY2htZW50cywgbGlzdCkgeworCQlpZiAoIWEtPm1hcHBl ZCkKKwkJCWNvbnRpbnVlOwogCQlkbWFfc3luY19zZ19mb3JfZGV2aWNlKGEtPmRldiwgYS0+dGFi bGUuc2dsLCBhLT50YWJsZS5uZW50cywKIAkJCQkgICAgICAgZGlyZWN0aW9uKTsKIAl9CmRpZmYg LS1naXQgYS9kcml2ZXJzL2RtYS1idWYvaGVhcHMvc3lzdGVtX2hlYXAuYyBiL2RyaXZlcnMvZG1h LWJ1Zi9oZWFwcy9zeXN0ZW1faGVhcC5jCmluZGV4IDlmNTdiNGM4YWU2OS4uOGE1MjNiNmZkNTFh IDEwMDY0NAotLS0gYS9kcml2ZXJzL2RtYS1idWYvaGVhcHMvc3lzdGVtX2hlYXAuYworKysgYi9k cml2ZXJzL2RtYS1idWYvaGVhcHMvc3lzdGVtX2hlYXAuYwpAQCAtMzgsNiArMzgsNyBAQCBzdHJ1 Y3QgZG1hX2hlYXBfYXR0YWNobWVudCB7CiAJc3RydWN0IGRldmljZSAqZGV2OwogCXN0cnVjdCBz Z190YWJsZSAqdGFibGU7CiAJc3RydWN0IGxpc3RfaGVhZCBsaXN0OworCWJvb2wgbWFwcGVkOwog fTsKIAogI2RlZmluZSBISUdIX09SREVSX0dGUCAgKCgoR0ZQX0hJR0hVU0VSIHwgX19HRlBfWkVS TyB8IF9fR0ZQX05PV0FSTiBcCkBAIC05NCw2ICs5NSw3IEBAIHN0YXRpYyBpbnQgc3lzdGVtX2hl YXBfYXR0YWNoKHN0cnVjdCBkbWFfYnVmICpkbWFidWYsCiAJYS0+dGFibGUgPSB0YWJsZTsKIAlh LT5kZXYgPSBhdHRhY2htZW50LT5kZXY7CiAJSU5JVF9MSVNUX0hFQUQoJmEtPmxpc3QpOworCWEt Pm1hcHBlZCA9IGZhbHNlOwogCiAJYXR0YWNobWVudC0+cHJpdiA9IGE7CiAKQEAgLTEyOCw2ICsx MzAsNyBAQCBzdGF0aWMgc3RydWN0IHNnX3RhYmxlICpzeXN0ZW1faGVhcF9tYXBfZG1hX2J1Zihz dHJ1Y3QgZG1hX2J1Zl9hdHRhY2htZW50ICphdHRhYwogCWlmICghZG1hX21hcF9zZyhhdHRhY2ht ZW50LT5kZXYsIHRhYmxlLT5zZ2wsIHRhYmxlLT5uZW50cywgZGlyZWN0aW9uKSkKIAkJcmV0dXJu IEVSUl9QVFIoLUVOT01FTSk7CiAKKwlhLT5tYXBwZWQgPSB0cnVlOwogCXJldHVybiB0YWJsZTsK IH0KIApAQCAtMTM1LDYgKzEzOCw5IEBAIHN0YXRpYyB2b2lkIHN5c3RlbV9oZWFwX3VubWFwX2Rt YV9idWYoc3RydWN0IGRtYV9idWZfYXR0YWNobWVudCAqYXR0YWNobWVudCwKIAkJCQkgICAgICBz dHJ1Y3Qgc2dfdGFibGUgKnRhYmxlLAogCQkJCSAgICAgIGVudW0gZG1hX2RhdGFfZGlyZWN0aW9u IGRpcmVjdGlvbikKIHsKKwlzdHJ1Y3QgZG1hX2hlYXBfYXR0YWNobWVudCAqYSA9IGF0dGFjaG1l bnQtPnByaXY7CisKKwlhLT5tYXBwZWQgPSBmYWxzZTsKIAlkbWFfdW5tYXBfc2coYXR0YWNobWVu dC0+ZGV2LCB0YWJsZS0+c2dsLCB0YWJsZS0+bmVudHMsIGRpcmVjdGlvbik7CiB9CiAKQEAgLTE1 MSw2ICsxNTcsOCBAQCBzdGF0aWMgaW50IHN5c3RlbV9oZWFwX2RtYV9idWZfYmVnaW5fY3B1X2Fj Y2VzcyhzdHJ1Y3QgZG1hX2J1ZiAqZG1hYnVmLAogCQlpbnZhbGlkYXRlX2tlcm5lbF92bWFwX3Jh bmdlKGJ1ZmZlci0+dmFkZHIsIGJ1ZmZlci0+bGVuKTsKIAogCWxpc3RfZm9yX2VhY2hfZW50cnko YSwgJmJ1ZmZlci0+YXR0YWNobWVudHMsIGxpc3QpIHsKKwkJaWYgKCFhLT5tYXBwZWQpCisJCQlj b250aW51ZTsKIAkJZG1hX3N5bmNfc2dfZm9yX2NwdShhLT5kZXYsIGEtPnRhYmxlLT5zZ2wsIGEt PnRhYmxlLT5uZW50cywKIAkJCQkgICAgZGlyZWN0aW9uKTsKIAl9CkBAIC0xNzEsNiArMTc5LDgg QEAgc3RhdGljIGludCBzeXN0ZW1faGVhcF9kbWFfYnVmX2VuZF9jcHVfYWNjZXNzKHN0cnVjdCBk bWFfYnVmICpkbWFidWYsCiAJCWZsdXNoX2tlcm5lbF92bWFwX3JhbmdlKGJ1ZmZlci0+dmFkZHIs IGJ1ZmZlci0+bGVuKTsKIAogCWxpc3RfZm9yX2VhY2hfZW50cnkoYSwgJmJ1ZmZlci0+YXR0YWNo bWVudHMsIGxpc3QpIHsKKwkJaWYgKCFhLT5tYXBwZWQpCisJCQljb250aW51ZTsKIAkJZG1hX3N5 bmNfc2dfZm9yX2RldmljZShhLT5kZXYsIGEtPnRhYmxlLT5zZ2wsIGEtPnRhYmxlLT5uZW50cywK IAkJCQkgICAgICAgZGlyZWN0aW9uKTsKIAl9Ci0tIAoyLjE3LjEKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29430C47420 for ; Sat, 26 Sep 2020 04:25:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E6E092078B for ; Sat, 26 Sep 2020 04:25:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="D1xoiKND" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730056AbgIZEZO (ORCPT ); Sat, 26 Sep 2020 00:25:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730041AbgIZEZM (ORCPT ); Sat, 26 Sep 2020 00:25:12 -0400 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5BFFC0613D8 for ; Fri, 25 Sep 2020 21:25:06 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id 5so4155944pgf.5 for ; Fri, 25 Sep 2020 21:25:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vw5JB3RRsbohaer3Y56R1IPsXZfXmp2s3xn/82rJ0CY=; b=D1xoiKNDyt3hh17/hK6uqP4SAJ0L1P3/8IXEZSgrQKf9rBZXqkaliK02LneXiMkHGc hxYhfBZgNzpCVtoUOBPYp/QXx5X4/02K3L9IlZyEnsTLPVYvwP/uqLK4KsdUC+CbktyT 8DNFlax8CYkd9Trrqr9xoxsbV9QIMOilaXcPWav2ATUes6LDMvL85b+AkLVf6tvVHYom +Id89kS5caa8WGXDDtF5fDnl4RarlgFQyvitdpowCBq68FauqBrCZSuZArik8Bp9lmvK Fh0WjZM6QEhINjtqmgHLGVqCcIl0sx1uE4RQxjHaCKgOy70fCPRfjDyzqBwVCDnyFq3g I5WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vw5JB3RRsbohaer3Y56R1IPsXZfXmp2s3xn/82rJ0CY=; b=W6/StzpCMwxR2M2sBIx54Mm7qnXmk408QKUC5IGOxUyBJUi+6sjHR4cD2lGod5wZ6q 3o2bHOqjNNnyNxe739aUHZwr6KrFZ285j/XAzR4CoDWBlpTH8B6Z3NtN8x99G+0VtsgA NPwa4IQGrO/UdkgYO62y/VBVIH1vdbXOD1o2nQ0CycC1Cm67LxXiuthczHhhdJLY1O6C SOevSElbflQ43g6n0yOMEpcZLZcGRt/5ZbJIgMDYhfoLYO7+AVcfqYhIaNg+AaN9qlvQ XOGx7ZFvGxCGYk2PKvVDC3/K9RVmDEtAGGMYZfJ39WqbsKsouytt8I1SnbxYcM+wxvfp 2clQ== X-Gm-Message-State: AOAM531byRUED82CYfm9Ho/xYxIYGzdgYdGxrtX+4dK87SAmzVGWtDCR pNSC6aRmDI/hAcaJxEHlGh6BZg== X-Google-Smtp-Source: ABdhPJyvQ50xfxJX8TpnL1MvlzaJmF3SWzncH/tqsov+stEHycC5jsIv3tQvdZov8P+AXKPfVqQiWA== X-Received: by 2002:a62:cd49:0:b029:150:7742:c6c8 with SMTP id o70-20020a62cd490000b02901507742c6c8mr2126731pfg.61.1601094306220; Fri, 25 Sep 2020 21:25:06 -0700 (PDT) Received: from localhost.localdomain ([2601:1c2:680:1319:692:26ff:feda:3a81]) by smtp.gmail.com with ESMTPSA id a5sm3585886pgk.13.2020.09.25.21.25.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Sep 2020 21:25:05 -0700 (PDT) From: John Stultz To: lkml Cc: John Stultz , Sumit Semwal , Liam Mark , Laura Abbott , Brian Starkey , Hridya Valsaraju , Suren Baghdasaryan , Sandeep Patil , =?UTF-8?q?=C3=98rjan=20Eide?= , Robin Murphy , Ezequiel Garcia , Simon Ser , James Jones , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [RFC][PATCH 6/6] dma-buf: heaps: Skip sync if not mapped Date: Sat, 26 Sep 2020 04:24:53 +0000 Message-Id: <20200926042453.67517-7-john.stultz@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200926042453.67517-1-john.stultz@linaro.org> References: <20200926042453.67517-1-john.stultz@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org This patch is basically a port of Ørjan Eide's similar patch for ION https://lore.kernel.org/lkml/20200414134629.54567-1-orjan.eide@arm.com/ Only sync the sg-list of dma-buf heap attachment when the attachment is actually mapped on the device. dma-bufs may be synced at any time. It can be reached from user space via DMA_BUF_IOCTL_SYNC, so there are no guarantees from callers on when syncs may be attempted, and dma_buf_end_cpu_access() and dma_buf_begin_cpu_access() may not be paired. Since the sg_list's dma_address isn't set up until the buffer is used on the device, and dma_map_sg() is called on it, the dma_address will be NULL if sync is attempted on the dma-buf before it's mapped on a device. Before v5.0 (commit 55897af63091 ("dma-direct: merge swiotlb_dma_ops into the dma_direct code")) this was a problem as the dma-api (at least the swiotlb_dma_ops on arm64) would use the potentially invalid dma_address. How that failed depended on how the device handled physical address 0. If 0 was a valid address to physical ram, that page would get flushed a lot, while the actual pages in the buffer would not get synced correctly. While if 0 is an invalid physical address it may cause a fault and trigger a crash. In v5.0 this was incidentally fixed by commit 55897af63091 ("dma-direct: merge swiotlb_dma_ops into the dma_direct code"), as this moved the dma-api to use the page pointer in the sg_list, and (for Ion buffers at least) this will always be valid if the sg_list exists at all. But, this issue is re-introduced in v5.3 with commit 449fa54d6815 ("dma-direct: correct the physical addr in dma_direct_sync_sg_for_cpu/device") moves the dma-api back to the old behaviour and picks the dma_address that may be invalid. dma-buf core doesn't ensure that the buffer is mapped on the device, and thus have a valid sg_list, before calling the exporter's begin_cpu_access. Logic and commit message originally by: Ørjan Eide Cc: Sumit Semwal Cc: Liam Mark Cc: Laura Abbott Cc: Brian Starkey Cc: Hridya Valsaraju Cc: Suren Baghdasaryan Cc: Sandeep Patil Cc: Ørjan Eide Cc: Robin Murphy Cc: Ezequiel Garcia Cc: Simon Ser Cc: James Jones Cc: linux-media@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: John Stultz --- drivers/dma-buf/heaps/cma_heap.c | 10 ++++++++++ drivers/dma-buf/heaps/system_heap.c | 10 ++++++++++ 2 files changed, 20 insertions(+) diff --git a/drivers/dma-buf/heaps/cma_heap.c b/drivers/dma-buf/heaps/cma_heap.c index 3adfdbed0829..b6ab0392ad9a 100644 --- a/drivers/dma-buf/heaps/cma_heap.c +++ b/drivers/dma-buf/heaps/cma_heap.c @@ -44,6 +44,7 @@ struct dma_heap_attachment { struct device *dev; struct sg_table table; struct list_head list; + bool mapped; }; static int cma_heap_attach(struct dma_buf *dmabuf, @@ -68,6 +69,7 @@ static int cma_heap_attach(struct dma_buf *dmabuf, a->dev = attachment->dev; INIT_LIST_HEAD(&a->list); + a->mapped = false; attachment->priv = a; @@ -101,6 +103,7 @@ static struct sg_table *cma_heap_map_dma_buf(struct dma_buf_attachment *attachme if (!dma_map_sg(attachment->dev, table->sgl, table->nents, direction)) table = ERR_PTR(-ENOMEM); + a->mapped = true; return table; } @@ -108,6 +111,9 @@ static void cma_heap_unmap_dma_buf(struct dma_buf_attachment *attachment, struct sg_table *table, enum dma_data_direction direction) { + struct dma_heap_attachment *a = attachment->priv; + + a->mapped = false; dma_unmap_sg(attachment->dev, table->sgl, table->nents, direction); } @@ -123,6 +129,8 @@ static int cma_heap_dma_buf_begin_cpu_access(struct dma_buf *dmabuf, mutex_lock(&buffer->lock); list_for_each_entry(a, &buffer->attachments, list) { + if (!a->mapped) + continue; dma_sync_sg_for_cpu(a->dev, a->table.sgl, a->table.nents, direction); } @@ -142,6 +150,8 @@ static int cma_heap_dma_buf_end_cpu_access(struct dma_buf *dmabuf, mutex_lock(&buffer->lock); list_for_each_entry(a, &buffer->attachments, list) { + if (!a->mapped) + continue; dma_sync_sg_for_device(a->dev, a->table.sgl, a->table.nents, direction); } diff --git a/drivers/dma-buf/heaps/system_heap.c b/drivers/dma-buf/heaps/system_heap.c index 9f57b4c8ae69..8a523b6fd51a 100644 --- a/drivers/dma-buf/heaps/system_heap.c +++ b/drivers/dma-buf/heaps/system_heap.c @@ -38,6 +38,7 @@ struct dma_heap_attachment { struct device *dev; struct sg_table *table; struct list_head list; + bool mapped; }; #define HIGH_ORDER_GFP (((GFP_HIGHUSER | __GFP_ZERO | __GFP_NOWARN \ @@ -94,6 +95,7 @@ static int system_heap_attach(struct dma_buf *dmabuf, a->table = table; a->dev = attachment->dev; INIT_LIST_HEAD(&a->list); + a->mapped = false; attachment->priv = a; @@ -128,6 +130,7 @@ static struct sg_table *system_heap_map_dma_buf(struct dma_buf_attachment *attac if (!dma_map_sg(attachment->dev, table->sgl, table->nents, direction)) return ERR_PTR(-ENOMEM); + a->mapped = true; return table; } @@ -135,6 +138,9 @@ static void system_heap_unmap_dma_buf(struct dma_buf_attachment *attachment, struct sg_table *table, enum dma_data_direction direction) { + struct dma_heap_attachment *a = attachment->priv; + + a->mapped = false; dma_unmap_sg(attachment->dev, table->sgl, table->nents, direction); } @@ -151,6 +157,8 @@ static int system_heap_dma_buf_begin_cpu_access(struct dma_buf *dmabuf, invalidate_kernel_vmap_range(buffer->vaddr, buffer->len); list_for_each_entry(a, &buffer->attachments, list) { + if (!a->mapped) + continue; dma_sync_sg_for_cpu(a->dev, a->table->sgl, a->table->nents, direction); } @@ -171,6 +179,8 @@ static int system_heap_dma_buf_end_cpu_access(struct dma_buf *dmabuf, flush_kernel_vmap_range(buffer->vaddr, buffer->len); list_for_each_entry(a, &buffer->attachments, list) { + if (!a->mapped) + continue; dma_sync_sg_for_device(a->dev, a->table->sgl, a->table->nents, direction); } -- 2.17.1