All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Richard W.M. Jones" <rjones@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	pkrempa@redhat.com, qemu-block@nongnu.org,
	Markus Armbruster <armbru@redhat.com>,
	qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
	vsementsov@virtuozzo.com
Subject: Re: [PATCH 3/3] nbd: Add 'qemu-nbd -A' to expose allocation depth
Date: Sat, 26 Sep 2020 08:34:57 +0100	[thread overview]
Message-ID: <20200926073457.GW3888@redhat.com> (raw)
In-Reply-To: <20200925203249.155705-4-eblake@redhat.com>

On Fri, Sep 25, 2020 at 03:32:49PM -0500, Eric Blake wrote:
> Allow the server to expose an additional metacontext to be requested
> by savvy clients.  qemu-nbd adds a new option -A to expose the
> qemu:allocation-depth metacontext through NBD_CMD_BLOCK_STATUS; this
> can also be set via QMP when using nbd-server-add.
> 
> qemu as client can be hacked into viewing this new context by using
> the now-misnamed x-dirty-bitmap option when creating an NBD blockdev;
> although it is worth noting the decoding of how such context
> information will appear in 'qemu-img map --output=json':
> 
> NBD_STATE_DEPTH_UNALLOC => "zero":false, "data":true
> NBD_STATE_DEPTH_LOCAL => "zero":false, "data":false
> NBD_STATE_DEPTH_BACKING => "zero":true, "data":true
> 
> libnbd as client is probably a nicer way to get at the information
> without having to decipher such hacks in qemu as client. ;)

I've been meaning to add extents information to nbdinfo, or
perhaps a new tool ("nbdmap").

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html



  reply	other threads:[~2020-09-26  7:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-25 20:32 [PATCH 0/3] Exposing backing-chain allocation over NBD Eric Blake
2020-09-25 20:32 ` [PATCH 1/3] nbd: Simplify meta-context parsing Eric Blake
2020-09-26 12:58   ` Vladimir Sementsov-Ogievskiy
2020-09-28 14:05     ` Eric Blake
2020-09-25 20:32 ` [PATCH 2/3] nbd: Add new qemu:allocation-depth metacontext Eric Blake
2020-09-26  7:33   ` Richard W.M. Jones
2020-09-26 13:19     ` Vladimir Sementsov-Ogievskiy
2020-09-28 14:33     ` Eric Blake
2020-09-28 16:17       ` Richard W.M. Jones
2020-09-26 13:15   ` Vladimir Sementsov-Ogievskiy
2020-09-25 20:32 ` [PATCH 3/3] nbd: Add 'qemu-nbd -A' to expose allocation depth Eric Blake
2020-09-26  7:34   ` Richard W.M. Jones [this message]
2020-09-26 13:32   ` Vladimir Sementsov-Ogievskiy
2020-09-28 14:35     ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200926073457.GW3888@redhat.com \
    --to=rjones@redhat.com \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pkrempa@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.