From: Sean Young <sean@mess.org>
To: Michael Zimmermann <sigmaepsilon92@gmail.com>
Cc: linux-media@vger.kernel.org
Subject: Re: ITE8708 on ASUS PN50 uses a 16 byte io region
Date: Sat, 26 Sep 2020 12:30:39 +0100 [thread overview]
Message-ID: <20200926113038.GA23934@gofer.mess.org> (raw)
In-Reply-To: <CAN9vWDL5rK_UCi-dTUG_Si7MbVSB4hVjvhs1-TEgvdGi+ajUvQ@mail.gmail.com>
On Sat, Sep 26, 2020 at 10:22:46AM +0200, Michael Zimmermann wrote:
> Hi,
>
> here's the resource descriptor from my DSDT:
> Name (BUF0, ResourceTemplate ()
> {
> IO (Decode16,
> 0x0000, // Range Minimum
> 0x0000, // Range Maximum
> 0x01, // Alignment
> 0x10, // Length
> _Y1A)
> IRQNoFlags (_Y1B)
> {}
> DMA (Compatibility, NotBusMaster, Transfer8, )
> {}
> })
>
> As you can see it uses 16 bytes for the IO region while the driver
> drivers/media/rc/ite-cir.c expects 8.
> I don't see any obvious reason why they do that since they only seem
> to write two words in there, and if I edit the DSDT to change the
> length from 0x10 to 0x8 the linux driver detects the device properly
> it works just fine.
>
> So is this a bug on ASUS' side or should we just accept longer regions
> for the same device type?
So looking at the driver, some devices do have an io region of 16 and
others expect 8. See the io_region_size field of ite_dev_descs.
So for ITE8708 the io_region_size is set to 8. Does your device really
have an ITE8708 or is the DSDT wrong?
Sean
next prev parent reply other threads:[~2020-09-26 11:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-26 8:22 ITE8708 on ASUS PN50 uses a 16 byte io region Michael Zimmermann
2020-09-26 11:30 ` Sean Young [this message]
2020-09-26 12:32 ` Michael Zimmermann
2020-09-26 13:33 ` Sean Young
2020-09-26 14:18 ` Michael Zimmermann
2020-09-26 22:03 ` Sean Young
2020-11-17 21:47 ` Michael Zimmermann
2020-11-18 12:15 ` Sean Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200926113038.GA23934@gofer.mess.org \
--to=sean@mess.org \
--cc=linux-media@vger.kernel.org \
--cc=sigmaepsilon92@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.