From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C602DC2D0A8 for ; Sat, 26 Sep 2020 13:42:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A9D3208FE for ; Sat, 26 Sep 2020 13:42:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601127726; bh=R2o851xlrMbT5AM6HeqrOEyH1/cK9XlIfIpibkNMzr4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=SoPTcwqwGxETc07Ww2/5pQxXL5SV2wvj8opJN+eo9jNhnwvPXPH8QjvAyqkuLwBL+ 8YFgwhfGwgIR+U/X+Ex/qU4cuSqmXhQgRW7sbnzmDXSDkCRfeUkvQOpCsKVMgIJftY b0m+fElv0uVrf+FK42RqGWx10PbOEgzHtM5nvZuM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726183AbgIZNmG convert rfc822-to-8bit (ORCPT ); Sat, 26 Sep 2020 09:42:06 -0400 Received: from mail-ej1-f66.google.com ([209.85.218.66]:33065 "EHLO mail-ej1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725208AbgIZNmG (ORCPT ); Sat, 26 Sep 2020 09:42:06 -0400 Received: by mail-ej1-f66.google.com with SMTP id j11so2410399ejk.0; Sat, 26 Sep 2020 06:42:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=zZiC4GFLiCyxWh5u5vGAPSFiD3LqckqVR10/0vflwwg=; b=pmE6FomZalVD8bPNjs20hMVtM9tKotvYkEsVO8i/aIPTM/HjNpSdzyRTs011mLq2W6 htrpJzJeqgILNV9M+w/M9teLtUwzka9sx4EkAsae7hXCZs9kuJDnvAjwVzXlrzWj+AKD 4Zd5Tj3QGQCCrxrDsztSSUSwHGWkSfdjw+qX+geDCg8pQ2Wj2GDwAutWQSjjXswoSwIc DBGP3toCtf5FkUEptqsiQQ15ZVzYfQIOmc2Yx95/WWK67vQCtYwJ8DVXvJHkP721QvEy ImBCNSYM0xbL4B3vv+uUDXzytm1gBRJ88GL3hDngJxRHhbK4aDcwwU9A8Y4paWiMH8Qi t5OQ== X-Gm-Message-State: AOAM532wu1UT7jx+wjSiX1EiEmZ2VLuZHKfFW//TMDvLqIOm0VRkvTFO FZkoLzajkWPIRq2slJk6u/o= X-Google-Smtp-Source: ABdhPJz9GR5blkBoMY58veAVwcmSMDo29BUcNV1QcEUQxNVIvkB6gy7KKlrjrtCiqAKvzgYXZdNSLQ== X-Received: by 2002:a17:907:2115:: with SMTP id qn21mr7366844ejb.278.1601127723572; Sat, 26 Sep 2020 06:42:03 -0700 (PDT) Received: from kozik-lap ([194.230.155.132]) by smtp.googlemail.com with ESMTPSA id jo26sm4156240ejb.120.2020.09.26.06.42.01 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 26 Sep 2020 06:42:02 -0700 (PDT) Date: Sat, 26 Sep 2020 15:41:57 +0200 From: Krzysztof Kozlowski To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Thierry Reding , Lee Jones , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Philipp Zabel , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: pwm: imx: document i.MX compatibles Message-ID: <20200926134157.GA4730@kozik-lap> References: <20200925212609.23093-1-krzk@kernel.org> <20200926132217.xr3rhv7o2o2yc2l7@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20200926132217.xr3rhv7o2o2yc2l7@pengutronix.de> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org On Sat, Sep 26, 2020 at 03:22:17PM +0200, Uwe Kleine-König wrote: > On Fri, Sep 25, 2020 at 11:26:09PM +0200, Krzysztof Kozlowski wrote: > > Document all ARMv5, ARMv6 and ARMv7 i.MX compatibles to fix dtbs_check > > warnings like: > > > > arch/arm/boot/dts/imx6dl-colibri-eval-v3.dt.yaml: pwm@2080000: compatible:0: > > 'fsl,imx6q-pwm' is not one of ['fsl,imx8mm-pwm', 'fsl,imx8mn-pwm', 'fsl,imx8mp-pwm', 'fsl,imx8mq-pwm'] > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml > > index 473863eb67e5..379d693889f6 100644 > > --- a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml > > +++ b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml > > @@ -25,6 +25,17 @@ properties: > > - fsl,imx27-pwm > > - items: > > - enum: > > + - fsl,imx25-pwm > > The driver actually used fsl,imx27-pwm to bind ... Yes, most of i.MX drivers use only few compatibles but DTSes and bindings use multiple of them. I was convinced during various talks that the specific compatibles (so "fsl,imx6q-pwm, fsl,imx27-pwm") are preferred than generic ones (so only "fsl,imx27-pwm"). NXP took it to the another level creating compatibles for absolutely every flavor of their CPU. And they mainlined it in DTSes... The PWM is this crazy examples where, as you say, only two compatibles are actually used for binding but DTSes uses more. > > Also since v5.1-rc1~38^2~17 the driver is split into pwm-imx27 and > pwm-imx1. So maybe this file should be renamed to fsl,imx27-pwm.yaml? > (And we need a volunteer to write fsl,imx1-pwm.yaml.) I think there is no need, because the binding describes the hardware and could be supported by multiple drivers. I actually recently merged few bindings (i.MX 8 clocks, NXP PCA953x/max GPIO expanders). Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42432C2D0A8 for ; Sat, 26 Sep 2020 13:43:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DDAFA208FE for ; Sat, 26 Sep 2020 13:43:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="noqgPJoE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DDAFA208FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Eu0U8PDa6wsFi1um+llIVfx6dk9TXShCOI4UqotlzEc=; b=noqgPJoEJTkGR3jkG+DjHsQLb USFbhuMOLALDgqTzkIWkqHFcB5tgnmCGEOV4AwzFfceqoPd5a/glpjPWHvQmM+yd2HI6QH7Uh7RzR YeexsiPx+kgnQEtQzqTbjjySFtNzvI6cqQsLDcrC5+5re+vgLccpgE5TjZvwB2hJ5411TyKDqkLsf xziaNReAadVPIwdky07KxJXUDexzAPrRFYMBS9Ugi3H5d7rpOlGraFgWawswe4Ub+QqqW5zE4+J0r 9PEvPtFbxK9JkhL/SW50tCkBUR7FMP3vqiy98b7p9zqw+6SWMsaaZFZbnFZ5usV+22s9cyAR2R53V Ho9rniVgA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMASl-0004Fe-UV; Sat, 26 Sep 2020 13:42:07 +0000 Received: from mail-ej1-f68.google.com ([209.85.218.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMASi-0004FE-Tt for linux-arm-kernel@lists.infradead.org; Sat, 26 Sep 2020 13:42:05 +0000 Received: by mail-ej1-f68.google.com with SMTP id r7so2325072ejs.11 for ; Sat, 26 Sep 2020 06:42:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=zZiC4GFLiCyxWh5u5vGAPSFiD3LqckqVR10/0vflwwg=; b=ijRmZSqCLt+5IFw8lG/uUq+if4H3SIEX5yXcnwtC7kQfhOFXlaBQMKGqpz1yrjhSd9 Br9IbRc0AgBgh9lIHlmaAGbVCaCWz70n1pYhonnYRxyocSkjpR5C7o0K6LtMpsteRbUI kxJOyHd+lhVkQfNnYaYlhIrebqJU2coZIdGYPKFQtOvUKJqT3QIIt8UHnmtR4H9WX0e5 BZjRKkFZcaDC+M+19It/Fp3ciwApqx44fMTkSsORckzhFU+dw/eM4McTadfKOlg76bIg M3lE+GRqGmSAlFbW7FSbek6pcsIemqEOz0gj/Sb5Di2ohsC7QMMcUrycJu+59wWodAd9 Iotg== X-Gm-Message-State: AOAM532uSWJtHmCSvFk2f2aujFmqSOKEp+0MCzKSkR9hyFIDaJucMQfg 6ncFk4hrYQRxqz+iU1gt294= X-Google-Smtp-Source: ABdhPJz9GR5blkBoMY58veAVwcmSMDo29BUcNV1QcEUQxNVIvkB6gy7KKlrjrtCiqAKvzgYXZdNSLQ== X-Received: by 2002:a17:907:2115:: with SMTP id qn21mr7366844ejb.278.1601127723572; Sat, 26 Sep 2020 06:42:03 -0700 (PDT) Received: from kozik-lap ([194.230.155.132]) by smtp.googlemail.com with ESMTPSA id jo26sm4156240ejb.120.2020.09.26.06.42.01 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 26 Sep 2020 06:42:02 -0700 (PDT) Date: Sat, 26 Sep 2020 15:41:57 +0200 From: Krzysztof Kozlowski To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Subject: Re: [PATCH] dt-bindings: pwm: imx: document i.MX compatibles Message-ID: <20200926134157.GA4730@kozik-lap> References: <20200925212609.23093-1-krzk@kernel.org> <20200926132217.xr3rhv7o2o2yc2l7@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200926132217.xr3rhv7o2o2yc2l7@pengutronix.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200926_094204_964908_81D3FF08 X-CRM114-Status: GOOD ( 21.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, Fabio Estevam , Philipp Zabel , devicetree@vger.kernel.org, Lee Jones , Sascha Hauer , linux-kernel@vger.kernel.org, Rob Herring , Thierry Reding , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU2F0LCBTZXAgMjYsIDIwMjAgYXQgMDM6MjI6MTdQTSArMDIwMCwgVXdlIEtsZWluZS1Lw7Zu aWcgd3JvdGU6Cj4gT24gRnJpLCBTZXAgMjUsIDIwMjAgYXQgMTE6MjY6MDlQTSArMDIwMCwgS3J6 eXN6dG9mIEtvemxvd3NraSB3cm90ZToKPiA+IERvY3VtZW50IGFsbCBBUk12NSwgQVJNdjYgYW5k IEFSTXY3IGkuTVggY29tcGF0aWJsZXMgdG8gZml4IGR0YnNfY2hlY2sKPiA+IHdhcm5pbmdzIGxp a2U6Cj4gPiAKPiA+ICAgYXJjaC9hcm0vYm9vdC9kdHMvaW14NmRsLWNvbGlicmktZXZhbC12My5k dC55YW1sOiBwd21AMjA4MDAwMDogY29tcGF0aWJsZTowOgo+ID4gICAgICdmc2wsaW14NnEtcHdt JyBpcyBub3Qgb25lIG9mIFsnZnNsLGlteDhtbS1wd20nLCAnZnNsLGlteDhtbi1wd20nLCAnZnNs LGlteDhtcC1wd20nLCAnZnNsLGlteDhtcS1wd20nXQo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBL cnp5c3p0b2YgS296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+Cj4gPiAtLS0KPiA+ICBEb2N1bWVu dGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcHdtL2lteC1wd20ueWFtbCB8IDExICsrKysrKysr KysrCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKykKPiA+IAo+ID4gZGlmZiAt LWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9wd20vaW14LXB3bS55YW1s IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3B3bS9pbXgtcHdtLnlhbWwKPiA+ IGluZGV4IDQ3Mzg2M2ViNjdlNS4uMzc5ZDY5Mzg4OWY2IDEwMDY0NAo+ID4gLS0tIGEvRG9jdW1l bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3B3bS9pbXgtcHdtLnlhbWwKPiA+ICsrKyBiL0Rv Y3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9wd20vaW14LXB3bS55YW1sCj4gPiBAQCAt MjUsNiArMjUsMTcgQEAgcHJvcGVydGllczoKPiA+ICAgICAgICAgICAgLSBmc2wsaW14MjctcHdt Cj4gPiAgICAgICAgLSBpdGVtczoKPiA+ICAgICAgICAgICAgLSBlbnVtOgo+ID4gKyAgICAgICAg ICAgICAgLSBmc2wsaW14MjUtcHdtCj4gCj4gVGhlIGRyaXZlciBhY3R1YWxseSB1c2VkIGZzbCxp bXgyNy1wd20gdG8gYmluZCAuLi4KClllcywgbW9zdCBvZiBpLk1YIGRyaXZlcnMgdXNlIG9ubHkg ZmV3IGNvbXBhdGlibGVzIGJ1dCBEVFNlcyBhbmQKYmluZGluZ3MgdXNlIG11bHRpcGxlIG9mIHRo ZW0uICBJIHdhcyBjb252aW5jZWQgZHVyaW5nIHZhcmlvdXMgdGFsa3MKdGhhdCB0aGUgc3BlY2lm aWMgY29tcGF0aWJsZXMgKHNvICJmc2wsaW14NnEtcHdtLCBmc2wsaW14MjctcHdtIikgYXJlCnBy ZWZlcnJlZCB0aGFuIGdlbmVyaWMgb25lcyAoc28gb25seSAiZnNsLGlteDI3LXB3bSIpLiBOWFAg dG9vayBpdAp0byB0aGUgYW5vdGhlciBsZXZlbCBjcmVhdGluZyBjb21wYXRpYmxlcyBmb3IgYWJz b2x1dGVseSBldmVyeSBmbGF2b3Igb2YKdGhlaXIgQ1BVLiBBbmQgdGhleSBtYWlubGluZWQgaXQg aW4gRFRTZXMuLi4KClRoZSBQV00gaXMgdGhpcyBjcmF6eSBleGFtcGxlcyB3aGVyZSwgYXMgeW91 IHNheSwgb25seSB0d28gY29tcGF0aWJsZXMKYXJlIGFjdHVhbGx5IHVzZWQgZm9yIGJpbmRpbmcg YnV0IERUU2VzIHVzZXMgbW9yZS4KCj4gCj4gQWxzbyBzaW5jZSB2NS4xLXJjMX4zOF4yfjE3IHRo ZSBkcml2ZXIgaXMgc3BsaXQgaW50byBwd20taW14MjcgYW5kCj4gcHdtLWlteDEuIFNvIG1heWJl IHRoaXMgZmlsZSBzaG91bGQgYmUgcmVuYW1lZCB0byBmc2wsaW14MjctcHdtLnlhbWw/Cj4gKEFu ZCB3ZSBuZWVkIGEgdm9sdW50ZWVyIHRvIHdyaXRlIGZzbCxpbXgxLXB3bS55YW1sLikKCkkgdGhp bmsgdGhlcmUgaXMgbm8gbmVlZCwgYmVjYXVzZSB0aGUgYmluZGluZyBkZXNjcmliZXMgdGhlIGhh cmR3YXJlIGFuZApjb3VsZCBiZSBzdXBwb3J0ZWQgYnkgbXVsdGlwbGUgZHJpdmVycy4gSSBhY3R1 YWxseSByZWNlbnRseSBtZXJnZWQgZmV3CmJpbmRpbmdzIChpLk1YIDggY2xvY2tzLCBOWFAgUENB OTUzeC9tYXggR1BJTyBleHBhbmRlcnMpLgoKQmVzdCByZWdhcmRzLApLcnp5c3p0b2YKCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg==