From: Christoph Hellwig <hch@lst.de>
To: Pavel Machek <pavel@ucw.cz>
Cc: Christoph Hellwig <hch@lst.de>, Tejun Heo <tj@kernel.org>,
Jens Axboe <axboe@kernel.dk>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>, Minho Ban <mhban@samsung.com>,
cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 2/2] PM/hibernate: remove the bogus call to get_gendisk in software_resume
Date: Sat, 26 Sep 2020 16:05:26 +0200 [thread overview]
Message-ID: <20200926140526.GA10379@lst.de> (raw)
In-Reply-To: <20200925183828.GC7253@duo.ucw.cz>
On Fri, Sep 25, 2020 at 08:38:28PM +0200, Pavel Machek wrote:
> > - * name_to_dev_t is ineffective to verify parition if resume_file is in
> > - * integer format. (e.g. major:minor)
> > - */
> > - if (isdigit(resume_file[0]) && resume_wait) {
> > - int partno;
> > - while (!get_gendisk(swsusp_resume_device, &partno))
> > - msleep(10);
> > - }
>
> I believe point of this code was to wait for resume device to appear
> -- see the resume_wait condition. It should not be simply removed.
But get_gendisk has absolutely no relation to a device appearing. So
whatever this code tried to do doesn't make any sense.
next prev parent reply other threads:[~2020-09-26 14:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 16:14 RFC: sort out get_gendisk abuses Christoph Hellwig
2020-09-25 16:14 ` [PATCH 1/2] blk-cgroup: stop abusing get_gendisk Christoph Hellwig
2020-09-25 16:14 ` [PATCH 2/2] PM/hibernate: remove the bogus call to get_gendisk in software_resume Christoph Hellwig
[not found] ` <20200925161447.1486883-3-hch-jcswGhMUV9g@public.gmane.org>
2020-09-25 18:38 ` Pavel Machek
2020-09-25 18:38 ` Pavel Machek
2020-09-26 14:05 ` Christoph Hellwig [this message]
2020-09-30 15:45 ` Rafael J. Wysocki
2020-09-30 15:45 ` Rafael J. Wysocki
[not found] ` <CAJZ5v0h8TbOZ=seE8+OqFKTRxOYK25aTXDam7Lez0VR5qnkM3Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-10-02 6:50 ` Christoph Hellwig
2020-10-02 6:50 ` Christoph Hellwig
[not found] ` <20201002065015.GA9691-jcswGhMUV9g@public.gmane.org>
2020-10-02 14:11 ` Rafael J. Wysocki
2020-10-02 14:11 ` Rafael J. Wysocki
[not found] ` <20200925161447.1486883-1-hch-jcswGhMUV9g@public.gmane.org>
2020-09-30 16:17 ` RFC: sort out get_gendisk abuses Tejun Heo
2020-09-30 16:17 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200926140526.GA10379@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=len.brown@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mhban@samsung.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.